Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033476Openbravo ERPB. User interfacepublic2016-07-13 17:312016-08-30 10:16
Reporterrbianchini 
Assigned Tocaristu 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0PR16Q2.1 
Target Version3.0PR16Q4Fixed in Version3.0PR16Q4 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033476: Issue with saved view filtered by created by
DescriptionIf define a saved view filtered by created by, the filtered have a strange behaviour. Watch the attached video to clarify

The issue was reproduced in 15Q3.5, 15Q4.6, 16Q1.3, 16Q2.1

Note that it is a common user goal in some cases to filter on only the rows created by that user. Customer
considers this a major issue, since they have a number of new high profile users and are establishing standards
for use of saved views.

Note also - I show the Sales Order window - but this behavior manifests on other windows
Steps To Reproduce1 - Log in the application
2 - Go to sales order
3 - Clear the filter and show the created by field in grid view
4 - Use the created by field to filter by one user
5 - Save the view and set as default
6 - close the window and open it again
7 - try to change the filter and realize that all values are the same (watch the video)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0033112 closed caristu Filters not shown on a Query Only window when setting an HQL filter clause 
Attached Files? saved view issue.mkv (2,183,188) 2016-07-13 17:31
https://issues.openbravo.com/file_download.php?file_id=9626&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-07-13 17:31rbianchiniNew Issue
2016-07-13 17:31rbianchiniAssigned To => platform
2016-07-13 17:31rbianchiniFile Added: saved view issue.mkv
2016-07-13 17:31rbianchiniModules => Core
2016-07-13 17:31rbianchiniTriggers an Emergency Pack => No
2016-07-13 17:35rbianchiniResolution time => 1470193200
2016-07-15 08:39alostaleStatusnew => acknowledged
2016-07-15 08:41alostaleRelationship addedrelated to 0033112
2016-07-28 13:57caristuAssigned Toplatform => caristu
2016-07-29 09:57caristuStatusacknowledged => scheduled
2016-07-29 09:57caristuResolution time1470193200 => 1470175200
2016-07-29 09:57caristuTarget Version => 3.0PR16Q4
2016-07-29 11:41hgbotCheckin
2016-07-29 11:41hgbotNote Added: 0088699
2016-07-29 11:41hgbotStatusscheduled => resolved
2016-07-29 11:41hgbotResolutionopen => fixed
2016-07-29 11:41hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1ab2615fd80d5ef201268624991e4192d675c5b4 [^]
2016-07-29 11:42caristuNote Edited: 0088699bug_revision_view_page.php?bugnote_id=0088699#r12750
2016-07-29 11:43caristuReview Assigned To => alostale
2016-07-29 11:45hgbotCheckin
2016-07-29 11:45hgbotNote Added: 0088700
2016-08-11 18:40hudsonbotCheckin
2016-08-11 18:40hudsonbotNote Added: 0089026
2016-08-30 10:16alostaleNote Added: 0089534
2016-08-30 10:16alostaleStatusresolved => closed
2016-08-30 10:16alostaleFixed in Version => 3.0PR16Q4

Notes
(0088699)
hgbot   
2016-07-29 11:41   
(edited on: 2016-07-29 11:42)
Repository: erp/devel/pi
Changeset: 1ab2615fd80d5ef201268624991e4192d675c5b4
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Jul 29 11:40:03 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1ab2615fd80d5ef201268624991e4192d675c5b4 [^]

fixes issue 33476: Wrong behavior in created/updated by filter with saved view

After applying the saved view, regarding the 'Created By' field, the displayField property ('_identifier') of the filter editor was being replaced with the display field of the field itself ('createdBy$_identifier'). Therefore, after applying the saved view the values being displayed within the filter drop-down were the 'Created By' values for the entity referenced by the 'Created By' field (User). The same applies for the 'Updated By' field.

The root cause of this problem was that the fkField property for 'Created By' and 'Updated By' fields was not set to true. This allows to configure properly the filterEditorProperties on the client side for those fields, including the displayField whose value is set to '_identifier'.

From now the displayField property is set for the 'Created By' and 'Updated By' on the prepareGridFields() function, this way it will not be overridden after applying the saved view.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewFieldHandler.java
---
(0088700)
hgbot   
2016-07-29 11:45   
Repository: erp/devel/pi
Changeset: 1ab2615fd80d5ef201268624991e4192d675c5b4
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Jul 29 11:40:03 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1ab2615fd80d5ef201268624991e4192d675c5b4 [^]

fixes issue 33476: Wrong behavior in created/updated by filter with saved view

After applying the saved view, regarding the 'Created By' field, the displayField property ('_identifier') of the filter editor was being replaced with the display field of the field itself ('createdBy'). Therefore, after applying the saved view the values being displayed within the filter drop-down were the 'Created By' values for the entity referenced by the 'Created By' field (User). The same applies for the 'Updated By' field.

The root cause of this problem was that the fkField property for 'Created By' and 'Updated By' fields was not set to true. This allows to configure properly the filterEditorProperties on the client side for those fields, including the displayField whose value is set to '_identifier'.

From now the displayField property is set for the 'Created By' and 'Updated By' on the prepareGridFields() function, this way it will not be overridden after applying the saved view.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewFieldHandler.java
---
(0089026)
hudsonbot   
2016-08-11 18:40   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/edaa05b1fb18 [^]
Maturity status: Test
(0089534)
alostale   
2016-08-30 10:16   
code reviewed

tested with:
* Standard settings without saved views
* Saved default view
* Saved view not set as default