Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033472Retail ModulesWeb POSpublic2016-07-13 12:482016-09-20 17:05
ReporterSandrahuguet 
Assigned ToSandrahuguet 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033472: Improve filtering by characteristics in local mode
DescriptionImprove filtering by characteristics in local mode
Steps To ReproduceN/A
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0034204 closed Sandrahuguet [PriceCriteria] Improve filtering by characteristics in local mode 
causes defect 0034398 closed ranjith_qualiantech_com Characteristics are not filtered correctly 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-07-13 12:48SandrahuguetNew Issue
2016-07-13 12:48SandrahuguetAssigned To => Sandrahuguet
2016-07-13 12:48SandrahuguetOBNetwork customer => No
2016-07-13 12:48SandrahuguetTriggers an Emergency Pack => No
2016-07-13 12:49SandrahuguetReview Assigned To => marvintm
2016-07-13 12:49SandrahuguetStatusnew => scheduled
2016-07-13 12:49SandrahuguetDescription Updatedbug_revision_view_page.php?rev_id=12636#r12636
2016-07-13 13:17SandrahuguetSummaryImprove filtering by characteristics in local model => Improve filtering by characteristics in local mode
2016-07-15 08:20hgbotCheckin
2016-07-15 08:20hgbotNote Added: 0088508
2016-07-15 08:20hgbotStatusscheduled => resolved
2016-07-15 08:20hgbotResolutionopen => fixed
2016-07-15 08:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2e40758fb9df6e1dd0178d48198ce4a2ef58647a [^]
2016-07-15 08:21hgbotCheckin
2016-07-15 08:21hgbotNote Added: 0088509
2016-07-15 08:21hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2e40758fb9df6e1dd0178d48198ce4a2ef58647a [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/447f4811440c4bcb96e2981542a6273e14d6a25c [^]
2016-07-15 12:04marvintmNote Added: 0088519
2016-07-15 12:04marvintmStatusresolved => new
2016-07-15 12:04marvintmResolutionfixed => open
2016-07-15 12:06marvintmStatusnew => acknowledged
2016-07-15 12:55SandrahuguetNote Added: 0088528
2016-08-05 13:05SandrahuguetNote Added: 0088845
2016-08-05 13:09hgbotCheckin
2016-08-05 13:09hgbotNote Added: 0088846
2016-08-05 13:13hgbotCheckin
2016-08-05 13:13hgbotNote Added: 0088847
2016-08-05 13:13SandrahuguetStatusacknowledged => scheduled
2016-08-05 13:13SandrahuguetStatusscheduled => resolved
2016-08-05 13:13SandrahuguetResolutionopen => fixed
2016-08-30 11:57migueldejuanaNote Added: 0089543
2016-08-30 11:57migueldejuanaStatusresolved => new
2016-08-30 11:57migueldejuanaResolutionfixed => open
2016-08-30 11:57migueldejuanaNote Edited: 0089543bug_revision_view_page.php?bugnote_id=0089543#r12969
2016-08-30 11:57migueldejuanaNote Edited: 0089543bug_revision_view_page.php?bugnote_id=0089543#r12970
2016-08-31 14:25SandrahuguetNote Added: 0089619
2016-09-02 12:00hgbotCheckin
2016-09-02 12:00hgbotNote Added: 0089696
2016-09-02 12:01hgbotCheckin
2016-09-02 12:01hgbotNote Added: 0089697
2016-09-02 12:02hgbotCheckin
2016-09-02 12:02hgbotNote Added: 0089698
2016-09-02 12:18SandrahuguetStatusnew => scheduled
2016-09-02 12:18SandrahuguetStatusscheduled => resolved
2016-09-02 12:18SandrahuguetResolutionopen => fixed
2016-09-20 17:05migueldejuanaReview Assigned Tomarvintm => migueldejuana
2016-09-20 17:05migueldejuanaNote Added: 0090119
2016-09-20 17:05migueldejuanaStatusresolved => closed
2016-10-13 17:57SandrahuguetRelationship addedrelated to 0034204
2016-11-04 14:38migueldejuanaRelationship addedcauses 0034398

Notes
(0088508)
hgbot   
2016-07-15 08:20   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2e40758fb9df6e1dd0178d48198ce4a2ef58647a
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Thu Jul 14 18:37:36 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2e40758fb9df6e1dd0178d48198ce4a2ef58647a [^]

Fixed issue 33472 Improve filtering by characteristics in local mode

---
M src/org/openbravo/retail/posterminal/master/Characteristic.java
M src/org/openbravo/retail/posterminal/master/CharacteristicValue.java
M web/org.openbravo.retail.posterminal/js/components/modalproductbrand.js
M web/org.openbravo.retail.posterminal/js/components/modalproductcharacteristic.js
---
(0088509)
hgbot   
2016-07-15 08:21   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 447f4811440c4bcb96e2981542a6273e14d6a25c
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Thu Jul 14 18:38:20 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/447f4811440c4bcb96e2981542a6273e14d6a25c [^]

Fixed issue 33472 Improve filtering by characteristics in local mode

---
M web/org.openbravo.mobile.core/source/retail/component/ob-retail-searchproductcharacteristic.js
---
(0088519)
marvintm   
2016-07-15 12:04   
There is at least one case which is currently still failing:
- Go to Search.
- Add filter by Object: First-Aid
- Add filter by Price: <20€
- There should be three products shown. This is correct, as both have First Aid, and price < 20€. However, there are at least two problems:
- Open the Dimensions characteristic. Realize that the popup is empty. This should never happen, if there is no valid characteristic value, the characteristic should not be shown.
- Open the Capacity characteristic. Select the Under 2L characteristic value. Realize that no products are selected. This should not happen, as if there are no products for a value, then it should not be shown (and in this case, as there are no more values valid, the characteristic itself should also not be shown).
(0088528)
Sandrahuguet   
2016-07-15 12:55   
another issue:
-Go to Search
-Add filter by Brand: Beal and Black Diamond
-tap on Brand again, brands are unfiltered
(0088845)
Sandrahuguet   
2016-08-05 13:05   
Issues mentioned above are reproduced in normal mode and in remote mode
(0088846)
hgbot   
2016-08-05 13:09   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: edf019093706dbf8d6c2197df93af76801b51753
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Fri Aug 05 13:07:54 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/edf019093706dbf8d6c2197df93af76801b51753 [^]

related to issue 33472 fixed issues in product search by characteristics and brand

Issue 1: https://issues.openbravo.com/view.php?id=33472#c88519 [^]
Issue 2: https://issues.openbravo.com/view.php?id=33472#c88528 [^]

Issues mentioned above are fixed in normal mode and in remote mode

---
M src/org/openbravo/retail/posterminal/ChHQLCriteria.java
M src/org/openbravo/retail/posterminal/ChvHQLCriteria.java
M src/org/openbravo/retail/posterminal/master/Brand.java
M web/org.openbravo.retail.posterminal/js/components/modalproductbrand.js
M web/org.openbravo.retail.posterminal/js/components/modalproductcharacteristic.js
---
(0088847)
hgbot   
2016-08-05 13:13   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 0b3137a4bb61b5a30429e93fcab61835696c1684
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Fri Aug 05 13:11:26 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0b3137a4bb61b5a30429e93fcab61835696c1684 [^]

related to issue 33472 fixed issues in product search by characteristics and brand

Issue 1: https://issues.openbravo.com/view.php?id=33472#c88519 [^]
Issue 2: https://issues.openbravo.com/view.php?id=33472#c88528 [^]

Issues mentioned above are fixed in normal mode and in remote mode

---
M src/org/openbravo/mobile/core/process/SimpleQueryBuilder.java
M web/org.openbravo.mobile.core/source/retail/component/ob-retail-searchproductcharacteristic.js
---
(0089543)
migueldejuana   
2016-08-30 11:57   
- Go to search tab
- Enter 'mul' text to filter
- Open Object characteristic and check 'Camping Accessories'
- You will see just Multi-tool product (Price:50€ - 100€)
- Open Price characteristic and you will 2 values:
     - "< 20€" --> ERROR! This value shouldn't appear
     - "50€ - 100€"
(0089619)
Sandrahuguet   
2016-08-31 14:25   
Issue mentioned above is reproduced in normal mode and in remote mode
(0089696)
hgbot   
2016-09-02 12:00   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 0547ef7915f8cd926a518dd830c3fc6fac5ca2fa
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Thu Sep 01 09:03:16 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0547ef7915f8cd926a518dd830c3fc6fac5ca2fa [^]

related to issue 33472 fixed issue filter by characteristic

Issue 3: https://issues.openbravo.com/view.php?id=33472#c89543 [^]

---
M src/org/openbravo/retail/posterminal/PCharacteristicHQLCriteria.java
M src/org/openbravo/retail/posterminal/ProductCharacteristicHQLCriteria.java
M web/org.openbravo.retail.posterminal/js/components/modalproductcharacteristic.js
R src/org/openbravo/retail/posterminal/ChHQLCriteria.java
R src/org/openbravo/retail/posterminal/ChvHQLCriteria.java
---
(0089697)
hgbot   
2016-09-02 12:01   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: e911efebab0bbd7a769090981041abf57c68fd79
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Thu Sep 01 10:27:08 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/e911efebab0bbd7a769090981041abf57c68fd79 [^]

related to issue 33472 fixed issue filter by characteristic

Issue 3: https://issues.openbravo.com/view.php?id=33472#c89543 [^]

---
M web/org.openbravo.mobile.core/source/retail/component/ob-retail-searchproductcharacteristic.js
---
(0089698)
hgbot   
2016-09-02 12:02   
Repository: erp/pmods/org.openbravo.retail.bestsellers
Changeset: 1aa7a4df85831af36596c7c4b3080b7c56fa077f
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Thu Sep 01 10:44:05 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.bestsellers/rev/1aa7a4df85831af36596c7c4b3080b7c56fa077f [^]

related to issue 33472 fixed issue filter by characteristic

Issue 3: https://issues.openbravo.com/view.php?id=33472#c89543 [^]

---
M src/org/openbravo/retail/bestsellers/PCharacteristicBestSellerHQLCriteria.java
M src/org/openbravo/retail/bestsellers/PCharacteristicValueBestSellerHQLCriteria.java
---
(0090119)
migueldejuana   
2016-09-20 17:05   
Tested and reviewed