Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033463Openbravo ERP09. Financial managementpublic2016-07-12 11:242016-08-12 08:44
ReporterSanjota 
Assigned Tovmromanos 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033463: API Change Request : Change in the signature of the method selectFactAcct() present in AccountTree_Data.xsql
DescriptionRelated to issue 33460 : Ability to launch the report without comparing it with a previous year

The Balance sheet and PL report always expect reference year(Reference Year is mandatory)

We wanted to make Reference year as optional. So created new field called "Compare To", based on which the reference year field can be put as Optional.

The xsql query in charge of getting the data now has a new parameter to control whether to query or not for the comparative year. Thus we can improve the performance of the query, avoiding to retrieve data that is not going to be shown later on in the report.
 
This xsql file builds a public class and method. The method now has a new parameter which creates the API change:


Missing
method org.openbravo.erpCommon.businessUtility.AccountTreeData.selectFactAcct(org.openbravo.database.ConnectionProvider, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String): missing in /srv/ci/workspace/try-full-pgsql/SANDBOX/api-checks/output/java
method org.openbravo.erpCommon.businessUtility.AccountTreeData.selectFactAcct(org.openbravo.database.ConnectionProvider, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, int, int): missing in /srv/ci/workspace/try-full-pgsql/SANDBOX/api-checks/output/java
Steps To Reproducehttps://ci.openbravo.com//job/try-api/3759/ [^]
Proposed SolutionThe API change has a very low impact.
This method is only used by Core, in the balance sheet & PL report we are modifying.
We have checked that none of the modules in the forge use that method, so the API change can be safely approved.

Additional Information
TagsApproved
Relationships
blocks feature request 0033460 closed Sanjota Ability to launch the report without comparing it with a previous year 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-07-12 11:24SanjotaNew Issue
2016-07-12 11:24SanjotaAssigned To => dmitry_mezentsev
2016-07-12 11:24SanjotaModules => Core
2016-07-12 11:24SanjotaTriggers an Emergency Pack => No
2016-07-12 11:26SanjotaRelationship addedblocks 0033460
2016-07-12 11:27SanjotaReview Assigned To => dmitry_mezentsev
2016-07-12 11:42vmromanosPrioritynone => immediate
2016-07-12 11:42vmromanosTypefeature request => defect
2016-07-12 11:42vmromanosDescription Updatedbug_revision_view_page.php?rev_id=12627#r12627
2016-07-12 11:42vmromanosProposed Solution updated
2016-08-10 20:19dmitry_mezentsevTag Attached: Approved
2016-08-10 20:19dmitry_mezentsevAssigned Todmitry_mezentsev => Sanjota
2016-08-10 20:19dmitry_mezentsevNote Added: 0088961
2016-08-12 08:31vmromanosStatusnew => scheduled
2016-08-12 08:31vmromanosAssigned ToSanjota => vmromanos
2016-08-12 08:42hgbotCheckin
2016-08-12 08:42hgbotNote Added: 0089067
2016-08-12 08:42hgbotStatusscheduled => resolved
2016-08-12 08:42hgbotResolutionopen => fixed
2016-08-12 08:42hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/b3823e11c33d79b08659da3bf61990d5daa7168e [^]
2016-08-12 08:44vmromanosReview Assigned Todmitry_mezentsev => vmromanos
2016-08-12 08:44vmromanosStatusresolved => closed

Notes
(0088961)
dmitry_mezentsev   
2016-08-10 20:19   
Sorry about the delay
(0089067)
hgbot   
2016-08-12 08:42   
Repository: erp/devel/api-checks
Changeset: b3823e11c33d79b08659da3bf61990d5daa7168e
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Fri Aug 12 08:35:38 2016 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/b3823e11c33d79b08659da3bf61990d5daa7168e [^]

Fixed bug 33463: Java (from xsql) API change related to issue 33460

The xsql query in charge of getting the data now has a new parameter to control whether to query or not for the comparative year. Thus we can improve the performance of the query, avoiding to retrieve data that is not going to be shown later on in the report.

This xsql file builds a public Java class and method. The method now has a new parameter which creates the API change.

---
M java/reference/java.japi.gz
---