Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033460Openbravo ERP09. Financial managementpublic2016-07-11 14:272016-08-12 13:29
ReporterSanjota 
Assigned ToSanjota 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033460: Ability to launch the report without comparing it with a previous year
Descriptionthe ability to launch the report without comparing it with a previous year.
Noe: Make Reference Year field optional.
Steps To Reproduce1) Open Balance sheet and P&L Structure window.
2) Select following details
   General Ledger : F&B International Group US/A/US Dollar
   Accounting Report : Balance Sheet
   Organization : F&B Espana SA
   Account Level : Account
   Show only accounts with value : true(checked)
   Show Account codes : true(checked)
      
   Year : 2016
   As of Date : 11-07-2016
   Reference Year : 2016
   As of Date : 11-07-2016
   Initial page number
4) Click on PDF Format
5) Open the downloaded GeneralAccountingReportsPDF report,
   Notice that to choose reference year and it's details all the time.
Proposed SolutionUse Improved Balance Sheet's Balance sheet and PL report for reference present in the module org.openbravo.report.improved.balancesheet.
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0033463 closed vmromanos API Change Request : Change in the signature of the method selectFactAcct() present in AccountTree_Data.xsql 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-07-11 14:27SanjotaNew Issue
2016-07-11 14:27SanjotaAssigned To => Sanjota
2016-07-11 14:27SanjotaModules => Core
2016-07-11 14:27SanjotaTriggers an Emergency Pack => No
2016-07-11 14:28SanjotaNote Added: 0088373
2016-07-11 14:28SanjotaStatusnew => scheduled
2016-07-12 11:25SanjotaRelationship addeddepends on 0032703
2016-07-12 11:26SanjotaRelationship deleteddepends on 0032703
2016-07-12 11:26SanjotaRelationship addeddepends on 0033463
2016-08-09 09:59hgbotCheckin
2016-08-09 09:59hgbotNote Added: 0088916
2016-08-09 09:59hgbotStatusscheduled => resolved
2016-08-09 09:59hgbotResolutionopen => fixed
2016-08-09 09:59hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/87c9f038283f3663c60e0a04bd25ecbbe96495d3 [^]
2016-08-09 09:59hgbotCheckin
2016-08-09 09:59hgbotNote Added: 0088917
2016-08-09 09:59hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/87c9f038283f3663c60e0a04bd25ecbbe96495d3 [^] => http://code.openbravo.com/erp/devel/pi/rev/72acd4fea07e444d98596b0cec4e1f6ca4a147eb [^]
2016-08-09 10:00vmromanosReview Assigned To => vmromanos
2016-08-09 10:00vmromanosNote Added: 0088918
2016-08-09 10:00vmromanosStatusresolved => closed
2016-08-09 10:00vmromanosFixed in Version => 3.0PR16Q4
2016-08-09 10:58hgbotCheckin
2016-08-09 10:58hgbotNote Added: 0088920
2016-08-09 11:43vmromanosNote Added: 0088923
2016-08-09 11:43vmromanosStatusclosed => new
2016-08-09 11:43vmromanosResolutionfixed => open
2016-08-09 11:43vmromanosFixed in Version3.0PR16Q4 =>
2016-08-09 11:43vmromanosStatusnew => scheduled
2016-08-11 18:40hudsonbotCheckin
2016-08-11 18:40hudsonbotNote Added: 0089050
2016-08-11 18:40hudsonbotCheckin
2016-08-11 18:40hudsonbotNote Added: 0089051
2016-08-11 18:40hudsonbotCheckin
2016-08-11 18:40hudsonbotNote Added: 0089052
2016-08-12 08:41hgbotCheckin
2016-08-12 08:41hgbotNote Added: 0089063
2016-08-12 08:41hgbotStatusscheduled => resolved
2016-08-12 08:41hgbotResolutionopen => fixed
2016-08-12 08:41hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/72acd4fea07e444d98596b0cec4e1f6ca4a147eb [^] => http://code.openbravo.com/erp/devel/pi/rev/e368bb414b7e54f309aafef874c0fd25eed4eb58 [^]
2016-08-12 08:41hgbotCheckin
2016-08-12 08:41hgbotNote Added: 0089064
2016-08-12 08:41hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/e368bb414b7e54f309aafef874c0fd25eed4eb58 [^] => http://code.openbravo.com/erp/devel/pi/rev/7fa430ed866b2159831656291b1dbdb8a1b3dc57 [^]
2016-08-12 08:42hgbotCheckin
2016-08-12 08:42hgbotNote Added: 0089065
2016-08-12 08:42hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/7fa430ed866b2159831656291b1dbdb8a1b3dc57 [^] => http://code.openbravo.com/erp/devel/pi/rev/1e59b5f3ed0a99f968169666487bbf90cb216d18 [^]
2016-08-12 08:42hgbotCheckin
2016-08-12 08:42hgbotNote Added: 0089066
2016-08-12 08:44vmromanosNote Added: 0089068
2016-08-12 08:44vmromanosStatusresolved => closed
2016-08-12 13:29hudsonbotCheckin
2016-08-12 13:29hudsonbotNote Added: 0089088
2016-08-12 13:29hudsonbotCheckin
2016-08-12 13:29hudsonbotNote Added: 0089089
2016-08-12 13:29hudsonbotCheckin
2016-08-12 13:29hudsonbotNote Added: 0089090

Notes
(0088373)
Sanjota   
2016-07-11 14:28   
Test Plan:
1) Open Balance sheet and P&L Structure window.
2) Select following details
   General Ledger : F&B International Group US/A/US Dollar
   Accounting Report : Balance Sheet
   Organization : F&B Espana SA
   Account Level : Account
   Show only accounts with value : true(checked)
   Show Account codes : true(checked)
      
   Year : 2016
   As of Date : 11-07-2016
   
3) Notice that there is new field
   Compare To(checked by default)
   Reference Year : 2016
   As of Date : 11-07-2016
   Initial page number
4) Click on PDF Format
5) Open the downloaded GeneralAccountingReportsPDF report,
   Notice that you can see details of selected year along with reference year

1) Open Balance sheet and P&L Structure window.
2) Select following details
   General Ledger : F&B International Group US/A/US Dollar
   Accounting Report : Balance Sheet
   Organization : F&B Espana SA
   Account Level : Account
   Show only accounts with value : true(checked)
   Show Account codes : true(checked)
      
   Year : 2016
   As of Date : 11-07-2016
   
3) Notice that there is new field
   Compare To(checked by default)
   Deselect the compared to(un check)
4) Notice that the reference year field is not present
5) Click on PDF Format
6) Open the downloaded GeneralAccountingReportsPDF report,
   Notice that you can see details of selected year only. No reference year details is available.


Note: We use "Compare To" field to decide to have "Reference Year".
The Report(Balance sheet or PL report) Generated will have details of reference year based on the "Compare To" check mark.
i.e if "Compare To" is selected then PDF will have details of reference year too along with year selected
else only selected year details.
(0088916)
hgbot   
2016-08-09 09:59   
Repository: erp/devel/pi
Changeset: 87c9f038283f3663c60e0a04bd25ecbbe96495d3
Author: Sanjota <sanjota.nelagi <at> promantia.com>
Date: Mon Jul 11 22:13:15 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/87c9f038283f3663c60e0a04bd25ecbbe96495d3 [^]

Fixes issue 33460 : New field for comparing ref year in Balance sheet & PL rep.

New field "Compare To" created to have reference year as optional
Code reference from org.openbravo.report.improved.balancesheet module.

---
M src-db/database/sourcedata/AD_TEXTINTERFACES.xml
M src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReports.html
M src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReports.java
M src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReports.xml
M src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReportsPDF.jrxml
M src/org/openbravo/erpCommon/businessUtility/AccountTree_data.xsql
---
(0088917)
hgbot   
2016-08-09 09:59   
Repository: erp/devel/pi
Changeset: 72acd4fea07e444d98596b0cec4e1f6ca4a147eb
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Aug 09 09:50:55 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/72acd4fea07e444d98596b0cec4e1f6ca4a147eb [^]

Fixed issue 33460: code review improvements

Avoid NullPointerException in non-compartive mode
In JasperReport:
 * Band height for details restored to 15, so we have the same number of lines as before the change
 * Period N-1 label only shown in comparative mode

---
M src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReports.java
M src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReportsPDF.jrxml
M src/org/openbravo/erpCommon/businessUtility/AccountTree_data.xsql
---
(0088918)
vmromanos   
2016-08-09 10:00   
Code review + testing OK
(0088920)
hgbot   
2016-08-09 10:58   
Repository: erp/devel/pi
Changeset: 036a261e3b6f694fe2607a7f53b1f55de4fa9e73
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Aug 09 10:57:46 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/036a261e3b6f694fe2607a7f53b1f55de4fa9e73 [^]

Related to issue 33460: Temporary backout till API change is approved

---
M src-db/database/sourcedata/AD_TEXTINTERFACES.xml
M src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReports.html
M src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReports.java
M src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReports.xml
M src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReportsPDF.jrxml
M src/org/openbravo/erpCommon/businessUtility/AccountTree_data.xsql
---
(0088923)
vmromanos   
2016-08-09 11:43   
Reopened till the API Change is approved
(0089052)
hudsonbot   
2016-08-11 18:40   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/edaa05b1fb18 [^]
Maturity status: Test
(0089051)
hudsonbot   
2016-08-11 18:40   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/edaa05b1fb18 [^]
Maturity status: Test
(0089050)
hudsonbot   
2016-08-11 18:40   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/edaa05b1fb18 [^]
Maturity status: Test
(0089063)
hgbot   
2016-08-12 08:41   
Repository: erp/devel/pi
Changeset: e368bb414b7e54f309aafef874c0fd25eed4eb58
Author: Sanjota <sanjota.nelagi <at> promantia.com>
Date: Mon Jul 11 22:13:15 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e368bb414b7e54f309aafef874c0fd25eed4eb58 [^]

Fixes issue 33460 : New field for comparing ref year in Balance sheet & PL rep.

New field "Compare To" created to have reference year as optional
Code reference from org.openbravo.report.improved.balancesheet module.

---
M src-db/database/sourcedata/AD_TEXTINTERFACES.xml
M src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReports.html
M src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReports.java
M src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReports.xml
M src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReportsPDF.jrxml
M src/org/openbravo/erpCommon/businessUtility/AccountTree_data.xsql
---
(0089064)
hgbot   
2016-08-12 08:41   
Repository: erp/devel/pi
Changeset: 7fa430ed866b2159831656291b1dbdb8a1b3dc57
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Aug 09 09:50:55 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/7fa430ed866b2159831656291b1dbdb8a1b3dc57 [^]

Fixed issue 33460: code review improvements

Avoid NullPointerException in non-compartive mode
In JasperReport:
 * Band height for details restored to 15, so we have the same number of lines as before the change
 * Period N-1 label only shown in comparative mode

---
M src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReports.java
M src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReportsPDF.jrxml
M src/org/openbravo/erpCommon/businessUtility/AccountTree_data.xsql
---
(0089065)
hgbot   
2016-08-12 08:42   
Repository: erp/devel/pi
Changeset: 1e59b5f3ed0a99f968169666487bbf90cb216d18
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Tue Aug 09 11:24:49 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1e59b5f3ed0a99f968169666487bbf90cb216d18 [^]

Fixed issue 33460: fixed dbcons

---
M src-db/database/sourcedata/AD_TEXTINTERFACES.xml
---
(0089066)
hgbot   
2016-08-12 08:42   
Repository: erp/devel/api-checks
Changeset: b3823e11c33d79b08659da3bf61990d5daa7168e
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Fri Aug 12 08:35:38 2016 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/b3823e11c33d79b08659da3bf61990d5daa7168e [^]

Fixed bug 33463: Java (from xsql) API change related to issue 33460

The xsql query in charge of getting the data now has a new parameter to control whether to query or not for the comparative year. Thus we can improve the performance of the query, avoiding to retrieve data that is not going to be shown later on in the report.

This xsql file builds a public Java class and method. The method now has a new parameter which creates the API change.

---
M java/reference/java.japi.gz
---
(0089068)
vmromanos   
2016-08-12 08:44   
Code review + testing OK
(0089088)
hudsonbot   
2016-08-12 13:29   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dee9bec25144 [^]
Maturity status: Test
(0089089)
hudsonbot   
2016-08-12 13:29   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dee9bec25144 [^]
Maturity status: Test
(0089090)
hudsonbot   
2016-08-12 13:29   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dee9bec25144 [^]
Maturity status: Test