Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033451Openbravo ERPY. DBSourceManagerpublic2016-07-07 19:042016-08-11 18:40
Reportermarvintm 
Assigned Tomarvintm 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q4 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033451: It would be nice to be able to check the API of external modules
DescriptionCurrently dbsourcemanager includes a task which allows to check the API of Openbravo. However, it's not currently possible to use this functionality to check the API of one or several modules.

It would be nice to be able to use the run.api.test.model ant task to check both the model and data part of the API of individual modules, or groups of modules whose API would need to be taken together into account.

This feature would be specially useful to check the API of Openbravo for Retail.
Steps To Reproduce.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff buildXmlissue33451.diff (873) 2016-07-11 10:05
https://issues.openbravo.com/file_download.php?file_id=9618&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-07-07 19:04marvintmNew Issue
2016-07-07 19:04marvintmAssigned To => marvintm
2016-07-07 19:04marvintmModules => Core
2016-07-07 19:04marvintmTriggers an Emergency Pack => No
2016-07-11 10:05marvintmFile Added: buildXmlissue33451.diff
2016-07-13 15:12hgbotCheckin
2016-07-13 15:12hgbotNote Added: 0088444
2016-07-13 15:12hgbotStatusnew => resolved
2016-07-13 15:12hgbotResolutionopen => fixed
2016-07-13 15:12hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/dbsm-main/rev/8df2a59ab358e6aa869f919bc6c07ead4ce8caa9 [^]
2016-07-13 15:12hgbotCheckin
2016-07-13 15:12hgbotNote Added: 0088445
2016-07-13 15:12hgbotCheckin
2016-07-13 15:12hgbotNote Added: 0088446
2016-07-13 15:12hgbotCheckin
2016-07-13 15:12hgbotNote Added: 0088447
2016-07-13 15:17hgbotCheckin
2016-07-13 15:17hgbotNote Added: 0088449
2016-07-13 15:17hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/dbsm-main/rev/8df2a59ab358e6aa869f919bc6c07ead4ce8caa9 [^] => http://code.openbravo.com/erp/devel/pi/rev/d564b3eccf23d128379d73b126f2f728965df180 [^]
2016-07-13 15:18marvintmReview Assigned To => alostale
2016-07-15 08:29alostaleNote Added: 0088510
2016-07-15 08:29alostaleStatusresolved => closed
2016-07-15 08:29alostaleFixed in Version => 3.0PR16Q4
2016-08-11 18:40hudsonbotCheckin
2016-08-11 18:40hudsonbotNote Added: 0089010

Notes
(0088444)
hgbot   
2016-07-13 15:12   
Repository: erp/devel/dbsm-main
Changeset: 8df2a59ab358e6aa869f919bc6c07ead4ce8caa9
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Jul 07 19:08:32 2016 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/8df2a59ab358e6aa869f919bc6c07ead4ce8caa9 [^]

Fixed issue 33451. Several changes have been done to allow the API check to work with modules:
- The CheckAPIDistribution class has been improved, and now it optionally accepts a 'modules' parameter.
- If this parameter is not set, it works as before. If it is set, then the API of the list of modules specified is checked instead, and only changes in those modules will be raised.
- For the structure part, the main change is that instead of just loading all model files and just merging them, after this is done, a final filtering by the modules filters is done to remove every object which is not part of the module.
- For the data part, the change consists in just loading only the data files of the modules instead of everything.
- The comparison itself hasn't changed, the only change is in the models/data which is being compared.
- Additionally, a small change has been done in DBSMOBUtil.loadDataStructures to allow specific modules to be loaded instead of all modules in the modules folder.

---
M src/org/openbravo/ddlutils/task/CheckAPIDistribution.java
M src/org/openbravo/ddlutils/util/DBSMOBUtil.java
---
(0088445)
hgbot   
2016-07-13 15:12   
Repository: erp/devel/dbsm-main
Changeset: 867345dd4b308e0ebe4ec91bcc2ee3fd019c9d40
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon Jul 11 10:02:42 2016 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/867345dd4b308e0ebe4ec91bcc2ee3fd019c9d40 [^]

Related ot issue 33451. StableDir will be used for stable structure model, to avoid problems. Still testDBdir will be used for stable in the data part, as there is no nice way to filter the AD data by module.

---
M src/org/openbravo/ddlutils/task/CheckAPIDistribution.java
---
(0088446)
hgbot   
2016-07-13 15:12   
Repository: erp/devel/dbsm-main
Changeset: 1c6135dc23043de63839dad1ec11640b7b57db3a
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon Jul 11 13:43:27 2016 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/1c6135dc23043de63839dad1ec11640b7b57db3a [^]

Related to issue 33451. Several improvements have been made:
- Simplified code in CheckAPIDistribution class. Now there is a single if statement, and code should be more readable.
- Added javadoc in two methods.
- Removed wrong reassignment of variable dbModelStable, which had been wrongly left over from previous change.
- Changed the name of the filter to clarify its purpose.

---
M src/org/openbravo/ddlutils/task/CheckAPIDistribution.java
---
(0088447)
hgbot   
2016-07-13 15:12   
Repository: erp/devel/dbsm-main
Changeset: 8590a0dc46070cb931a7b3daf2cb240ca9eb9ace
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Jul 13 15:08:33 2016 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/8590a0dc46070cb931a7b3daf2cb240ca9eb9ace [^]

Related to issue 33451. Moved variable to the if statement, as it's not needed out of it.

---
M src/org/openbravo/ddlutils/task/CheckAPIDistribution.java
---
(0088449)
hgbot   
2016-07-13 15:17   
Repository: erp/devel/pi
Changeset: d564b3eccf23d128379d73b126f2f728965df180
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Jul 13 15:17:14 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d564b3eccf23d128379d73b126f2f728965df180 [^]

Fixed issue 33451. Improved the run.api.test.model so that it can be used to check the API of individual modules or groups of modules

---
M build.xml
M src-db/database/lib/dbsourcemanager.jar
---
(0088510)
alostale   
2016-07-15 08:29   
code reviewed + tested
(0089010)
hudsonbot   
2016-08-11 18:40   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/edaa05b1fb18 [^]
Maturity status: Test