Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0033448Openbravo ERPA. Platformpublic2016-07-07 17:502016-08-11 18:40
AugustoMauch 
AugustoMauch 
normalminorhave not tried
closedfixed 
5
 
3.0PR16Q4 
alostale
Core
No
0033448: The DatasetServiceTest should check only the datasets defined in the OB3 distribution modules
Some of the tests of the DatasetServiceTest takes for granted that the where clause defined for dataset tables can be executed as is.

This is not the case for some datasets defined in a module outside the OB3 distribution. For instance one dataset table where clause in that module contains a placeholders that must be replaced with an actual value before executing it, see [1]:

Exception when creating query from ADFieldAccess where (ad_org_id in (@orgsInNaturalTree@))

[1] http://ci.openbravo.com/job/mod-simple/3439/testReport/junit/org.openbravo.test.modularity/DatasetServiceTest/testExportAllDataSets/ [^]
See [1]:

Exception when creating query from ADFieldAccess where (ad_org_id in (@orgsInNaturalTree@))

[1] http://ci.openbravo.com/job/mod-simple/3439/testReport/junit/org.openbravo.test.modularity/DatasetServiceTest/testExportAllDataSets/ [^]
No tags attached.
related to feature request 0033447 closed AugustoMauch Make accesible the list of modules included in the Openbravo 3 ditribution 
Issue History
2016-07-07 17:50AugustoMauchNew Issue
2016-07-07 17:50AugustoMauchAssigned To => AugustoMauch
2016-07-07 17:50AugustoMauchModules => Core
2016-07-07 17:50AugustoMauchTriggers an Emergency Pack => No
2016-07-07 17:50AugustoMauchRelationship addedrelated to 0033447
2016-07-07 17:59hgbotCheckin
2016-07-07 17:59hgbotNote Added: 0088302
2016-07-07 17:59hgbotCheckin
2016-07-07 17:59hgbotNote Added: 0088303
2016-07-07 17:59hgbotStatusnew => resolved
2016-07-07 17:59hgbotResolutionopen => fixed
2016-07-07 17:59hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ea00c7ca98c641603999d7ebcb65a4aa63428b17 [^]
2016-07-08 07:58alostaleReview Assigned To => alostale
2016-07-08 07:58alostaleNote Added: 0088311
2016-07-08 07:58alostaleStatusresolved => closed
2016-07-08 07:58alostaleFixed in Version => 3.0PR16Q4
2016-08-11 18:40hudsonbotCheckin
2016-08-11 18:40hudsonbotNote Added: 0088998
2016-08-11 18:40hudsonbotCheckin
2016-08-11 18:40hudsonbotNote Added: 0088999

Notes
(0088302)
hgbot   
2016-07-07 17:59   
Repository: erp/devel/pi
Changeset: 1a052960012e7607e9c6169db71c50b5f889bccd
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Jul 07 17:50:11 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1a052960012e7607e9c6169db71c50b5f889bccd [^]

Related with issue 33448: Removes commented out code

---
M src-test/src/org/openbravo/test/modularity/DatasetServiceTest.java
---
(0088303)
hgbot   
2016-07-07 17:59   
Repository: erp/devel/pi
Changeset: ea00c7ca98c641603999d7ebcb65a4aa63428b17
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Jul 07 17:56:26 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ea00c7ca98c641603999d7ebcb65a4aa63428b17 [^]

Fixes issue 33448: DatasetServiceTest checks only modules in OB3 distribution

The DatasetServiceTest class takes for granted that some rules applies to all datasets (i.e. that the dataset table where clause can be executed as is), but that cannot be met in some modules outside the OB3 distribution.

Now the test only checks the datasets defined in the modules included in the OB3 distribution.

---
M src-test/src/org/openbravo/test/modularity/DatasetServiceTest.java
---
(0088311)
alostale   
2016-07-08 07:58   
code reviewed + tested
(0088998)
hudsonbot   
2016-08-11 18:40   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/edaa05b1fb18 [^]
Maturity status: Test
(0088999)
hudsonbot   
2016-08-11 18:40   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/edaa05b1fb18 [^]
Maturity status: Test