Openbravo Issue Tracking System - Openbravo ERP |
View Issue Details |
|
ID | Project | Category | View Status | Date Submitted | Last Update |
0033448 | Openbravo ERP | A. Platform | public | 2016-07-07 17:50 | 2016-08-11 18:40 |
|
Reporter | AugustoMauch | |
Assigned To | AugustoMauch | |
Priority | normal | Severity | minor | Reproducibility | have not tried |
Status | closed | Resolution | fixed | |
Platform | | OS | 5 | OS Version | |
Product Version | | |
Target Version | | Fixed in Version | 3.0PR16Q4 | |
Merge Request Status | |
Review Assigned To | alostale |
OBNetwork customer | No |
Web browser | |
Modules | Core |
Support ticket | |
Regression level | |
Regression date | |
Regression introduced in release | |
Regression introduced by commit | |
Triggers an Emergency Pack | No |
|
Summary | 0033448: The DatasetServiceTest should check only the datasets defined in the OB3 distribution modules |
Description | Some of the tests of the DatasetServiceTest takes for granted that the where clause defined for dataset tables can be executed as is.
This is not the case for some datasets defined in a module outside the OB3 distribution. For instance one dataset table where clause in that module contains a placeholders that must be replaced with an actual value before executing it, see [1]:
Exception when creating query from ADFieldAccess where (ad_org_id in (@orgsInNaturalTree@))
[1] http://ci.openbravo.com/job/mod-simple/3439/testReport/junit/org.openbravo.test.modularity/DatasetServiceTest/testExportAllDataSets/ [^] |
Steps To Reproduce | See [1]:
Exception when creating query from ADFieldAccess where (ad_org_id in (@orgsInNaturalTree@))
[1] http://ci.openbravo.com/job/mod-simple/3439/testReport/junit/org.openbravo.test.modularity/DatasetServiceTest/testExportAllDataSets/ [^] |
Proposed Solution | |
Additional Information | |
Tags | No tags attached. |
Relationships | related to | feature request | 0033447 | | closed | AugustoMauch | Make accesible the list of modules included in the Openbravo 3 ditribution |
|
Attached Files | |
|
Issue History |
Date Modified | Username | Field | Change |
2016-07-07 17:50 | AugustoMauch | New Issue | |
2016-07-07 17:50 | AugustoMauch | Assigned To | => AugustoMauch |
2016-07-07 17:50 | AugustoMauch | OBNetwork customer | => No |
2016-07-07 17:50 | AugustoMauch | Modules | => Core |
2016-07-07 17:50 | AugustoMauch | Triggers an Emergency Pack | => No |
2016-07-07 17:50 | AugustoMauch | Relationship added | related to 0033447 |
2016-07-07 17:59 | hgbot | Checkin | |
2016-07-07 17:59 | hgbot | Note Added: 0088302 | |
2016-07-07 17:59 | hgbot | Checkin | |
2016-07-07 17:59 | hgbot | Note Added: 0088303 | |
2016-07-07 17:59 | hgbot | Status | new => resolved |
2016-07-07 17:59 | hgbot | Resolution | open => fixed |
2016-07-07 17:59 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/ea00c7ca98c641603999d7ebcb65a4aa63428b17 [^] |
2016-07-08 07:58 | alostale | Review Assigned To | => alostale |
2016-07-08 07:58 | alostale | Note Added: 0088311 | |
2016-07-08 07:58 | alostale | Status | resolved => closed |
2016-07-08 07:58 | alostale | Fixed in Version | => 3.0PR16Q4 |
2016-08-11 18:40 | hudsonbot | Checkin | |
2016-08-11 18:40 | hudsonbot | Note Added: 0088998 | |
2016-08-11 18:40 | hudsonbot | Checkin | |
2016-08-11 18:40 | hudsonbot | Note Added: 0088999 | |
Notes |
|
(0088302)
|
hgbot
|
2016-07-07 17:59
|
|
|
|
(0088303)
|
hgbot
|
2016-07-07 17:59
|
|
Repository: erp/devel/pi
Changeset: ea00c7ca98c641603999d7ebcb65a4aa63428b17
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Jul 07 17:56:26 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ea00c7ca98c641603999d7ebcb65a4aa63428b17 [^]
Fixes issue 33448: DatasetServiceTest checks only modules in OB3 distribution
The DatasetServiceTest class takes for granted that some rules applies to all datasets (i.e. that the dataset table where clause can be executed as is), but that cannot be met in some modules outside the OB3 distribution.
Now the test only checks the datasets defined in the modules included in the OB3 distribution.
---
M src-test/src/org/openbravo/test/modularity/DatasetServiceTest.java
---
|
|
|
|
|
|
|
|
|
|
|