Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033439Retail ModulesWeb POSpublic2016-07-06 10:112016-07-15 22:01
Reporterpaul_guiot 
Assigned Tomario_castello 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033439: [SERQA 1421] Error: Adding a service in a quotation “under Evaluation”
DescriptionAdding a service to a quotation under evaluation, we have the following error:
We have the following error:
a79b415…_WebPOS.js:2761 TypeError: Cannot read property 'slice' of undefined at https://livebuilds.openbravo.com/retail_pi_pgsql/web/js/gen/a79b415d6f48f3e6adf110c414e9cfbe_WebPOS.js:44493:72 [^] at Array.forEach (native) at Function.b.each.b.forEach (https://livebuilds.openbravo.com/retail_pi_pgsql/web/org.openbravo.mobile.core/lib/vendor/underscore-1.3.3.min.js:11:39 [^] at Object.<anonymous> (https://livebuilds.openbravo.com/retail_pi_pgsql/web/js/gen/a79b415d6f48f3e6adf110c414e9cfbe_WebPOS.js:44483:15 [^])at canAddAsServices (https://livebuilds.openbravo.com/retail_pi_pgsql/web/js/gen/a79b415d6f48f3e6adf110c414e9cfbe_WebPOS.js:25539:22 [^])at Object.addProductToOrder (https://livebuilds.openbravo.com/retail_pi_pgsql/web/js/gen/a79b415d6f48f3e6adf110c414e9cfbe_WebPOS.js:44471:19 [^]) at Object.dispatch (https://livebuilds.openbravo.com/retail_pi_pgsql/web/org.openbravo.mobile.core/build/enyo.js:628:17 [^] at Object.dispatchEvent (https://livebuilds.openbravo.com/retail_pi_pgsql/web/org.openbravo.mobile.core/build/enyo.js:612:30 [^])at Object.enyo.kind.inherited (https://livebuilds.openbravo.com/retail_pi_pgsql/web/org.openbravo.mobile.core/build/enyo.js:410:28 [^])at Object.dispatchEvent (https://livebuilds.openbravo.com/retail_pi_pgsql/web/org.openbravo.mobile.core/build/enyo.js:1338:78 [^]); line: Object.OB.UTIL.showError (https://livebuilds.openbravo.com/retail_pi_pgsql/web/js/gen/a79b415d6f48f3e6adf110c414e9cfbe_WebPOS.js:10957:6 [^]) (*,+)
Steps To ReproduceSteps to reproduce:
* Backend: https://livebuilds.openbravo.com/retail_pi_pgsql/security/Login_FS.html [^]
User: Openbravo

*Webpos: https://livebuilds.openbravo.com/retail_pi_pgsql/web/org.openbravo.retail.posterminal/?terminal=VBS-1#login [^]
User: Vallblanca

- In the backend, go to product and select the service: Customize Blue Trousers
- Flag the field “Allow Deferred Sell” and save
- In the webpos, with the user VallBlanca, go to the menu: Create quotation
- Add the product: Blue Troussers
- Click on the amount: The quotation is “under Evaluation”
- Click on the icon “service” to add one
- Add the service “Customize Blue Trousers”
An error is rising

See video enclosed
Proposed SolutionWe should not be able to modify a Quotation “under evaluation”.

Solution: The icon “Add service” should not be accessible for a quotation under evaluation
Additional Information
TagsNo tags attached.
Relationships
Attached Files? 1421.mp4 (3,577,452) 2016-07-06 10:11
https://issues.openbravo.com/file_download.php?file_id=9613&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-07-06 10:11paul_guiotNew Issue
2016-07-06 10:11paul_guiotAssigned To => Retail
2016-07-06 10:11paul_guiotFile Added: 1421.mp4
2016-07-06 10:11paul_guiotOBNetwork customer => Yes
2016-07-06 10:11paul_guiotResolution time => 1469052000
2016-07-06 10:11paul_guiotTriggers an Emergency Pack => No
2016-07-07 09:06marvintmStatusnew => acknowledged
2016-07-07 15:59mario_castelloAssigned ToRetail => mario_castello
2016-07-07 19:22mario_castelloStatusacknowledged => scheduled
2016-07-08 17:28hgbotCheckin
2016-07-08 17:28hgbotNote Added: 0088342
2016-07-08 17:28hgbotStatusscheduled => resolved
2016-07-08 17:28hgbotResolutionopen => fixed
2016-07-08 17:28hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e637f845f1c619eb44d041876220fb49029a2af6 [^]
2016-07-11 10:49marvintmNote Added: 0088360
2016-07-11 10:49marvintmStatusresolved => new
2016-07-11 10:49marvintmResolutionfixed => open
2016-07-11 10:49marvintmStatusnew => scheduled
2016-07-12 23:13hgbotCheckin
2016-07-12 23:13hgbotNote Added: 0088424
2016-07-12 23:13hgbotStatusscheduled => resolved
2016-07-12 23:13hgbotResolutionopen => fixed
2016-07-12 23:13hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e637f845f1c619eb44d041876220fb49029a2af6 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/dbedc768922d9e8c5439478fe033482530f15790 [^]
2016-07-12 23:19hgbotCheckin
2016-07-12 23:19hgbotNote Added: 0088425
2016-07-14 09:00marvintmReview Assigned To => marvintm
2016-07-14 09:00marvintmStatusresolved => closed
2016-07-15 22:01hgbotCheckin
2016-07-15 22:01hgbotNote Added: 0088547

Notes
(0088342)
hgbot   
2016-07-08 17:28   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e637f845f1c619eb44d041876220fb49029a2af6
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Fri Jul 08 09:04:39 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e637f845f1c619eb44d041876220fb49029a2af6 [^]

Fixed issue 33439: Added validation for promotion in orderline before execute the slice function.
Sometimes the line has not promotions property.

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
---
(0088360)
marvintm   
2016-07-11 10:49   
The solution is not the correct one. The main problem here is that the user is able to click on the "Add service" icon even if the quotation is under evaluation, and this is not correct, as quotations under evaluation should not be editable.

So we should change the "Add service" button so that the user cannot use it when the quotation is under evaluation.
(0088424)
hgbot   
2016-07-12 23:13   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: dbedc768922d9e8c5439478fe033482530f15790
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Mon Jul 11 09:04:16 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/dbedc768922d9e8c5439478fe033482530f15790 [^]

Fixed issue 33439: Added new validation to prevent add services when the receipt is a quotation under evaluation

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0088425)
hgbot   
2016-07-12 23:19   
Repository: tools/automation/pi-mobile
Changeset: e27fc01ac2c77aa1d1aba84c7141019b5c1a471c
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Tue Jul 12 09:18:34 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/e27fc01ac2c77aa1d1aba84c7141019b5c1a471c [^]

Related to issue 33439: Fixed test RejectQuotations

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/RejectQuotations.java
---
(0088547)
hgbot   
2016-07-15 22:01   
Repository: tools/automation/pi-mobile
Changeset: 0bf3cc8ff11c841da7287b447cc0c0196040b35b
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Fri Jul 15 14:01:00 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/0bf3cc8ff11c841da7287b447cc0c0196040b35b [^]

Verifies issue 33439: Added automated test

---
A src-test/org/openbravo/test/mobile/quarantine/pack/MCA/sales/I33439_QuotationAddServicesUnderEvaluation.java
---