Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0033397Openbravo ERP04. Warehouse managementpublic2016-06-30 17:172017-09-21 16:49
vmromanos 
markmm82 
normalmajoralways
closedfixed 
5
 
3.0PR17Q4 
aferraz
Core
No
0033397: Reactivate a reservation doesn't work in Oracle when the reservation is not linked to an order
Oracle only!

When you try to reactivate a reservation that is not linked to an order, the process fails with the error message:

ORA-01403: no data found
Go to preference window. Create a new record:
  Property: Enable Stock Reservations
  Value: Y

Log out and log in

Go to Stock Reservation window. Create a new record. Select any product and quantity. Process the reservation.

Now press "Put on hold" button and select "Reactivate" action. The error is raised
Attached a proposed solution (not properly tested).

The procedure is always expecting an order linked to the reservation, and this is not always true.
No tags attached.
diff 33397_proposed.diff (1,670) 2016-06-30 17:18
https://issues.openbravo.com/file_download.php?file_id=9602&type=bug
Issue History
2016-06-30 17:17vmromanosNew Issue
2016-06-30 17:17vmromanosAssigned To => Triage Finance
2016-06-30 17:17vmromanosModules => Core
2016-06-30 17:17vmromanosTriggers an Emergency Pack => No
2016-06-30 17:18vmromanosFile Added: 33397_proposed.diff
2017-08-15 20:04markmm82Assigned ToTriage Finance => markmm82
2017-08-15 20:04markmm82Statusnew => scheduled
2017-08-15 21:32markmm82Note Added: 0098512
2017-08-25 08:52hgbotCheckin
2017-08-25 08:52hgbotNote Added: 0098640
2017-08-25 08:52hgbotStatusscheduled => resolved
2017-08-25 08:52hgbotResolutionopen => fixed
2017-08-25 08:52hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/3e0bc2ad77c6eb288dd7d22bede0402d9fe17103 [^]
2017-08-25 08:58aferrazReview Assigned To => aferraz
2017-08-25 08:58aferrazNote Added: 0098643
2017-08-25 08:58aferrazStatusresolved => closed
2017-08-25 08:58aferrazFixed in Version => 3.0PR17Q4
2017-09-21 16:49hudsonbotCheckin
2017-09-21 16:49hudsonbotNote Added: 0099327

Notes
(0098512)
markmm82   
2017-08-15 21:32   
Test Plan:
Go to preference window. Create a new record:
  Property: Enable Stock Reservations
  Value: Y

Log out and log in

Go to Stock Reservation window. Create a new record. Select any product and quantity. Process the reservation.

Now press "Put on hold" button and select "Reactivate" action. The process is successfull.
(0098640)
hgbot   
2017-08-25 08:52   
Repository: erp/devel/pi
Changeset: 3e0bc2ad77c6eb288dd7d22bede0402d9fe17103
Author: Mark <markmm82 <at> gmail.com>
Date: Tue Aug 15 15:00:49 2017 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/3e0bc2ad77c6eb288dd7d22bede0402d9fe17103 [^]

Fixes issue 33397: Reactivate a reservation doesn't work in Oracle

When you try to reactivate a reservation that is not linked to an order, the process
fails with the error message. Problem is that procedure is always expecting an order
linked to the reservation, and this doesn't happen always.

---
M src-db/database/model/functions/M_RESERVATION_POST.xml
---
(0098643)
aferraz   
2017-08-25 08:58   
Code review + Testing OK
(0099327)
hudsonbot   
2017-09-21 16:49   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9750b78d3e5c [^]
Maturity status: Test