Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033391Openbravo ERP04. Warehouse managementpublic2016-06-30 13:452016-09-16 13:44
ReporterVictorVillar 
Assigned Todmiguelez 
PriorityimmediateSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0PR16Q4Fixed in Version3.0PR16Q4 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket42684
Regression levelPackaging and release
Regression date2016-04-20
Regression introduced in release3.0PR16Q3
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/5406f70dad91 [^]
Triggers an Emergency PackNo
Summary0033391: Not possible to launch the costing background process because manual costing registers
DescriptionNot possible to launch the costing background process because manual costing registers
Steps To ReproduceNot possible to launch the costing background process because manual costing registers

it seems that this statement costing.getInventoryTransaction().XXX fails.

Example:

1) line 407 CostingUtils.java

2) different lines in CostAdjustmentUtils.java

if (costing != null
        && costing.getTotalMovementQuantity() != null
        && (!costingRule.isBackdatedTransactionsFixed() || trx.getMovementDate().after(
            costing.getInventoryTransaction().getMovementDate()))) {

Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00334073.0PR16Q3 closed dmiguelez Not possible to launch the costing background process because manual costing registers 
caused by defect 00325043.0PR16Q3 closed aferraz Huge performance problem in the costing background process and using the Negative stock correction too 
related to defect 00339683.0PR17Q1 closed dmiguelez Wrong costs calculated with Backdated Transactions 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-06-30 13:45VictorVillarNew Issue
2016-06-30 13:45VictorVillarAssigned To => aferraz
2016-06-30 13:45VictorVillarOBNetwork customer => Yes
2016-06-30 13:45VictorVillarModules => Core
2016-06-30 13:45VictorVillarTriggers an Emergency Pack => No
2016-06-30 13:51VictorVillarResolution time => 1467842400
2016-06-30 13:52VictorVillarAssigned Toaferraz => Triage Finance
2016-06-30 13:59VictorVillarSeveritymajor => critical
2016-06-30 14:06aferrazAssigned ToTriage Finance => dmiguelez
2016-07-01 12:01aferrazStatusnew => scheduled
2016-07-01 14:24hgbotCheckin
2016-07-01 14:24hgbotNote Added: 0088154
2016-07-01 14:24hgbotStatusscheduled => resolved
2016-07-01 14:24hgbotResolutionopen => fixed
2016-07-01 14:24hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ffedbefe6e2f2ea7fdd2c82bb9b1fc889b04281f [^]
2016-07-01 14:28VictorVillarSupport ticket => 42684
2016-07-01 14:29ngarciaIssue Monitored: networkb
2016-07-01 14:30aferrazReview Assigned To => aferraz
2016-07-01 14:30aferrazNote Added: 0088156
2016-07-01 14:30aferrazStatusresolved => closed
2016-07-01 14:30aferrazFixed in Version => 3.0PR16Q4
2016-08-11 18:40hudsonbotCheckin
2016-08-11 18:40hudsonbotNote Added: 0088983
2016-08-20 11:43aferrazRelationship addedcaused by 0032504
2016-08-20 11:45aferrazRegression level => Packaging and release
2016-08-20 11:45aferrazRegression date => 2016-04-20
2016-08-20 11:45aferrazRegression introduced in release => 3.0PR16Q3
2016-08-20 11:45aferrazRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/5406f70dad91 [^]
2016-09-16 13:38aferrazRelationship addedrelated to 0033411
2016-09-16 13:40aferrazRelationship deletedrelated to 0033411
2016-09-16 13:41aferrazRelationship addedrelated to 0033968
2016-09-16 13:44aferrazTarget Version => 3.0PR16Q4

Notes
(0088154)
hgbot   
2016-07-01 14:24   
Repository: erp/devel/pi
Changeset: ffedbefe6e2f2ea7fdd2c82bb9b1fc889b04281f
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Fri Jul 01 09:51:44 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ffedbefe6e2f2ea7fdd2c82bb9b1fc889b04281f [^]

Fixes issue 33391: Error in Costing Background due to manual costing records

Do not take into account manually inserted Costing Entries when calculating the current Stock or the current valued Stock.
Also, centralize conditions into one boolean variable.

---
M src/org/openbravo/costing/CostAdjustmentUtils.java
M src/org/openbravo/costing/CostingUtils.java
---
(0088156)
aferraz   
2016-07-01 14:30   
Code review + Testing OK
(0088983)
hudsonbot   
2016-08-11 18:40   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/edaa05b1fb18 [^]
Maturity status: Test