Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033364Retail ModulesWeb POSpublic2016-06-27 12:352016-07-11 09:21
Reporteraaroncalero 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033364: [SERQA 1297] Returning services using verified returns is not working fine
DescriptionWhen using the verified returns option to return a ticket with services, an approval is requested if the overdue return days have passed. If the user doesn't have permissions for that action, a supervisor must approve it. After approving this action, the approval to return the service is asked.
However, the permission verified internally for both actions is the same (OBPOS_approval.returnService).
Steps To ReproduceLogin in the ERP, go to the Product window, open the Warranty (deferrable -4 days) record and define the Overdue Return Days to 0.
Configure the following preferences:
*Web POS Service Return Approval, value: Y, user Openbravo
*Web POS Service Return Approval, value: N, user vallblanca
Login in Web POS and create a ticket with the following products:
*GPS Mini
*Warranty (deferrable -4 days)
Complete the ticket.
Change the dateOrdered field of the order in database (or wait 1 day for the next step).
In webpos, using the menu > Verified returns, load the previous ticket.
Approval to return a service with overdue days will be requested.
After approving the action, another approval will be requested.
Proposed SolutionAdd a new preference to allow/deny returning services once the overdue days have passed.
Modify the logic to request approval for both actions (returning a service and returning with overdue days) if needed.
If the approval is granted, add a flag to the product so the approval is not requested again.

*Attached diffs with the proposed solution
Additional Information
TagsSER-QA
Relationships
depends on defect 0032929 new Retail Wrong approval message when returning services using verified returns 
Not all the children of this issue are yet resolved or closed.
Attached Filesdiff Issue33364_posterminal.diff (715) 2016-06-27 12:54
https://issues.openbravo.com/file_download.php?file_id=9585&type=bug
diff Issue33364_returns.diff (10,481) 2016-06-27 12:54
https://issues.openbravo.com/file_download.php?file_id=9586&type=bug
diff Issue33364_pimobile.diff (3,218) 2016-06-27 12:55
https://issues.openbravo.com/file_download.php?file_id=9587&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-06-27 12:35aaroncaleroNew Issue
2016-06-27 12:35aaroncaleroAssigned To => Retail
2016-06-27 12:35aaroncaleroOBNetwork customer => No
2016-06-27 12:35aaroncaleroTriggers an Emergency Pack => No
2016-06-27 12:49aaroncaleroRelationship addeddepends on 0032929
2016-06-27 12:54aaroncaleroFile Added: Issue33364_posterminal.diff
2016-06-27 12:54aaroncaleroFile Added: Issue33364_returns.diff
2016-06-27 12:55aaroncaleroFile Added: Issue33364_pimobile.diff
2016-06-27 13:02aaroncaleroTag Attached: SER-QA
2016-06-27 13:02aaroncaleroOBNetwork customerNo => Yes
2016-06-27 13:02aaroncaleroResolution time => 1468188000
2016-06-30 10:26marvintmStatusnew => acknowledged
2016-06-30 16:00ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2016-06-30 16:00ranjith_qualiantech_comStatusacknowledged => scheduled
2016-07-04 03:43hgbotCheckin
2016-07-04 03:43hgbotNote Added: 0088164
2016-07-04 03:43hgbotCheckin
2016-07-04 03:43hgbotNote Added: 0088165
2016-07-04 03:45hgbotCheckin
2016-07-04 03:45hgbotNote Added: 0088166
2016-07-04 03:45hgbotStatusscheduled => resolved
2016-07-04 03:45hgbotResolutionopen => fixed
2016-07-04 03:45hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/e7df60f3a90ed2d64d64e3ed44ca5b0c53280e10 [^]
2016-07-11 09:21marvintmReview Assigned To => marvintm
2016-07-11 09:21marvintmStatusresolved => closed

Notes
(0088164)
hgbot   
2016-07-04 03:43   
Repository: tools/automation/pi-mobile
Changeset: 2269f133de5b417ddaf64b69c136b4b4e52865a3
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Sun Jul 03 10:21:39 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/2269f133de5b417ddaf64b69c136b4b4e52865a3 [^]

Verifies issue 33364 : Added automated test 'I33364_VerifyReturnOnSeviceOverdue'

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/services/ReturnServiceOverdueDays.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/I33364_VerifyReturnOnSeviceOverdue.java
---
(0088165)
hgbot   
2016-07-04 03:43   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c77c67c9a83c4f906fee89f9d15b7ffcadd6b071
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jul 04 07:12:00 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c77c67c9a83c4f906fee89f9d15b7ffcadd6b071 [^]

Related to issue 33364 : Added validation to ignore multiple approval for product if it is approved already

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0088166)
hgbot   
2016-07-04 03:45   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: e7df60f3a90ed2d64d64e3ed44ca5b0c53280e10
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Sun Jul 03 10:15:46 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/e7df60f3a90ed2d64d64e3ed44ca5b0c53280e10 [^]

Fixes issue 33364 : Added validation to ignore multiple approval for product if it is approved already

- Added New Preference for "Overdue Service for Approval"

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_PREFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---