Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0033355Openbravo ERPC. Securitypublic2016-06-24 13:412016-08-11 18:40
AugustoMauch 
caristu 
normalmajorhave not tried
closedfixed 
5
 
3.0PR16Q43.0PR16Q4 
alostale
Core
No
0033355: Potential security issue in Process Definitions
In a process definition, it is possible to update a record that belongs to a client other than the current one, even if the OBContext is not in Administrator Mode.
- Apply the patch that will be attached to the issue. This patch adds a Process Definition to the Client window, where the System client is shown in all clients. The process definition updates the selected record.
- Log in with a client other than System
- Open the Client window
- Select the System client and press the new button. Check that the client has been modified, even though it shouldn't have been allowed.
No tags attached.
related to defect 0033166 closed alostale Openbravo ERP Role with access to one organization can edit all of them in Organization window 
related to feature request 0033239RR16Q3 closed Sandrahuguet Retail Modules Provide a proces to recreate the mobile server authentication key 
diff issueProcessDefinition.diff (24,357) 2016-06-27 09:51
https://issues.openbravo.com/file_download.php?file_id=9579&type=bug
diff issue33355.diff (742) 2016-06-27 09:51
https://issues.openbravo.com/file_download.php?file_id=9580&type=bug
Issue History
2016-06-24 13:41AugustoMauchNew Issue
2016-06-24 13:41AugustoMauchAssigned To => platform
2016-06-24 13:41AugustoMauchModules => Core
2016-06-24 13:41AugustoMauchTriggers an Emergency Pack => No
2016-06-24 13:43caristuAssigned Toplatform => caristu
2016-06-24 13:43caristuStatusnew => acknowledged
2016-06-27 09:25caristuRelationship addedrelated to 0033166
2016-06-27 09:25caristuStatusacknowledged => scheduled
2016-06-27 09:25caristuTarget Version => 3.0PR16Q4
2016-06-27 09:48caristuFile Added: issue33355.diff
2016-06-27 09:51caristuFile Deleted: issue33355.diff
2016-06-27 09:51caristuFile Added: issueProcessDefinition.diff
2016-06-27 09:51caristuFile Added: issue33355.diff
2016-06-27 10:08SandrahuguetRelationship addedrelated to 0033239
2016-07-18 13:16hgbotCheckin
2016-07-18 13:16hgbotNote Added: 0088551
2016-07-18 13:16hgbotStatusscheduled => resolved
2016-07-18 13:16hgbotResolutionopen => fixed
2016-07-18 13:16hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5a3558090511f4d767ae11c5a3aee2c74708e9f9 [^]
2016-07-18 13:16caristuReview Assigned To => alostale
2016-07-18 13:16caristuIssue Monitored: alostale
2016-07-22 10:41alostaleNote Added: 0088625
2016-07-22 10:41alostaleStatusresolved => closed
2016-07-22 10:41alostaleFixed in Version => 3.0PR16Q4
2016-08-11 18:40hudsonbotCheckin
2016-08-11 18:40hudsonbotNote Added: 0089018

Notes
(0088551)
hgbot   
2016-07-18 13:16   
Repository: erp/devel/pi
Changeset: 5a3558090511f4d767ae11c5a3aee2c74708e9f9
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Jul 18 13:15:07 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5a3558090511f4d767ae11c5a3aee2c74708e9f9 [^]

fixes issue 33355: Potential security issue in Process Definitions
The problem was that in SecurityChecker the checking for write access was not considering that the object being written could be an instance of Client (This class is the only DAL generated class which does not implement the ClientEnabled interface).

---
M src/org/openbravo/dal/security/SecurityChecker.java
---
(0088625)
alostale   
2016-07-22 10:41   
code reviewed + tested
(0089018)
hudsonbot   
2016-08-11 18:40   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/edaa05b1fb18 [^]
Maturity status: Test