Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033321Openbravo ERPA. Platformpublic2016-06-21 12:492016-06-24 14:30
Reportercaristu 
Assigned Tocaristu 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q3 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033321: Implement isSameTab function for Process Definition based windows
DescriptionImplement isSameTab function for Process Definition based windows.

When opening a view Openbravo will check if the view class/instance supports certain methods[1].

One of these methods is isSameTab which is used view the view manager to decide if a view may only be opened once.

Currently the process definition view does not implement this method allowing the same process definition be opened multiple times. But in order to remark that this is the expected behavior the isSameTab method should be implemented by returning always false.


[1] http://wiki.openbravo.com/wiki/How_to_implement_a_new_main_view#View_API [^]

Steps To ReproduceIn description.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0033097 closed caristu [SERQA 1166] Names of Windows implementing Process Definitions appear as UUIDs after a refresh 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-06-21 12:49caristuNew Issue
2016-06-21 12:49caristuAssigned To => caristu
2016-06-21 12:49caristuOBNetwork customer => No
2016-06-21 12:49caristuModules => Core
2016-06-21 12:49caristuTriggers an Emergency Pack => No
2016-06-21 12:49caristuDescription Updatedbug_revision_view_page.php?rev_id=12440#r12440
2016-06-21 13:02hgbotCheckin
2016-06-21 13:02hgbotNote Added: 0087723
2016-06-21 13:02hgbotStatusnew => resolved
2016-06-21 13:02hgbotResolutionopen => fixed
2016-06-21 13:02hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2485d61000fa554124dca3bdf7d683b74856a08e [^]
2016-06-21 13:02caristuReview Assigned To => AugustoMauch
2016-06-21 13:02caristuRelationship addedrelated to 0033097
2016-06-22 18:10hudsonbotCheckin
2016-06-22 18:10hudsonbotNote Added: 0087830
2016-06-24 14:30AugustoMauchNote Added: 0087906
2016-06-24 14:30AugustoMauchStatusresolved => closed
2016-06-24 14:30AugustoMauchFixed in Version => 3.0PR16Q3

Notes
(0087723)
hgbot   
2016-06-21 13:02   
Repository: erp/devel/pi
Changeset: 2485d61000fa554124dca3bdf7d683b74856a08e
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Tue Jun 21 12:58:19 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2485d61000fa554124dca3bdf7d683b74856a08e [^]

fixes issue 33321: Implement isSameTab for Process Definition based windows

Process definition based windows can be opened in more than one tab at the same time. This allows, for example, to see the parameters used to run the process in case the process window is reopened after the execution.

This is the current behavior of such windows. We are just implementing the isSameTab method to remark this behavior.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-base-parameter-window-view.js
---
(0087830)
hudsonbot   
2016-06-22 18:10   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/468afe624cc8 [^]
Maturity status: Test
(0087906)
AugustoMauch   
2016-06-24 14:30   
Code reviewed and verified in pi@7341d1f97b97