Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033308Retail ModulesDiscounts and Promotionspublic2016-06-20 10:092016-06-30 13:12
Reporterebecerra 
Assigned Tojorge-garcia 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033308: Promotion: Incorrect configuration for: Buy X pay Y of same product
DescriptionThe information of the promotion applied is not correct.
Steps To ReproduceGo to WebPOS
 1) Add 6 units of Harness four-season.
 2) Check a promotion of 6 x 5 Harness has been applied
 3) Open Chrome Developers Tools
 4) In the console, write this sentence: OB.MobileApp.model.receipt.get('lines').models[0].get('promotions')
 5) At least the field obdiscQtyoffer is wrong (it's 6 ans it should be 1).
Proposed SolutionChange the BuyXPayY of same products rule to have the correct information.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-06-20 10:09ebecerraNew Issue
2016-06-20 10:09ebecerraAssigned To => Retail
2016-06-20 10:09ebecerraOBNetwork customer => No
2016-06-20 10:09ebecerraTriggers an Emergency Pack => No
2016-06-20 10:24jorge-garciaDescription Updatedbug_revision_view_page.php?rev_id=12425#r12425
2016-06-20 10:24jorge-garciaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=12427#r12427
2016-06-20 10:24jorge-garciaProposed Solution updated
2016-06-21 08:44jorge-garciaStatusnew => acknowledged
2016-06-21 08:44jorge-garciaStatusacknowledged => scheduled
2016-06-21 08:44jorge-garciaAssigned ToRetail => jorge-garcia
2016-06-23 10:44hgbotCheckin
2016-06-23 10:44hgbotNote Added: 0087843
2016-06-23 10:44hgbotStatusscheduled => resolved
2016-06-23 10:44hgbotResolutionopen => fixed
2016-06-23 10:44hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/9e734195a7dabab94765731c657487a72e305643 [^]
2016-06-28 11:39marvintmNote Added: 0088021
2016-06-28 11:39marvintmStatusresolved => new
2016-06-28 11:39marvintmResolutionfixed => open
2016-06-28 11:39marvintmStatusnew => scheduled
2016-06-30 12:47hgbotCheckin
2016-06-30 12:47hgbotNote Added: 0088095
2016-06-30 12:47hgbotStatusscheduled => resolved
2016-06-30 12:47hgbotResolutionopen => fixed
2016-06-30 12:47hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/9e734195a7dabab94765731c657487a72e305643 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/e77eb89d39b334140dc265cfe580903e9efa1dfc [^]
2016-06-30 12:47hgbotCheckin
2016-06-30 12:47hgbotNote Added: 0088096
2016-06-30 13:12marvintmReview Assigned To => marvintm
2016-06-30 13:12marvintmStatusresolved => closed

Notes
(0087843)
hgbot   
2016-06-23 10:44   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 9e734195a7dabab94765731c657487a72e305643
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Jun 22 17:06:58 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/9e734195a7dabab94765731c657487a72e305643 [^]

Fixed issue 33308: Promotion: Incorrect configuration for:
Buy X pay Y of same product

Added the right promotion values.

---
M web/org.openbravo.retail.discounts/js/promotion-XYsameProduct.js
---
(0088021)
marvintm   
2016-06-28 11:39   
There is an issue with the current implementation, when more than one instance of the discount can be applied.
(0088095)
hgbot   
2016-06-30 12:47   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: e77eb89d39b334140dc265cfe580903e9efa1dfc
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Jun 29 09:25:07 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/e77eb89d39b334140dc265cfe580903e9efa1dfc [^]

Fixed issue 33308: Promotion: Incorrect configuration for:
Buy X pay Y of same product

Adapted promotion-XYsameProduct rule to work the same way
promotion-XYdiffrenetProduct rule works.

---
M web/org.openbravo.retail.discounts/js/promotion-XYsameProduct.js
---
(0088096)
hgbot   
2016-06-30 12:47   
Repository: tools/automation/pi-mobile
Changeset: 1ac2fe5e0e0accb4b94a804c3a55714179ce4113
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Jun 30 09:28:12 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/1ac2fe5e0e0accb4b94a804c3a55714179ce4113 [^]

Related to issue 33308: Promotion: Incorrect configuration for:
Buy X pay Y of same product

Change test line verification due to the new behaviour of the
promotion-XYsampeproduct rule

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/Communit6781_BuyXPayYSameProduct.java
---