Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0033298Openbravo ERP07. Sales managementpublic2016-06-16 20:442016-06-28 16:06
mtaal 
Sandrahuguet 
normalminoralways
closedfixed 
5
 
3.0PR16Q43.0PR16Q3 
aferraz
Core
No
0033298: c_orderdiscount_trg trigger does not have enabling/disabling code
All triggers in OB need to have enabling and disabling code snippet in the beginning:

    IF AD_isTriggerEnabled()='N' THEN IF TG_OP = 'DELETE' THEN RETURN OLD; ELSE RETURN NEW; END IF;
    END IF;

The c_orderdiscount_trg misses this.
Check the trigger code in postgresql explorer
Add the line as shown above.
No tags attached.
diff trigger.diff (453) 2016-06-16 22:28
https://issues.openbravo.com/file_download.php?file_id=9547&type=bug
Issue History
2016-06-16 20:44mtaalNew Issue
2016-06-16 20:44mtaalAssigned To => Triage Finance
2016-06-16 20:44mtaalModules => Core
2016-06-16 20:44mtaalTriggers an Emergency Pack => No
2016-06-16 22:28mtaalFile Added: trigger.diff
2016-06-24 12:10mtaalAssigned ToTriage Finance => Sandrahuguet
2016-06-27 08:59hgbotCheckin
2016-06-27 08:59hgbotNote Added: 0087939
2016-06-27 08:59hgbotStatusnew => resolved
2016-06-27 08:59hgbotResolutionopen => fixed
2016-06-27 08:59hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c01922c14219237f6b04696df536de09ce9af86a [^]
2016-06-27 08:59SandrahuguetReview Assigned To => aferraz
2016-06-27 09:43hgbotCheckin
2016-06-27 09:43hgbotNote Added: 0087941
2016-06-27 09:45aferrazNote Added: 0087942
2016-06-27 09:45aferrazStatusresolved => closed
2016-06-27 09:45aferrazFixed in Version => 3.0PR16Q3
2016-06-27 13:49hudsonbotCheckin
2016-06-27 13:49hudsonbotNote Added: 0087988
2016-06-28 16:06hudsonbotCheckin
2016-06-28 16:06hudsonbotNote Added: 0088051

Notes
(0087939)
hgbot   
2016-06-27 08:59   
Repository: erp/devel/pi
Changeset: c01922c14219237f6b04696df536de09ce9af86a
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Thu Jun 23 10:28:40 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c01922c14219237f6b04696df536de09ce9af86a [^]

Fixed issue 33298 enabling/disabling code is missing in c_orderdiscount_trg

c_orderdiscount_trg trigger does not have enabling/disabling code
All triggers in OB need to have enabling and disabling code snippet in the beginning

---
M src-db/database/model/triggers/C_ORDERDISCOUNT_TRG.xml
---
(0087941)
hgbot   
2016-06-27 09:43   
Repository: erp/devel/pi
Changeset: ef8f3dbd5d072040627af0443b8b4612f85e1e9d
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Mon Jun 27 09:42:58 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ef8f3dbd5d072040627af0443b8b4612f85e1e9d [^]

Related to issue 33298: Update copyright

---
M src-db/database/model/triggers/C_ORDERDISCOUNT_TRG.xml
---
(0087942)
aferraz   
2016-06-27 09:45   
Code review OK
(0087988)
hudsonbot   
2016-06-27 13:49   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/48c35d75995a [^]
Maturity status: Test
(0088051)
hudsonbot   
2016-06-28 16:06   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/865878a5d292 [^]
Maturity status: Test