Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033288Openbravo ERPZ. Otherspublic2016-06-16 12:212016-06-22 23:13
Reportermaite 
Assigned Tomarkmm82 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q3 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2015-05-29
Regression introduced in release3.0PR15Q3
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/15dbf5983411 [^]
Triggers an Emergency PackNo
Summary0033288: Linked items error in Payment Plan window when invoice is not paid
DescriptionWhen invoice is unpaid no records should appear in linked items section
Steps To Reproduce1. Access Sales Invoice window and filter by "Payment Complete"=No
2. Go to Payment Plan tab and open "Linked Items" section
3. Realize that 2 items are shown when does not exist any related payment document

Problem seems to be that HQL Where clause defined for Lines tab in Payment window is not executed from Linked Items.
Proposed SolutionTo define SQL Where Clause for Lines tab in Payment In and Payment Out window
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00333093.0PR16Q2.1 closed markmm82 Linked items error in Payment Plan window when invoice is not paid 
depends on backport 00333103.0PR16Q1.4 closed markmm82 Linked items error in Payment Plan window when invoice is not paid 
caused by design defect 0025355 closed fsoto82 Long time to show the lines on the payment in/out windows 
related to design defect 0033305 new Triage Platform Base Linked Items do not take into account HQL where clause 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-06-16 12:21maiteNew Issue
2016-06-16 12:21maiteAssigned To => Triage Finance
2016-06-16 12:21maiteModules => Advanced Payables and Receivables Mngmt
2016-06-16 12:21maiteResolution time => 1467756000
2016-06-16 12:21maiteTriggers an Emergency Pack => No
2016-06-16 12:22maiteIssue Monitored: networkb
2016-06-17 15:06caristuRelationship addedrelated to 0033305
2016-06-17 15:40markmm82Assigned ToTriage Finance => markmm82
2016-06-17 15:41markmm82Statusnew => acknowledged
2016-06-20 10:11aferrazRelationship addedcaused by 0025355
2016-06-20 10:13aferrazRegression level => Production - Confirmed Stable
2016-06-20 10:13aferrazRegression date => 2015-05-29
2016-06-20 10:13aferrazRegression introduced in release => 3.0PR15Q3
2016-06-20 10:13aferrazRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/15dbf5983411 [^]
2016-06-20 10:14aferrazStatusacknowledged => scheduled
2016-06-20 16:25markmm82Note Added: 0087682
2016-06-20 16:56markmm82Note Edited: 0087682bug_revision_view_page.php?bugnote_id=0087682#r12431
2016-06-21 10:36hgbotCheckin
2016-06-21 10:36hgbotNote Added: 0087707
2016-06-21 10:36hgbotStatusscheduled => resolved
2016-06-21 10:36hgbotResolutionopen => fixed
2016-06-21 10:36hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a745d6a99abbdf519b449822347371ddf29b5704 [^]
2016-06-21 11:09aferrazReview Assigned To => aferraz
2016-06-21 11:09aferrazNote Added: 0087712
2016-06-21 11:09aferrazStatusresolved => closed
2016-06-21 11:09aferrazFixed in Version => 3.0PR16Q3
2016-06-22 18:10hudsonbotCheckin
2016-06-22 18:10hudsonbotNote Added: 0087827
2016-06-22 18:29hgbotCheckin
2016-06-22 18:29hgbotNote Added: 0087831
2016-06-22 23:13hudsonbotCheckin
2016-06-22 23:13hudsonbotNote Added: 0087838

Notes
(0087682)
markmm82   
2016-06-20 16:25   
(edited on: 2016-06-20 16:56)
Test Plan:
    1. Access Sales Invoice window and filter by "Payment Complete"=No
    2. Select any invoice.
    3. Go to Payment Plan tab and open "Linked Items" section
    3. Realize that no items are shown. It is correct!
(0087707)
hgbot   
2016-06-21 10:36   
Repository: erp/devel/pi
Changeset: a745d6a99abbdf519b449822347371ddf29b5704
Author: Mark <markmm82 <at> gmail.com>
Date: Mon Jun 20 11:25:12 2016 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/a745d6a99abbdf519b449822347371ddf29b5704 [^]

Fixes issue 33288: Linked items corrected in Payment Plan when unpaid invoice

Defined SQL Where Clause for Lines tab in Payment In and Payment Out window due that that HQL Where clause defined for Lines tab in Payment window is not executed from Linked Items correctly.

---
M src-db/database/sourcedata/AD_TAB.xml
---
(0087712)
aferraz   
2016-06-21 11:09   
Code review + Testing OK
(0087827)
hudsonbot   
2016-06-22 18:10   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/468afe624cc8 [^]
Maturity status: Test
(0087831)
hgbot   
2016-06-22 18:29   
Repository: erp/devel/pi
Changeset: 4fcce5e429cef22f1a436091bb7817af92334b2a
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Jun 22 18:18:48 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4fcce5e429cef22f1a436091bb7817af92334b2a [^]

Related to issue 33288: Code review improvements

Use FIN_Payment_ScheduleDetail instead of e to avoid errors when compiling in 2.50 mode.

---
M src-db/database/sourcedata/AD_TAB.xml
---
(0087838)
hudsonbot   
2016-06-22 23:13   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f80830d152e3 [^]
Maturity status: Test