Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033273Openbravo ERP07. Sales managementpublic2016-06-15 12:582016-08-11 18:40
Reportermaite 
Assigned Tomarkmm82 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q4 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033273: Error posting Reversed Sales Invoice document not defined as "return" and in case related order is prepaid
DescriptionError "Process failed during execution" is shown in the application and log shows error "WARN org.openbravo.erpCommon.ad_forms.Fact - isSourceBalanced NO - Balance=3.68"
Steps To Reproduce0. Configure General Ledger Configuration | General Accounts to NOT Use Suspense Balancing
1. Create Sales Order with invoice terms= immediate. Add any line and process
2. Run Add Payment process from order and register prepayment
3. Create Sales Invoice. Run "Create lines from" process and select previous order and process
4. Run "Void" process from sales invoice
5. Access reversed sales, navigate to document type and UNMARK "return" flag
6. Try to post reversed sales invoice and error "Process failed during execution" will be received
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
has duplicate defect 00337953.0PR16Q4 closed AtulOpenbravo "Process failed during execution" when posting Reversed Sales Invoice with document type defined as return=N 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-06-15 12:58maiteNew Issue
2016-06-15 12:58maiteAssigned To => Triage Finance
2016-06-15 12:58maiteModules => Core
2016-06-15 12:58maiteTriggers an Emergency Pack => No
2016-06-15 12:59maiteResolution time => 1467756000
2016-06-15 12:59maiteTarget Version => 3.0PR16Q3
2016-06-15 12:59maiteIssue Monitored: networkb
2016-06-17 14:58aferrazAssigned ToTriage Finance => markmm82
2016-06-21 15:04markmm82Statusnew => scheduled
2016-06-24 02:57markmm82Note Added: 0087864
2016-06-24 02:59markmm82Note Edited: 0087864bug_revision_view_page.php?bugnote_id=0087864#r12481
2016-06-24 11:21psanjuanNote Added: 0087887
2016-06-24 13:46psanjuanNote Edited: 0087887bug_revision_view_page.php?bugnote_id=0087887#r12506
2016-06-24 13:55psanjuanNote Edited: 0087887bug_revision_view_page.php?bugnote_id=0087887#r12507
2016-06-24 13:56psanjuanNote Edited: 0087887bug_revision_view_page.php?bugnote_id=0087887#r12508
2016-06-24 14:05psanjuanNote Edited: 0087887bug_revision_view_page.php?bugnote_id=0087887#r12509
2016-06-24 14:10psanjuanNote Edited: 0087887bug_revision_view_page.php?bugnote_id=0087887#r12510
2016-06-24 14:11psanjuanNote Edited: 0087887bug_revision_view_page.php?bugnote_id=0087887#r12511
2016-06-27 11:00aferrazTarget Version3.0PR16Q3 =>
2016-07-01 11:08psanjuanNote Added: 0088140
2016-07-01 11:09psanjuanNote Edited: 0088140bug_revision_view_page.php?bugnote_id=0088140#r12571
2016-07-01 11:31psanjuanNote Edited: 0088140bug_revision_view_page.php?bugnote_id=0088140#r12572
2016-07-01 11:37psanjuanNote Edited: 0088140bug_revision_view_page.php?bugnote_id=0088140#r12573
2016-07-01 11:45psanjuanNote Edited: 0088140bug_revision_view_page.php?bugnote_id=0088140#r12576
2016-07-01 11:45psanjuanNote Edited: 0088140bug_revision_view_page.php?bugnote_id=0088140#r12577
2016-07-01 11:51psanjuanNote Added: 0088144
2016-07-01 11:52psanjuanNote Edited: 0088144bug_revision_view_page.php?bugnote_id=0088144#r12579
2016-07-01 11:55psanjuanNote Edited: 0088144bug_revision_view_page.php?bugnote_id=0088144#r12580
2016-07-01 11:55psanjuanNote Added: 0088145
2016-07-01 12:01psanjuanNote Edited: 0088144bug_revision_view_page.php?bugnote_id=0088144#r12581
2016-07-01 12:02psanjuanNote Edited: 0088140bug_revision_view_page.php?bugnote_id=0088140#r12582
2016-07-01 12:02psanjuanNote Edited: 0088144bug_revision_view_page.php?bugnote_id=0088144#r12583
2016-07-01 12:05psanjuanNote Edited: 0088145bug_revision_view_page.php?bugnote_id=0088145#r12585
2016-07-01 12:05psanjuanNote Added: 0088146
2016-07-01 13:51psanjuanNote Edited: 0088145bug_revision_view_page.php?bugnote_id=0088145#r12588
2016-07-01 13:52psanjuanNote Edited: 0088140bug_revision_view_page.php?bugnote_id=0088140#r12589
2016-07-01 13:54psanjuanNote Edited: 0088146bug_revision_view_page.php?bugnote_id=0088146#r12591
2016-07-01 13:59psanjuanNote Edited: 0088146bug_revision_view_page.php?bugnote_id=0088146#r12592
2016-07-01 14:05psanjuanNote Edited: 0088146bug_revision_view_page.php?bugnote_id=0088146#r12593
2016-07-01 14:22psanjuanNote Edited: 0088146bug_revision_view_page.php?bugnote_id=0088146#r12594
2016-07-04 13:18psanjuanNote Edited: 0088144bug_revision_view_page.php?bugnote_id=0088144#r12595
2016-07-04 13:24psanjuanNote Edited: 0088145bug_revision_view_page.php?bugnote_id=0088145#r12596
2016-07-04 13:31psanjuanNote Edited: 0088146bug_revision_view_page.php?bugnote_id=0088146#r12597
2016-07-04 13:37psanjuanNote Added: 0088174
2016-07-04 13:43psanjuanNote Edited: 0088174bug_revision_view_page.php?bugnote_id=0088174#r12599
2016-07-04 13:44psanjuanNote Edited: 0088146bug_revision_view_page.php?bugnote_id=0088146#r12600
2016-07-04 13:51psanjuanNote Added: 0088175
2016-07-06 16:26hgbotCheckin
2016-07-06 16:26hgbotNote Added: 0088243
2016-07-06 16:26hgbotStatusscheduled => resolved
2016-07-06 16:26hgbotResolutionopen => fixed
2016-07-06 16:26hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6dc419f9cc80336ca5ccb680cfd8ad9eaf88da8c [^]
2016-07-06 16:26hgbotCheckin
2016-07-06 16:26hgbotNote Added: 0088244
2016-07-06 16:27vmromanosReview Assigned To => vmromanos
2016-07-06 16:27vmromanosNote Added: 0088245
2016-07-06 16:27vmromanosStatusresolved => closed
2016-07-06 16:27vmromanosFixed in Version => 3.0PR16Q4
2016-08-11 18:40hudsonbotCheckin
2016-08-11 18:40hudsonbotNote Added: 0088993
2016-08-11 18:40hudsonbotCheckin
2016-08-11 18:40hudsonbotNote Added: 0088994
2016-08-31 12:49aferrazRelationship addedhas duplicate 0033795

Notes
(0087864)
markmm82   
2016-06-24 02:57   
(edited on: 2016-06-24 02:59)
Test Plan

Log in as System Administrator.
1-Go to "Windows, Tabs and Fields" window.
2-Select the “General Ledger” window
3-Go to Tabs and select the “General Accounts” tab.
4-Go to the fields tab and unchec the filter to see all the fields displayed and not.
5-Edit “Due to Intercompany” field
    Active: Yes
    Displayed: Yes
6-Edit “Due from Intercompany” field
    Active: Yes
    Displayed: Yes
7-Log out

Log in as Group Administrator.
0. Go to General Ledger Configuration | General Accounts
1. Select “F&B España, S.A. US/A/Euro” General Ledger
2. Go to the "General Account" tab and configure to NOT Use Suspense Balancing
    Uncheck “Suspense Balancing Use” checkbox
    Notice the “Due to Intercompany” field is shown. Select an account for this.
    Notice the “Due from Intercompany” field is shown. Select an account for this.

3. Create Sales Order with invoice terms= immediate. Add any line and process
4. Run Add Payment process from order and register prepayment
5. Create Sales Invoice. Run "Create lines from" process and select previous order and process
6. Run "Void" process from sales invoice
7. Access reversed sales, navigate to document type and UNMARK "return" flag
8. Try to post reversed sales invoice and the process is successfully and the invoice is posted.
(0087887)
psanjuan   
2016-06-24 11:21   
(edited on: 2016-06-24 14:11)
Test plan needed to reproduce the issue as well as for a better understanding of it:

Go to Sales Invoice window and create a new one for F&B España, Alimentos y Supermercados BP.

Enter a positive line as shown below:
Product = Cerveza Ale 0.5L, Invoiced Quantity = 5

And a negative line as shown below:
Product = Cola 0.5L, Invoiced Quantity = -1

Make sure there is no basic discount. Complete and post the invoice.

Posting looks like:

11.34 (43000) Clientes - DEBIT
0.83 (70000) Ventas - DEBIT (negative line net amount)
10.20 (70000) Ventas - CREDICT (positive line net amount)
1.97 (47700) HP IVA repercutido - CREDIT

Try to Void the invoice, by using Reactivate button, Void action. Press OK.

Below error is shown which is OK, because negative line of the invoice turns to positive.
"Return invoices do not allow lines with positive quantities."

Go to Document Type window and set as "Return" = No below document type:
Reversed Sales Invoice
Save.

Go to the invoice and try to VOID it now.
Check it is possible now and a sales reversed invoice document has been created.

Navigate to it and check below posting takes place, which is OK:

10.20 (70000) Ventas - DEBIT (positive line net amount)
1.97 (47700) HP IVA repercutido - DEBIT
11.34 (43000) Clientes - CREDIT
0.83 (70000) Ventas - CREDIT (negative line net amount)

Leave Document type as "Return" = No

Create a Sales Order for F&B España and Alimentos y Supermercados BP.
Add any positive line. Make sure no basic discount is shown. Invoice Terms = Inmediate.
Book it.

Go to Sales Invoice window and create a new invoice for F&B España, Alimentos y Supermercados BP by using Create Lines From.
Complete and Post the invoice.

Posting looks like:

18.51 (43000) Clientes - DEBIT
15.30 (70000) Ventas - CREDIT
3.21 (47700) HP IVA repercutido - CREDIT

Go back to the sales invoice and Void it.

Go to the reversed sales invoice just created and post it.
Posting will look like

15.30 (70000) Ventas - DEBIT
3.21 (47700) HP IVA repercutido - DEBIT
18.51 (43000) Clientes - CREDIT.

So far, all is OK.

Now create a sales order same way as before and add a payment to it.
Create a Sales invoice from the order by using Create Lines From.
Complete and Post the invoice:

Posting will look like:

9.26 (43800) Anticipo de Clientes - DEBIT
7.65 (70000) Ventas - CREDIT
1.61 (47700) HP IVA repercutido - CREDIT

Void the invoice.

Go to the reverse sales invoice and post it.

Verify below posting is shown which is NOT CORRECT

9.26 (43800) Anticipo de Clientes - DEBIT
7.65 (70000) Ventas - DEBIT
1.61 (47700) HP IVA repercutido - DEBIT
18.52 (90400) Cuenta de Cuadre - CREDIT

Correct posting should have been:

7.65 (70000) Ventas - DBBIT
1.61 (47700) HP IVA repercutido - DEBIT
9.26 (43800) Anticipo de Clientes - CREDIT
(0088140)
psanjuan   
2016-07-01 11:08   
(edited on: 2016-07-01 13:52)
Test Plan 1

Go to Sales Invoice window and create a new one for F&B España, Alimentos y Supermercados BP.

Enter a positive line as shown below:
Product = Cerveza Ale 0.5L, Invoiced Quantity = 5

And a negative line as shown below:
Product = Cola 0.5L, Invoiced Quantity = -1

Make sure there is no basic discount. Complete and post the invoice.

Posting looks like:

11.34 (43000) Clientes - DEBIT
0.83 (70000) Ventas - DEBIT (negative line net amount)
10.20 (70000) Ventas - CREDICT (positive line net amount)
1.97 (47700) HP IVA repercutido - CREDIT

Try to Void the invoice, by using Reactivate button, Void action. Press OK.

Below error is shown which is OK, because negative line of the invoice turns to positive.
"Return invoices do not allow lines with positive quantities."

Go to Document Type window and set as "Return" = No below document type:
Reversed Sales Invoice
Save.

Go to the invoice and try to VOID it now.
Check it is possible now and a sales reversed invoice document has been created.

Navigate to it and check below posting takes place, which is OK:

10.20 (70000) Ventas - DEBIT (positive line net amount)
1.97 (47700) HP IVA repercutido - DEBIT
11.34 (43000) Clientes - CREDIT
0.83 (70000) Ventas - CREDIT (negative line net amount)

Leave Document type as "Return" = No

Create a Sales Order for F&B España and Alimentos y Supermercados BP.
Add any positive line. Make sure no basic discount is shown. Invoice Terms = Inmediate.
Book it.

Go to Sales Invoice window and create a new invoice for F&B España, Alimentos y Supermercados BP by using Create Lines From.
Complete and Post the invoice.

Posting looks like:

18.51 (43000) Clientes - DEBIT
15.30 (70000) Ventas - CREDIT
3.21 (47700) HP IVA repercutido - CREDIT

Go back to the sales invoice and Void it.

Go to the reversed sales invoice just created and post it.
Posting will look like

15.30 (70000) Ventas - DEBIT
3.21 (47700) HP IVA repercutido - DEBIT
18.51 (43000) Clientes - CREDIT.

So far, all is OK.

Now create a sales order same way as before and add a payment to it.
Create a Sales invoice from the order by using Create Lines From.
Complete and Post the invoice:

Posting will look like:

9.26 (43800) Anticipo de Clientes - DEBIT
7.65 (70000) Ventas - CREDIT
1.61 (47700) HP IVA repercutido - CREDIT

Void the invoice.

Go to the reverse sales invoice and post it.

Verify below posting is shown:

7.65 (70000) Ventas - DBBIT
1.61 (47700) HP IVA repercutido - DEBIT
9.26 (43800) Anticipo de Clientes - CREDIT

Test Plan 2

Repeat same test as above for purchase cycle.

Final voided invoice correct posting should be (this one is not correct now):

8.23 (40700) Anticipo a proveedores - DEBIT
6.80 (60000) Compra de Mercaderias - CREDIT
1.43 (47200) HP. IVA soportado - CREDIT
(0088144)
psanjuan   
2016-07-01 11:51   
(edited on: 2016-07-04 13:18)
Test Plan 3

Creation of a sales order including a positive line for a total amount of 1110.78 for instance. Pay it partially for instance 500.00 €. Create the invoice from the order. Post the invoice. Check invoice accounting is like:

610.78 (43000) Clientes DEBIT
500.00 (43800) Anticipos DEBIT
918.00 (70000) Ventas CREDIT
192.78 (47700) HP IVA soportado CREDIT


Void the invoice. Check voided invoice accounting is like:

918.00 (70000) Ventas DEBIT
192.78 (47700) HP IVA soportado DEBIT
610.78 (43000) Clientes CREDIT
500.00 (43800) Anticipos CREDIT


Test Plan 4

Repeat same test as above for purchase.

Creation of a purchase order including a positive line for a total amount of 1110.78 for instance. Pay it partially for instance 500.00 €. Create the invoice from the order. Post the invoice. Check invoice accounting is like:

918.00 (6000) Compras de mercaderias DEBIT
192.78 (47200) HP IVA soportado DEBIT
610.78 (40000) Proveedores CREDIT
500.00 (40700) Anticipo de proveedores CREDIT

Void the invoice. Check voided invoice accounting is like:

610.78 (40000) Proveedores DEBIT
500.00 (40700) Anticipo de proveedores DEBIT
918.00 (6000) Compras de mercaderias CREDIT
192.78 (47200) HP IVA soportado CREDIT
(0088145)
psanjuan   
2016-07-01 11:55   
(edited on: 2016-07-04 13:24)
Test Plan 5

Creation of a sales order including a positive (product = Agua sin Gas 1L, Ordered Qty = 100, VAT % 21% ; Line Net Amount = 153.00) and a negative amount (product = Cola 0.5L, Ordered Qty = -10, VAT % 21% Line Net Amount = -8.30), therefore total balance is positive:
Total Gross Amount = 175.09
Total Net Amount = 144.70
Tax Amount = 30.39

Add a payment to the invoice. Pay it totally.

Create the invoice from the order. Check that it is set as payment complete = Yes. Post the invoice. Check invoice accounting.

175.09 (43800) Anticipo de clientes DEBIT
8.30 (70000) Venta de mercaderias (negative line) DEBIT
153.00 (70000) Venta de mercaderias (positive line) CREDIT
30.39 (47700) HP. IVA repercutido CREDIT

Void the invoice. Check voided invoice accounting.

175.09 (43800) Anticipo de clientes CREDIT
8.30 (70000) Venta de mercaderias (negative line) CREDIT
153.00 (70000) Venta de mercaderias (positive line) DEBIT
30.39 (47700) HP. IVA repercutido DEBIT

Above posting is OK.

Test Plan 6

Creation of a purchase order including a positive (product = Cerveza Ale 0.5L, Ordered Qty = 100, VAT % 21% ; Line Net Amount = 136.00) and a negative amount (product = Cerveza Lager 0.5L, Ordered Qty = -10, VAT % 21% Line Net Amount = -17.60), therefore total balance is positive:
Total Gross Amount = 143.26
Total Net Amount = 118.40
Tax Amount = 24.86

Add a payment to the invoice. Pay it totally.

Create the invoice from the order. Check that it is set as payment complete = Yes. Post the invoice. Check invoice accounting.

136.00 (60000) Compra de mercaderias (positive line) DEBIT
24.86 (47200) HP IVA soportado DEBIT
143.26 (40700) Anticipo a proveedores CREDIT
17.60 (60000) Compra de mercaderias (negative line) CREDIT

Void the invoice. Check voided invoice accounting should have been:

143.26 (40700) Anticipo a proveedores DEBIT
17.60 (60000) Compra de mercaderias (negative line) DEBIT
136.00 (60000) Compra de mercaderias (positive line) CREDIT
24.86 (47200) HP IVA soportado CREDIT
(0088146)
psanjuan   
2016-07-01 12:05   
(edited on: 2016-07-04 13:44)
Test Plan 7

Creation of a sales order including a positive (product = Agua sin Gas 1L, Ordered Qty = 100, VAT % 21% ; Line Net Amount = 153.00) and a negative amount (product = Cola 0.5L, Ordered Qty = -10, VAT % 21% Line Net Amount = -8.30), therefore total balance is positive:
Total Gross Amount = 175.09
Total Net Amount = 144.70
Tax Amount = 30.39

Add a payment to the invoice. Pay it partially, for instance 75.09

Create the invoice from the order. Check that prepayment amount = 75.09. Post the invoice. Check invoice accounting.

75.09 (43800) Anticipo de clientes DEBIT
100.00 (43000) Clientes DEBIT
8.30 (70000) Venta de mercaderias (negative line) DEBIT
153.00 (70000) Venta de mercaderias (positive line) CREDIT
30.39 (47700) HP. IVA repercutido CREDIT

Void the invoice. Check voided invoice accounting is as shown below:

153.00 (70000) Venta de mercaderias (positive line) DEBIT
30.39 (47700) HP. IVA repercutido DEBIT
75.09 (43800) Anticipo de clientes CREDIT
100.00 (43000) Clientes CREDIT
8.30 (70000) Venta de mercaderias (negative line) CREDIT

Test Plan 8

Creation of a purchase order including a positive (product = Cerveza Ale 0.5L, Ordered Qty = 100, VAT % 21% ; Line Net Amount = 136.00) and a negative amount (product = Cerveza Lager 0.5L, Ordered Qty = -10, VAT % 21% Line Net Amount = -17.60), therefore total balance is positive:
Total Gross Amount = 143.26
Total Net Amount = 118.40
Tax Amount = 24.86

Add a payment to the invoice. Pay it partially for instance 43.26

Create the invoice from the order. Check that prepayment amount = 43.26. Post the invoice. Check invoice accounting.

136.00 (60000) Compra de mercaderias (positive line) DEBIT
24.86 (47200) HP IVA soportado DEBIT
100.00 (4000) Proveedores CREDIT
43.26 (40700) Anticipo a proveedores CREDIT
17.60 (60000) Compra de mercaderias (negative line) CREDIT

Void the invoice. Check voided invoice accounting is as shown below:

100.00 (40000) Proveedores DEBIT
43.26 (40700) Anticipo a proveedores DEBIT
17.60 (60000) Compra de mercaderias (negative line) DEBIT
136.00 (60000) Compra de mercaderias (positive line) CREDIT
24.86 (47200) HP IVA soportado CREDIT
(0088174)
psanjuan   
2016-07-04 13:37   
(edited on: 2016-07-04 13:43)
Test Plan 9

Creation of a sales order including a positive (product = Agua sin Gas 1L, Ordered Qty = 100, VAT % 21% ; Line Net Amount = 153.00) and a negative amount (product = Cola 0.5L, Ordered Qty = -10, VAT % 21% Line Net Amount = -8.30), therefore total balance is positive:
Total Gross Amount = 175.09
Total Net Amount = 144.70
Tax Amount = 30.39

Add a payment to the invoice. Pay it partially, for instance 75.09

Create the invoice from the order. Check that prepayment amount = 75.09
Add a new line for instance:
Product = Vino Blanco
Invoiced Qty = 50

Complete and post the invoice. Check invoice accounting.

422.46 (43000) Clientes DEBIT
75.09 (43800) Anticipo de clientes DEBIT
8.30 (70000) Venta de mercaderias (negative line) DEBIT
419.50 (70000) Venta de mercaderias (positive line) CREDIT
86.35 (47700) HP. IVA repercutido CREDIT

Void the invoice. Check voided invoice accounting is as shown below:

419.50 (70000) Venta de mercaderias (positive line) DEBIT
86.35 (47700) HP. IVA repercutido DEBIT
75.09 (43800) Anticipo de clientes CREDIT
422.46(43000) Clientes CREDIT
8.30 (70000) Venta de mercaderias (negative line) CREDIT

Test Plan 10

Creation of a purchase order including a positive (product = Cerveza Ale 0.5L, Ordered Qty = 100, VAT % 21% ; Line Net Amount = 136.00) and a negative amount (product = Cerveza Lager 0.5L, Ordered Qty = -10, VAT % 21% Line Net Amount = -17.60), therefore total balance is positive:
Total Gross Amount = 143.26
Total Net Amount = 118.40
Tax Amount = 24.86

Add a payment to the invoice. Pay it partially for instance 43.26

Create the invoice from the order. Check that Prepayment Amount = 43.26

Add a new line for instance:
Product = Vino Blanco
Invoiced Qty = 50

Complete and post the invoice. Check invoice accounting.

313.50 (60000) Compra de mercaderias (positive line) DEBIT
62.14(47200) HP IVA soportado DEBIT
314.78 (4000) Proveedores CREDIT
43.26 (40700) Anticipo a proveedores CREDIT
17.60 (60000) Compra de mercaderias (negative line) CREDIT

Void the invoice. Check voided invoice accounting is as shown below:

314.78 (40000) Proveedores DEBIT
43.26 (40700) Anticipo a proveedores DEBIT
17.60 (60000) Compra de mercaderias (negative line) DEBIT
313.50 (60000) Compra de mercaderias (positive line) CREDIT
62.14 (47200) HP IVA soportado CREDIT

Test Plan 11

Repeat same test as above 9 and 10 but paying the order totally.
Check invoice and voided invoice accounting is correct.
(0088175)
psanjuan   
2016-07-04 13:51   
Test plan above verified.

Issue can be code reviewed and closed.
(0088243)
hgbot   
2016-07-06 16:26   
Repository: erp/devel/pi
Changeset: 6dc419f9cc80336ca5ccb680cfd8ad9eaf88da8c
Author: Mark <markmm82 <at> gmail.com>
Date: Fri Jul 01 10:44:01 2016 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/6dc419f9cc80336ca5ccb680cfd8ad9eaf88da8c [^]

Fixes issue 33273: Fix posting Reversed Invoice document not defined as "return"
Fixed posting for reversed sales invoices documents when are not defined as "return" and the related order is prepaid

---
M src/org/openbravo/erpCommon/ad_forms/DocInvoice.java
M src/org/openbravo/erpCommon/ad_forms/DocInvoice_data.xsql
---
(0088244)
hgbot   
2016-07-06 16:26   
Repository: erp/devel/pi
Changeset: 85ac34e36934055ddba7be07b3f22ea8e2de9293
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Jul 06 16:26:46 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/85ac34e36934055ddba7be07b3f22ea8e2de9293 [^]

Related to issue 33273: code review improvements

Avoid to run the isReversedInvoice() method several times

---
M src/org/openbravo/erpCommon/ad_forms/DocInvoice.java
---
(0088245)
vmromanos   
2016-07-06 16:27   
Code review + testing OK
(0088993)
hudsonbot   
2016-08-11 18:40   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/edaa05b1fb18 [^]
Maturity status: Test
(0088994)
hudsonbot   
2016-08-11 18:40   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/edaa05b1fb18 [^]
Maturity status: Test