Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033266Retail ModulesWeb POSpublic2016-06-15 09:422016-07-04 11:46
Reporteraaroncalero 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033266: [SERQA 1270] Products added as part of a pack are no longer marked with a packId
DescriptionAs part of the fix for the issue 0032972, the packId attribute set on lines added by packs was removed.
It would be nice to have at least a reference to distinguish these lines, so it is still possible to apply some logic when adding packs.

Additionally, there's still some code on the order.js file referencing the packId.
Steps To ReproduceVerify that this changeset https://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/06fce121bb480bc74b0410e5f36d30e7ce74ee92 [^] removes the packId.

Verify that on order.js: https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/tip/web/org.openbravo.retail.posterminal/js/model/order.js#l1361 [^] there is an if condition which depends on the packId.
Proposed Solution
Additional Information
TagsSER-QA
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-06-15 09:42aaroncaleroNew Issue
2016-06-15 09:42aaroncaleroAssigned To => Retail
2016-06-15 09:42aaroncaleroOBNetwork customer => Yes
2016-06-15 09:42aaroncaleroResolution time => 1467151200
2016-06-15 09:42aaroncaleroTriggers an Emergency Pack => No
2016-06-15 09:43aaroncaleroTag Attached: SER-QA
2016-06-21 13:43ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2016-06-21 13:43ranjith_qualiantech_comStatusnew => scheduled
2016-07-04 10:50hgbotCheckin
2016-07-04 10:50hgbotNote Added: 0088168
2016-07-04 10:50hgbotCheckin
2016-07-04 10:50hgbotNote Added: 0088169
2016-07-04 10:50hgbotStatusscheduled => resolved
2016-07-04 10:50hgbotResolutionopen => fixed
2016-07-04 10:50hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/7113be8ccf73b5e140dad66dc87c08dd686072d9 [^]
2016-07-04 11:46marvintmReview Assigned To => marvintm
2016-07-04 11:46marvintmStatusresolved => closed

Notes
(0088168)
hgbot   
2016-07-04 10:50   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 819c74cd43e47b00c089cf4ae112a6b72053efc1
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jul 04 14:19:57 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/819c74cd43e47b00c089cf4ae112a6b72053efc1 [^]

Related to issue 33266 : Removed unused condition which uses "packId"

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0088169)
hgbot   
2016-07-04 10:50   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 7113be8ccf73b5e140dad66dc87c08dd686072d9
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jul 04 14:20:11 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/7113be8ccf73b5e140dad66dc87c08dd686072d9 [^]

Fixes issue 33266 : Added new attribute "belongsToPack" to line if the product is present in pack

---
M web/org.openbravo.retail.discounts/js/promotion-pack.js
---