Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033226Openbravo ERPA. Platformpublic2016-06-11 21:362016-06-20 13:06
Reporterguillermogil 
Assigned Tocaristu 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q1.4Fixed in Version3.0PR16Q1.4 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - QA Approved
Regression date2015-10-27
Regression introduced in release3.0PR16Q1
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/cbf2d65774b8afda5265c76b78642271a0a7246a [^]
Triggers an Emergency PackNo
Summary0033226: ConcatPDFReport has a null pointer exception if is used without reportConfiguration parameter
DescriptionConcatPDFReport has a null pointer exception if is used without reportConfiguration parameter
Method concatPDFReport(List<JasperPrint> jasperPrintList, boolean createBookmarks,
      OutputStream outputStream)
is creating a null pointer exception
Steps To ReproduceCreate a call on concatPDFReport(List<JasperPrint> jasperPrintList, boolean createBookmarks,
      OutputStream outputStream)
Without any SimplePdfExporterConfiguration
Proposed SolutionOn ReportingUtils.java:
   public static void concatPDFReport(List<JasperPrint> jasperPrintList, boolean createBookmarks,
      OutputStream outputStream, SimplePdfExporterConfiguration reportConfiguration)
      throws JRException {

    JRPdfExporter exporter = new JRPdfExporter();
    SimpleOutputStreamExporterOutput exporterOutput = new SimpleOutputStreamExporterOutput(
        outputStream);
    SimplePdfExporterConfiguration configuration = reportConfiguration != null ? reportConfiguration
        : new SimplePdfExporterConfiguration();

    reportConfiguration.setCreatingBatchModeBookmarks(createBookmarks);
    exporter.setConfiguration(configuration);
    exporter.setExporterInput(SimpleExporterInput.getInstance(jasperPrintList));
    exporter.setExporterOutput(exporterOutput);

    exporter.exportReport();
  }

Line:
    reportConfiguration.setCreatingBatchModeBookmarks(createBookmarks);
Should be:
    configuration.setCreatingBatchModeBookmarks(createBookmarks);
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0033222 closed caristu ConcatPDFReport has a null pointer exception if is used without reportConfiguration parameter 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-06-13 09:49alostaleTypedefect => backport
2016-06-13 09:49alostaleTarget Version => 3.0PR16Q1.4
2016-06-13 11:00hgbotCheckin
2016-06-13 11:00hgbotNote Added: 0087192
2016-06-13 11:00hgbotStatusscheduled => resolved
2016-06-13 11:00hgbotResolutionopen => fixed
2016-06-13 11:00hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR16Q1.4/rev/fe177b6118d7d599ab1fbc21fc7750f8f4dddead [^]
2016-06-13 11:21caristuReview Assigned To => alostale
2016-06-20 13:06alostaleNote Added: 0087668
2016-06-20 13:06alostaleStatusresolved => closed
2016-06-20 13:06alostaleFixed in Version => 3.0PR16Q1.4

Notes
(0087192)
hgbot   
2016-06-13 11:00   
Repository: erp/backports/3.0PR16Q1.4
Changeset: fe177b6118d7d599ab1fbc21fc7750f8f4dddead
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Jun 13 10:59:22 2016 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR16Q1.4/rev/fe177b6118d7d599ab1fbc21fc7750f8f4dddead [^]

fixes issue 33226: ConcatPDFReport can throw a null pointer exception
Use the correct variable name (configuration instead of reportConfiguration) when using the setCreatingBatchModeBookmarks method

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/report/ReportingUtils.java
---
(0087668)
alostale   
2016-06-20 13:06   
code reviewed + tested