Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033223Retail ModulesWeb POSpublic2016-06-12 02:412016-08-24 09:01
ReporterOrekaria 
Assigned ToOrekaria 
PrioritynormalSeveritytrivialReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q3 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033223: Several java warnings
DescriptionSeveral java warnings
Steps To ReproduceWith Retail installed
Open the Openbravo projects in Eclipse
With default warning options, verify that several warnings are shown
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
has duplicate defect 0032537RR16Q3 closed Retail Class SimpleQueryBuilder has several warnings in the code for not-used vars and inner class overrides main vars 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-06-12 02:41OrekariaNew Issue
2016-06-12 02:41OrekariaAssigned To => Retail
2016-06-12 02:41OrekariaOBNetwork customer => No
2016-06-12 02:41OrekariaTriggers an Emergency Pack => No
2016-06-12 02:41OrekariaAssigned ToRetail => Orekaria
2016-06-12 02:47OrekariaStatusnew => scheduled
2016-06-12 19:07hgbotCheckin
2016-06-12 19:07hgbotNote Added: 0087182
2016-06-12 19:07hgbotStatusscheduled => resolved
2016-06-12 19:07hgbotResolutionopen => fixed
2016-06-12 19:07hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6cfb00876eb73efa29864b96ffcaead8a1281924 [^]
2016-06-12 19:08hgbotCheckin
2016-06-12 19:08hgbotNote Added: 0087183
2016-06-12 19:08hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6cfb00876eb73efa29864b96ffcaead8a1281924 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6169285b9332a95bd6e99633284d3a70c5301ea4 [^]
2016-06-13 16:40OrekariaRelationship addedhas duplicate 0032537
2016-06-20 18:58guilleaerNote Added: 0087686
2016-06-22 16:58hgbotCheckin
2016-06-22 16:58hgbotNote Added: 0087808
2016-06-23 10:34guilleaerReview Assigned To => guilleaer
2016-06-23 10:34guilleaerStatusresolved => closed
2016-06-23 10:34guilleaerFixed in Version => RR16Q3
2016-08-24 09:01hgbotCheckin
2016-08-24 09:01hgbotNote Added: 0089328

Notes
(0087182)
hgbot   
2016-06-12 19:07   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 6cfb00876eb73efa29864b96ffcaead8a1281924
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Sun Jun 12 11:47:53 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/6cfb00876eb73efa29864b96ffcaead8a1281924 [^]

Fixes issue 33223: java Warnings

---
M src/org/openbravo/mobile/core/process/SimpleQueryBuilder.java
---
(0087183)
hgbot   
2016-06-12 19:08   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6169285b9332a95bd6e99633284d3a70c5301ea4
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Sun Jun 12 12:09:37 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6169285b9332a95bd6e99633284d3a70c5301ea4 [^]

Fixes issue 33223: java Warnings

---
M src/org/openbravo/retail/posterminal/CheckTerminalAuth.java
M src/org/openbravo/retail/posterminal/master/Discount.java
---
(0087686)
guilleaer   
2016-06-20 18:58   
Discount.java
-------------
I think that this part of code should be removed because it is not used:
    try {
      OBContext.setAdminMode(false);
      (priceList.getCurrency().getObposPosprecision() == null ? priceList.getCurrency()
          .getPricePrecision() : priceList.getCurrency().getObposPosprecision()).toString();
    } catch (Exception e) {
      log.error("Error getting currency by id: " + e.getMessage(), e);
    } finally {
      OBContext.restorePreviousMode();
    }

CheckTerminalAuth.java
----------------------
It seems that we are not taking into account the value readed from the preference. Probably we should do something different if the value of the preference is N (false)
(0087808)
hgbot   
2016-06-22 16:58   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 0074fa780a929c550f1de3b22b4611ecf6530824
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Jun 22 16:57:36 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0074fa780a929c550f1de3b22b4611ecf6530824 [^]

Related to issue 33223. Removed unnecessary code.

---
M src/org/openbravo/retail/posterminal/master/Discount.java
---
(0089328)
hgbot   
2016-08-24 09:01   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 39f25daa5f72abf6dd55f0e5602f7dbb87b290e8
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Tue Aug 23 16:21:14 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/39f25daa5f72abf6dd55f0e5602f7dbb87b290e8 [^]

Related to issue 33223: Remove java warning in the CashCloseProcessor class

---
M src/org/openbravo/retail/posterminal/CashCloseProcessor.java
M src/org/openbravo/retail/posterminal/ProcessCashClose.java
---