Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0033216 | Openbravo ERP | A. Platform | public | 2016-06-10 14:15 | 2016-08-11 18:40 |
|
| Reporter | dmiguelez | |
| Assigned To | NaroaIriarte | |
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 20 | OS Version | Community Appliance |
| Product Version | | |
| Target Version | 3.0PR16Q4 | Fixed in Version | 3.0PR16Q4 | |
| Merge Request Status | |
| Review Assigned To | alostale |
| OBNetwork customer | No |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0033216: Problems with onChange Event with Product Characteristics selector |
| Description | It seems to be a problem with the Product Characteristics selector that is preventing the onChange function to work properly for the rest of the fields. |
| Steps To Reproduce | Apply the attached patch.
Create a new Purchase Order:
- Organization: F&B US
- Business Partner: Be Soft Drinker
Click on Create Lines Button
In the Pop Up, modify the Aum Quantity (e.g. 10) and click on other field of the same row. The ordered Quantity is modified with the same value.
Repeat the same process for a different line. It does not work |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  issue.diff (24,520) 2016-06-10 14:15
https://issues.openbravo.com/file_download.php?file_id=9513&type=bug
 issue33216v2.export (6,610) 2016-06-30 17:43
https://issues.openbravo.com/file_download.php?file_id=9603&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2016-06-10 14:15 | dmiguelez | New Issue | |
| 2016-06-10 14:15 | dmiguelez | Assigned To | => platform |
| 2016-06-10 14:15 | dmiguelez | File Added: issue.diff | |
| 2016-06-10 14:15 | dmiguelez | OBNetwork customer | => No |
| 2016-06-10 14:15 | dmiguelez | Modules | => Core |
| 2016-06-10 14:15 | dmiguelez | Triggers an Emergency Pack | => No |
| 2016-06-10 14:29 | AugustoMauch | Note Added: 0087162 | |
| 2016-06-10 14:29 | AugustoMauch | Note Edited: 0087162 | bug_revision_view_page.php?bugnote_id=0087162#r12352 |
| 2016-06-23 10:09 | NaroaIriarte | Assigned To | platform => NaroaIriarte |
| 2016-06-23 10:22 | NaroaIriarte | Status | new => acknowledged |
| 2016-06-27 09:23 | NaroaIriarte | File Added: issue33216.export | |
| 2016-06-27 09:24 | NaroaIriarte | Note Added: 0087940 | |
| 2016-06-27 13:13 | NaroaIriarte | Status | acknowledged => scheduled |
| 2016-06-28 10:57 | caristu | Target Version | => 3.0PR16Q4 |
| 2016-06-28 11:25 | NaroaIriarte | File Deleted: issue33216.export | |
| 2016-06-28 11:25 | NaroaIriarte | File Added: issue33216.export | |
| 2016-06-30 17:43 | NaroaIriarte | File Added: issue33216v2.export | |
| 2016-06-30 17:43 | NaroaIriarte | File Deleted: issue33216.export | |
| 2016-07-04 12:33 | hgbot | Checkin | |
| 2016-07-04 12:33 | hgbot | Note Added: 0088171 | |
| 2016-07-04 12:33 | hgbot | Status | scheduled => resolved |
| 2016-07-04 12:33 | hgbot | Resolution | open => fixed |
| 2016-07-04 12:33 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/d22a3a1dcd903eceaa5b6542d04ac5e7e13df6c9 [^] |
| 2016-07-07 09:18 | NaroaIriarte | Review Assigned To | => alostale |
| 2016-07-08 09:24 | alostale | Note Added: 0088321 | |
| 2016-07-08 09:24 | alostale | Status | resolved => closed |
| 2016-07-08 09:24 | alostale | Fixed in Version | => 3.0PR16Q4 |
| 2016-08-11 18:40 | hudsonbot | Checkin | |
| 2016-08-11 18:40 | hudsonbot | Note Added: 0088984 | |
|
Notes |
|
|
|
The first line that is selected will work (the blur function of its form items will have been replaced by updatedBlur), but the next time a new line is selected, the form items will be recreated but their blur function will not be modified. This results in the client side callouts not working.
This happens only when the productCharacteristics item is visible in the grid. In that case the form items are rebuilt in ListGrid.makeEditForm each time a new line is selected in the P&E window. This happens because when it fails the updateItemsInPlace flag is false, because this condition is not met for the product characteristic field:
this.getEditorType(editField, values) == this._editRowForm.getEditorType(liveItem). For the product characteristic field the left part is OBTextItem and the right part is OBCharacteristicsGridItem
|
|
|
|
|
|
The patch with the fix of the issue has been attached |
|
|
|
(0088171)
|
|
hgbot
|
|
2016-07-04 12:33
|
|
Repository: erp/devel/pi
Changeset: d22a3a1dcd903eceaa5b6542d04ac5e7e13df6c9
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Thu Jun 30 12:53:05 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d22a3a1dcd903eceaa5b6542d04ac5e7e13df6c9 [^]
Fixed issue 33216: The onChange Event didn't work properly
The problem was that the client side callouts were not working properly the second time a record of a pick and edit window was modified in grid view.
The expected behavior is that a value put in one concrete field is copied to another when the first one looses the focus.
The problem was when the productCharacteristics item was present.
In the ob-pick-and-execute-view.js there was a condition wich was setting the
property "readOnlyEditorType" to "OBTextItem" for the fields including the productCharacteristics one.
This was causing the problem afterwards when the check "his.getEditorType(editField, values) != this._editRowForm.getEditorType(liveItem)"
was done in the ListGrid.js because the left part was retrieving "OBTextItem" instead of "OBCharacteristicsGridItem".
This has been fixed by creating this property for the characteristics items. To do so, CharacteristicsGridItem.java has now
a new method which retrieves the value "OBCharacteristicsGridItem". In the ftl now, the property "readOnlyEditorType" is set.
Now the condition of the ob-pick-and-execute-view.js has changed and it checks if there exists the "readOnlyEditorType" property
for the current field. If it exists, it will not do anithing and if not, the property will be set as "OBTextItem" as it was
doing before. Now, the characteristic items will have that property set as "OBCharacteristicsGridItem" and it will work properly.
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-view.js
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/CharacteristicsUIDefinition.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/UIDefinition.java
M modules/org.openbravo.userinterface.smartclient/src/org/openbravo/userinterface/smartclient/templates/smartclient_types_js.ftl
---
|
|
|
|
|
|
|
|
|
|