Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033204Openbravo ERPA. Platformpublic2016-06-09 11:212016-06-17 19:38
Reportercaristu 
Assigned Tocaristu 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q3Fixed in Version3.0PR16Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelPre packaging ( pi )
Regression date2016-04-13
Regression introduced in releasepi
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/4bc26a30e2966fc212fa9b336a9e36f4e1a042c6 [^]
Triggers an Emergency PackNo
Summary0033204: Javascript error appears in console after opening a window with a saved view
DescriptionJavascript error appears in console after opening a window with a saved view.
The error is reproducible when the grid view definition has the filterClause attribute set to true
Steps To Reproduce1) Go to the [Sales Order] window and create a new saved view. Set it as default.
2) Close the window
3) Re-open it again. The following error appears in dev console: "Uncaught TypeError: strValue.replace is not a function"
Proposed SolutionAfter the following changeset[1], the filterClause is a boolean value. But in the following line[2] of ob-view-grid, it still expects a string. The error is thrown when the passed value to OB.Utilities.isNonEmptyString is equal to true.

[1] https://code.openbravo.com/erp/devel/pi/rev/d239cb280bb9 [^]
[2] https://code.openbravo.com/erp/devel/pi/file/ed44288c1e71/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js#l1122 [^]
Additional Information
TagsNo tags attached.
Relationships
related to defect 00328153.0PR16Q3 closed caristu Direct link to documents in the workspace is not working 
related to defect 0025033 closed AugustoMauch Removing the filter show refresh the window if the window was openend with the default filter clause 
caused by feature request 00326103.0PR16Q3 closed NaroaIriarte standard datasources shouldn't accept where parameter by default 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-06-09 11:21caristuNew Issue
2016-06-09 11:21caristuAssigned To => platform
2016-06-09 11:21caristuModules => Core
2016-06-09 11:21caristuRegression level => Pre packaging ( pi )
2016-06-09 11:21caristuRegression date => 2016-04-13
2016-06-09 11:21caristuRegression introduced in release => pi
2016-06-09 11:21caristuRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/4bc26a30e2966fc212fa9b336a9e36f4e1a042c6 [^]
2016-06-09 11:21caristuTriggers an Emergency Pack => No
2016-06-09 11:23caristuRelationship addedcaused by 0032610
2016-06-09 11:27caristuRelationship addedrelated to 0032815
2016-06-09 11:30caristuProposed Solution updated
2016-06-09 11:30caristuProposed Solution updated
2016-06-10 12:43caristuAssigned Toplatform => caristu
2016-06-10 12:43caristuStatusnew => scheduled
2016-06-10 12:44caristuTarget Version => 3.0PR16Q3
2016-06-13 11:34caristuRelationship addedrelated to 0025033
2016-06-13 12:05hgbotCheckin
2016-06-13 12:05hgbotNote Added: 0087195
2016-06-13 12:05hgbotStatusscheduled => resolved
2016-06-13 12:05hgbotResolutionopen => fixed
2016-06-13 12:05hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/36db2944c9926ac8cb35ba6f538d571053ec5f91 [^]
2016-06-13 12:28caristuNote Edited: 0087195bug_revision_view_page.php?bugnote_id=0087195#r12354
2016-06-14 08:42caristuNote Added: 0087221
2016-06-17 08:24alostaleReview Assigned To => alostale
2016-06-17 08:24alostaleNote Added: 0087374
2016-06-17 08:24alostaleStatusresolved => closed
2016-06-17 08:24alostaleFixed in Version => 3.0PR16Q3
2016-06-17 19:38hudsonbotCheckin
2016-06-17 19:38hudsonbotNote Added: 0087607

Notes
(0087195)
hgbot   
2016-06-13 12:05   
(edited on: 2016-06-13 12:28)
Repository: erp/devel/pi
Changeset: 36db2944c9926ac8cb35ba6f538d571053ec5f91
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Jun 13 12:04:17 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/36db2944c9926ac8cb35ba6f538d571053ec5f91 [^]

fixes issue 33204: Javascript error after opening a window with a saved view
Since this changeset[1], filterClause is no longer a string but a boolean. So the check done on the setViewState method of ob-view-grid has been fixed accordingly

[1] https://code.openbravo.com/erp/devel/pi/rev/4bc26a30e2966fc212fa9b336a9e36f4e1a042c6 [^]

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0087221)
caristu   
2016-06-14 08:42   
TestLink: https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-10033 [^]
(0087374)
alostale   
2016-06-17 08:24   
code reviewed + tested
(0087607)
hudsonbot   
2016-06-17 19:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test