Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033193Openbravo ERP09. Financial managementpublic2016-06-08 13:492016-06-21 14:48
Reportermaite 
Assigned ToSanjota 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q3Fixed in Version3.0PR16Q3 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket42319
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033193: Not possible to run Balance Sheet or P&L defined for Generic organization
DescriptionOrganization combo appears empty when report chosen is defined for Generic organization. Wiki's information states that "If the organization selected is a Generic organization which belongs to a Legal with Accounting one, the financial information provided by the reports will be just the financial information of that organization."
Steps To Reproduce0. Follow configuration guide and create Balance Sheet report for "España norte" organization:
http://wiki.openbravo.com/wiki/Balance_sheet_and_P%26L_structure_Setup#Balance_Sheet_structure_setup_example [^]
1. Access "Balance Sheet and P&L structure" window and select report just created. Realize that organization combo does not show any value
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-06-08 13:49maiteNew Issue
2016-06-08 13:49maiteAssigned To => Triage Finance
2016-06-08 13:49maiteOBNetwork customer => Yes
2016-06-08 13:49maiteModules => Core
2016-06-08 13:49maiteSupport ticket => 42319
2016-06-08 13:49maiteResolution time => 1467064800
2016-06-08 13:49maiteTriggers an Emergency Pack => No
2016-06-08 13:49maiteIssue Monitored: networkb
2016-06-09 13:49aferrazAssigned ToTriage Finance => markmm82
2016-06-13 17:49SanjotaAssigned Tomarkmm82 => Sanjota
2016-06-13 17:49SanjotaStatusnew => scheduled
2016-06-14 11:25psanjuanNote Added: 0087240
2016-06-14 11:59psanjuanNote Edited: 0087240bug_revision_view_page.php?bugnote_id=0087240#r12367
2016-06-14 12:04psanjuanNote Edited: 0087240bug_revision_view_page.php?bugnote_id=0087240#r12369
2016-06-14 12:10psanjuanNote Edited: 0087240bug_revision_view_page.php?bugnote_id=0087240#r12370
2016-06-15 15:05SanjotaNote Added: 0087307
2016-06-16 15:44psanjuanNote Added: 0087354
2016-06-17 10:18psanjuanNote Edited: 0087354bug_revision_view_page.php?bugnote_id=0087354#r12407
2016-06-17 10:31psanjuanNote Edited: 0087354bug_revision_view_page.php?bugnote_id=0087354#r12409
2016-06-17 10:45psanjuanNote Edited: 0087354bug_revision_view_page.php?bugnote_id=0087354#r12410
2016-06-17 10:55psanjuanNote Edited: 0087307bug_revision_view_page.php?bugnote_id=0087307#r12412
2016-06-17 10:58psanjuanNote Edited: 0087307bug_revision_view_page.php?bugnote_id=0087307#r12413
2016-06-17 11:01psanjuanNote Edited: 0087307bug_revision_view_page.php?bugnote_id=0087307#r12414
2016-06-17 11:03psanjuanNote Edited: 0087354bug_revision_view_page.php?bugnote_id=0087354#r12415
2016-06-17 11:07psanjuanNote Added: 0087385
2016-06-17 11:08psanjuanNote Added: 0087386
2016-06-17 14:25hgbotCheckin
2016-06-17 14:25hgbotNote Added: 0087399
2016-06-17 14:25hgbotStatusscheduled => resolved
2016-06-17 14:25hgbotResolutionopen => fixed
2016-06-17 14:25hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/3383c34486c2acbe060839cc2646ab753796d7aa [^]
2016-06-17 14:26aferrazReview Assigned To => aferraz
2016-06-17 14:26aferrazNote Added: 0087400
2016-06-17 14:26aferrazStatusresolved => closed
2016-06-17 14:26aferrazFixed in Version => 3.0PR16Q3
2016-06-21 14:48hudsonbotCheckin
2016-06-21 14:48hudsonbotNote Added: 0087725

Notes
(0087240)
psanjuan   
2016-06-14 11:25   
(edited on: 2016-06-14 12:10)
Issue verified as:

Go to Balance Sheet and P&L Structure setup window.
Create a new one for "F&B España - Region Norte" Organization with below setup:
Name = Balance - Region Norte
Report type = Point in Time
Balanced = No
Go to "Grouping category" tab and "Node" tab and create same set up as the one created for "Balance de Situación".

Go to Balance Sheet and P&L Structure window. Select below values:
General Ledger = F&B España US/A/Euro
Accounting Report = Balance - Region Norte
Organization = check that this field is empty and that should not be the case. It should be possible to select "F&B España - Región Norte", as "Balanced" check is set to = NO.

Note that "Balanced" setup check in combination with a "Point in Time" report, forces that only "legal with accounting" and "business unit" organization type are shown for that type of reports (Balance) in the "Organization" combo of "Balance Sheet and P&L structure" window.

If "Balanced" setup check is not selected for a "Point in Time" report (Balance), other type of organization rather than Legal with accounting can then be shown in the "Organization" combo of "Balance Sheet and P&L structure" window.

Check why this behavior has changed, as it seems to be a regression.
(0087307)
Sanjota   
2016-06-15 15:05   
(edited on: 2016-06-17 11:01)
Test Plan:
Go to Balance Sheet and P&L Structure setup window.
Create a new one for "F&B España - Region Norte" Organization with below setup:
Name = Balance - Region Norte
Report type = Point in Time
Balanced = No
Go to "Grouping category" tab and "Node" tab and create same set up as the one created for "Balance de Situación".

Go to Balance Sheet and P&L Structure window. Select below values:
General Ledger = F&B España US/A/Euro
Accounting Report = Balance - Region Norte
Organization = check that the Organization combo shows F&B España Region Norte and all the parents organizations of that one related to this general ledger: *, F&B International Group and F&B España.


Similarly
Go to Balance Sheet and P&L Structure setup window.
Create a new one for "F&B España - Region Norte" Organization with below setup:
Name = Balance - Region Norte
Report type = Point in Time
Balanced = Yes
Go to "Grouping category" tab and "Node" tab and create same set up as the one created for "Balance de Situación".

Go to Balance Sheet and P&L Structure window. Select below values:
General Ledger = F&B España US/A/Euro
Accounting Report = Balance - Region Norte
Organization = check that no organization is shown as F&B España Region Norte is not a legal entity with accounting either a business unit.


Repeat same test for General Ledger = F&B International Group Dollar. Check that same results are shown.

Note: This confirms,
For any report setup
a) If the balanced='true' then get Business units or Legal Entity in Org combo of the report
b) If the balanced='false' then get all organizations in Org combo of the report.
(0087354)
psanjuan   
2016-06-16 15:44   
(edited on: 2016-06-17 11:03)
Test Plan:

Go to Balance Sheet and P&L Structure setup.
Verify that there are two types of reports setup there.

Balance related ones are setup as:
Point in time
Balanced = Yes

P&L related ones are setup as:
Periodic
Balanced = No.

Go to Balance Sheet and P&L Structure. Select Dollar General ledger and "Balance Sheet" accounting report:
- Verify that only Legal with Accounting org are shown, together with Summary Organization: F&B Inter, F&B US and F&B España

Go to Balance Sheet and P&L Structure. Select Euro General Ledger an "Balance Sheet" accounting report:
- Verify that only Legal with Accounting org are shown, together with Summary Organization: F&B Inter and F&B España

Go to Balance Sheet and P&L Structure. Select Dollar General Ledger an "Profit & Loss" accounting report:
- Verify that all organizations are shown.

Go to Balance Sheet and P&L Structure. Select Euro Ledger an "Perdidas y Ganancias" accounting report:
- Verify that all organization related to that general ledger are shown: F&B International, F&B España, F&B España Norte, F&B España Sur, *.
(0087385)
psanjuan   
2016-06-17 11:07   
Test Plan:

Go to Balance Sheet and P&L structure setup.

Create a new one for F&B España Region Norte with below setup:
Name = PYG Norte
General Ledger = F&B España Euro
Report Type = Periodic
Balanced = No.

Go to Balance Sheet and P&L structure window and select PYG Norte report.
Check that Organization combo shows below org: *, F&B Intern, F&B España, F&B España Region Norte.

Go to Balance Sheet and P&L structure setup window and change PYG Norte as Balanced = Yes.

Go to Balance Sheet and P&L structure window and select PYG Norte report.
Check that no Organization is shown in "Organization" combo box.
(0087386)
psanjuan   
2016-06-17 11:08   
Test Plan above verified. Issue can be closed.
(0087399)
hgbot   
2016-06-17 14:25   
Repository: erp/devel/pi
Changeset: 3383c34486c2acbe060839cc2646ab753796d7aa
Author: Sanjota <sanjota.nelagi <at> promantia.com>
Date: Wed Jun 15 18:26:36 2016 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/3383c34486c2acbe060839cc2646ab753796d7aa [^]

Fixes issue 33193: Failed to run Balance Sheet defined for Generic organization

Changes been done for Balance sheet report. i.e
a) If the balanced='true' then get Business units or Legal Entity in Org combo
b) If the balanced='false' then get all organizations in Org combo.

---
M src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReports_data.xsql
---
(0087400)
aferraz   
2016-06-17 14:26   
Code review OK
(0087725)
hudsonbot   
2016-06-21 14:48   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7f9896fd81e9 [^]
Maturity status: Test