Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033177Retail ModulesWeb POSpublic2016-06-07 18:072016-06-23 11:39
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q3Fixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033177: Connection retry should not happen if the other server responds even with offline status
DescriptionThe MobileServerRequestExecutor retries a request if the other server responds with an offline status:
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/89ae499ba562/src/org/openbravo/mobile/core/servercontroller/MobileServerRequestExecutor.java#l127 [^]

However, the logic should change. If the other server reports offline we can assume that it is reachable and should return the response.

Steps To ReproduceCreate multi server environment
Set all multi-server prefs and schedule server state process to run every 30 secs
Start store and central
Stop central
Store goes offline
Start central
Schedule a process on the store while it is still offline: notice that the request is tried 3 times and no response is return.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-06-07 18:07mtaalNew Issue
2016-06-07 18:07mtaalAssigned To => mtaal
2016-06-07 18:07mtaalTriggers an Emergency Pack => No
2016-06-08 23:12hgbotCheckin
2016-06-08 23:12hgbotNote Added: 0087107
2016-06-08 23:12hgbotStatusnew => resolved
2016-06-08 23:12hgbotResolutionopen => fixed
2016-06-08 23:12hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4d876100807cfb2f55f5c6d952fc5a6826221042 [^]
2016-06-20 16:21mtaalReview Assigned To => migueldejuana
2016-06-23 11:39migueldejuanaNote Added: 0087849
2016-06-23 11:39migueldejuanaStatusresolved => closed

Notes
(0087107)
hgbot   
2016-06-08 23:12   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 4d876100807cfb2f55f5c6d952fc5a6826221042
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Jun 08 23:11:38 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4d876100807cfb2f55f5c6d952fc5a6826221042 [^]

Fixes issue 33177: Connection retry should not happen if the other server responds even with offline status
Change the retry connection flow to just return value

---
M src/org/openbravo/mobile/core/servercontroller/MobileServerController.java
M src/org/openbravo/mobile/core/servercontroller/MobileServerRequestExecutor.java
---
(0087849)
migueldejuana   
2016-06-23 11:39   
Tested and reviewed