Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033174Retail ModulesWeb POSpublic2016-06-07 17:552016-06-24 14:58
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q3Fixed in Version 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033174: Trigger state flag should not be visible or used for store servers
DescriptionThe trigger state flag in the mobile server definition should not be used/checked in case of a store server.

If this happens then we can get cycles in the offline/online triggering and no server can go online.
Steps To ReproduceDefine a store and central server.
Initiate the store server check process request
Stop the store server.
The central server will go offline
Start the store sever.
The store server will never go online.
The central server will never go online.
Proposed SolutionOnly use triggerstate from main servers and not from store servers.
Hide the trigger state field for store servers.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-06-07 17:55mtaalNew Issue
2016-06-07 17:55mtaalAssigned To => mtaal
2016-06-07 17:55mtaalTriggers an Emergency Pack => No
2016-06-07 17:55mtaalTypedefect => design defect
2016-06-08 23:12hgbotCheckin
2016-06-08 23:12hgbotNote Added: 0087104
2016-06-08 23:12hgbotCheckin
2016-06-08 23:12hgbotNote Added: 0087105
2016-06-08 23:12hgbotStatusnew => resolved
2016-06-08 23:12hgbotResolutionopen => fixed
2016-06-08 23:12hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/3ebabbcf5f0db8bfa82843300c57cc0d3a029b27 [^]
2016-06-20 16:20mtaalReview Assigned To => AugustoMauch
2016-06-24 14:58AugustoMauchNote Added: 0087910
2016-06-24 14:58AugustoMauchStatusresolved => closed

Notes
(0087104)
hgbot   
2016-06-08 23:12   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: f58c4c7867d66e264cbdc1d7b6498867f00d34c4
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Jun 08 23:05:55 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/f58c4c7867d66e264cbdc1d7b6498867f00d34c4 [^]

Related to issue 33174: Trigger state flag should not be visible or used for store servers
Hide the trigger state field in case of store server

---
M src-db/database/sourcedata/AD_FIELD.xml
---
(0087105)
hgbot   
2016-06-08 23:12   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 3ebabbcf5f0db8bfa82843300c57cc0d3a029b27
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Jun 08 23:09:21 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/3ebabbcf5f0db8bfa82843300c57cc0d3a029b27 [^]

Fixes issue 33174: Trigger state flag should not be visible or used for store servers
Use is trigger state utils method which checks the istriggerstate flag and also that the server is not a store server

---
M src/org/openbravo/mobile/core/servercontroller/MobileMainServerCheck.java
M src/org/openbravo/mobile/core/servercontroller/MobileServerUtils.java
M src/org/openbravo/mobile/core/servercontroller/ServerStateBackground.java
---
(0087910)
AugustoMauch   
2016-06-24 14:58   
Code reviewed and verified in [1]@c25bf7094080

[1] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/ [^]