Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033169Openbravo ERP04. Warehouse managementpublic2016-06-07 13:522016-06-17 19:38
Reporterngarcia 
Assigned Tomarkmm82 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q3 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033169: Backdated Transaction adjustments are made for the same day when movementdate column of M_TRANSACTION is defined with hours
DescriptionBackdated Transaction adjustments are made for the same day when movementdate column of M_TRANSACTION is defined with hours. Movementdate could be defined with hours in the following functions:

- ReservedGoodMovementActionHandler.doExecute
- OutboundPickingListProcess.createShipment
...
Steps To ReproduceNote: you should have the costing rule validated with Fix Backdated From before today's date

As group admin role:
   Create a new product add a purchase price list to it
   Create a Goods Receipt with today's date and add the previously created product
   Create a Stock Reservation of that product
   Create Goods Movement from Stock Reservation window
   Check through database the m_transaction records associated with the movement have the movement without being truncated
   Create a new Goods Receipt for that product
   Launch the Costing Background Process and check a new Cost Adjustment has been created (Backdated Transaction) when it should not
Proposed SolutionTruncate MaterialTransaction.PROPERTY_MOVEMENTDATE in CostAdjustmentUtils.isNeededBackdatedCostAdjustment method.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-06-07 13:52ngarciaNew Issue
2016-06-07 13:52ngarciaAssigned To => Triage Finance
2016-06-07 13:52ngarciaModules => Core
2016-06-07 13:52ngarciaResolution time => 1467064800
2016-06-07 13:52ngarciaTriggers an Emergency Pack => No
2016-06-07 14:02ngarciaIssue Monitored: networkb
2016-06-07 18:40aferrazAssigned ToTriage Finance => markmm82
2016-06-13 18:28markmm82Statusnew => scheduled
2016-06-13 19:02aferrazProposed Solution updated
2016-06-13 20:38markmm82Note Added: 0087216
2016-06-14 16:13tegik_forgeIssue Monitored: tegik_forge
2016-06-16 19:45hgbotCheckin
2016-06-16 19:45hgbotNote Added: 0087368
2016-06-16 19:45hgbotStatusscheduled => resolved
2016-06-16 19:45hgbotResolutionopen => fixed
2016-06-16 19:45hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d7f6528030743c9207acf0b7c660bf43c9eebedc [^]
2016-06-16 19:45aferrazReview Assigned To => aferraz
2016-06-16 19:45aferrazNote Added: 0087369
2016-06-16 19:45aferrazStatusresolved => closed
2016-06-16 19:45aferrazFixed in Version => 3.0PR16Q3
2016-06-17 19:38hudsonbotCheckin
2016-06-17 19:38hudsonbotNote Added: 0087634

Notes
(0087216)
markmm82   
2016-06-13 20:38   
Test Plan:
As group admin role:
   Create a new product
    Add a purchase price list to it
   Create a Goods Receipt with today's date
    Add a line with the previously created product
   Create a Stock Reservation of that product
    Manage Stock for it
       Create Goods Movement from Stock Reservation window
   Check through database the m_transaction records associated with the movement have the movement without being truncated
   Create a new Goods Receipt
    Add a line with the previously created product
   Launch the Costing Background Process
    Check that NO new Cost Adjustment has been created. It is correct!
(0087368)
hgbot   
2016-06-16 19:45   
Repository: erp/devel/pi
Changeset: d7f6528030743c9207acf0b7c660bf43c9eebedc
Author: Mark <markmm82 <at> gmail.com>
Date: Mon Jun 13 14:16:47 2016 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/d7f6528030743c9207acf0b7c660bf43c9eebedc [^]

Fixes issue 33169: Fix Backdated Transaction when movementdate has hours

Was truncated the movementdate column of M_TRANSACTION, allowing to the CostAdjustmentUtils class calculates correctly if the given Material Transaction is a backdated transaction or not.

---
M src/org/openbravo/costing/CostAdjustmentUtils.java
---
(0087369)
aferraz   
2016-06-16 19:45   
Code review + Testing OK
(0087634)
hudsonbot   
2016-06-17 19:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test