Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033149Retail ModulesWeb POSpublic2016-06-06 11:282016-06-23 13:37
Reportermigueldejuana 
Assigned Tomigueldejuana 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression levelQA functional test
Regression date2016-01-20
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/ca558e1f022db5b8d049ec36a2029b1bc21ba122 [^]
Triggers an Emergency PackNo
Summary0033149: It is possible to add twice the same verified return partially to the order when the maximum quantity is reached
DescriptionIt is possible to add twice the same verified return partially to the order when the maximum quantity is reached.


You can add partially a verified return, process it. Load again same verified return and if you try to add it again partially more than remaining qty WebPOS allow you to do it.
Steps To ReproduceComplete an order with 6 Avalanche Transceivers
Go to Verify Returns popup
Search that order
Add 4 Avalanche Transceivers
Process the order

Go to Verify Returns popup
Add 2 Avalanche Transceivers
Click OK button
Go to Verify Returns popup again
Add 2 Avalanche Transceivers
It should give an error
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0033150RR16Q2 closed ranjith_qualiantech_com It is possible to add twice the same verified return partially to the order when the maximum quantity is reached 
depends on backport 0033151RR16Q1.3 closed ranjith_qualiantech_com It is possible to add twice the same verified return partially to the order when the maximum quantity is reached 
depends on backport 0033152RR15Q4.7 closed ranjith_qualiantech_com It is possible to add twice the same verified return partially to the order when the maximum quantity is reached 
caused by defect 0031877 closed migueldejuana It is not possible to add twice the same verified return partially to the order when the maximum quantity is not reached 
causes defect 0033274 closed migueldejuana If you create a verified returns with an orderline that has 2 shipments it picks the wrong qty 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-06-06 11:28migueldejuanaNew Issue
2016-06-06 11:28migueldejuanaAssigned To => ranjith_qualiantech_com
2016-06-06 11:28migueldejuanaTriggers an Emergency Pack => No
2016-06-06 11:28migueldejuanaStatusnew => scheduled
2016-06-06 11:30migueldejuanaRegression level => QA functional test
2016-06-06 11:30migueldejuanaRegression date => 2016-01-20
2016-06-06 11:30migueldejuanaRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/ca558e1f022db5b8d049ec36a2029b1bc21ba122 [^]
2016-06-06 16:08hgbotCheckin
2016-06-06 16:08hgbotNote Added: 0087036
2016-06-06 16:08hgbotCheckin
2016-06-06 16:08hgbotNote Added: 0087037
2016-06-06 16:08hgbotStatusscheduled => resolved
2016-06-06 16:08hgbotResolutionopen => fixed
2016-06-06 16:08hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/404e800a91154eea4e0519afb65f9e476a49ef34 [^]
2016-06-06 19:25marvintmReview Assigned To => marvintm
2016-06-06 19:25marvintmStatusresolved => closed
2016-06-15 13:08guillermogilRelationship addedcauses 0033274
2016-06-15 13:38dmitry_mezentsevRelationship addedcaused by 0031877
2016-06-16 14:56hgbotCheckin
2016-06-16 14:56hgbotNote Added: 0087345
2016-06-20 09:49migueldejuanaAssigned Toranjith_qualiantech_com => migueldejuana
2016-06-20 09:49migueldejuanaNote Added: 0087648
2016-06-20 09:49migueldejuanaStatusclosed => new
2016-06-20 09:49migueldejuanaResolutionfixed => open
2016-06-20 09:49migueldejuanaStatusnew => scheduled
2016-06-20 09:50migueldejuanaNote Added: 0087649
2016-06-20 09:50migueldejuanaStatusscheduled => resolved
2016-06-20 09:50migueldejuanaResolutionopen => fixed
2016-06-21 15:42hgbotCheckin
2016-06-21 15:42hgbotNote Added: 0087730
2016-06-21 16:45hgbotCheckin
2016-06-21 16:45hgbotNote Added: 0087737
2016-06-23 13:37marvintmStatusresolved => closed

Notes
(0087036)
hgbot   
2016-06-06 16:08   
Repository: tools/automation/pi-mobile
Changeset: 6bc360266418929e253b0c23a0ae11f573e12734
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jun 06 19:37:27 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/6bc360266418929e253b0c23a0ae11f573e12734 [^]

Verifies issue 33149 : Added automated test 'I33149_VerifyReturnQtyWithTotalQty'

---
A src-test/org/openbravo/test/mobile/quarantine/pack/RAN/returns/I33149_VerifyReturnQtyWithTotalQty.java
---
(0087037)
hgbot   
2016-06-06 16:08   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: 404e800a91154eea4e0519afb65f9e476a49ef34
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jun 06 19:20:16 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/404e800a91154eea4e0519afb65f9e476a49ef34 [^]

Fixes issue 33149 : Replacing remaining qty with return quantity

- backout changeset : ca558e1f022d
- Replaced OB Error with Popup Msg

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---
(0087345)
hgbot   
2016-06-16 14:56   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: b5011305fa67b817b9614c05ec2733e44428177d
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Jun 16 07:42:47 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/b5011305fa67b817b9614c05ec2733e44428177d [^]

Related to issue 33149 : Replacing remaining qty with return quantity.

- Backout 404e800a9115
- Solve regressions chain with one fix

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---
(0087648)
migueldejuana   
2016-06-20 09:49   
Backout and fix regression avoiding creating more issues
(0087649)
migueldejuana   
2016-06-20 09:50   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: 2aef76e761868a6e58b9c89fdb5b51522e6d59a4
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Jun 16 09:46:26 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/2aef76e761868a6e58b9c89fdb5b51522e6d59a4 [^] [^] [^]

Fixed issue 0030816: It is possible to return the same ticket more than once

- Check all open orders when adding a verified return line to the ticket
- If we exceed the qty available to return the line is not added
- Manage correctly remaining qty, initial qty and selected qty

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---

Repository: erp/pmods/org.openbravo.retail.returns
Changeset: 5c1446007fc8dd4339071363c1782db4347cec7e
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Jun 16 11:21:47 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/5c1446007fc8dd4339071363c1782db4347cec7e [^] [^] [^]

Fixed issue 0030816: It is possible to return the same ticket more than once

- Cover also lines with item in differents bins

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---
(0087730)
hgbot   
2016-06-21 15:42   
Repository: retail/backports/3.0RR16Q1.4/org.openbravo.retail.returns
Changeset: 449e95036410331e9010e2807d5595abcb329317
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Jun 21 15:18:49 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q1.4/org.openbravo.retail.returns/rev/449e95036410331e9010e2807d5595abcb329317 [^]

Related to issue 33149 : Replacing remaining qty with return quantity.

- Backout 404e800a9115
- Solve regressions chain with one fix

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---
(0087737)
hgbot   
2016-06-21 16:45   
Repository: retail/backports/3.0RR16Q2.1/org.openbravo.retail.returns
Changeset: 552672cfa15cc1bffd4340ae9981470c8b8eb738
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Jun 16 07:42:47 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q2.1/org.openbravo.retail.returns/rev/552672cfa15cc1bffd4340ae9981470c8b8eb738 [^]

Related to issue 33149 : Replacing remaining qty with return quantity.

- Backout 404e800a9115
- Solve regressions chain with one fix

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---