0033129: unneeded object initialization for DAL insertion

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0033129

Openbravo ERP

A. Platform

public

2016-06-03 11:14

2016-06-17 19:38

Reporter

alostale

Assigned To

alostale

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

3.0PR16Q3

Merge Request Status

Review Assigned To

caristu

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0033129: unneeded object initialization for DAL insertion

Description

The first time a new DAL object is saved per transaction (typically per request). Some unneeded DAL objects are initialized. This has a performance impact because:

1. Additional DB queries are executed
2. Some heap is consumed for those DAL objects. If the request processing is fast, they are quickly made electable for garbage collection, but in any case this makes GC to be invoked more often than needed.

Steps To Reproduce

0. Copy the following code somewhere executable (ie. in About.java):

    for (int i = 0; i < 10; i++) {
      AlertRule newAlert = OBProvider.getInstance().get(AlertRule.class);
      newAlert.setName(Long.toString(System.currentTimeMillis()));
      OBDal.getInstance().save(newAlert);
    }

1. set HQL to bebug
2. Execute it and check the log

9169004 [http-8080-3] DEBUG org.hibernate.SQL - select ... from AD_Client adclient0_ where adclient0_.AD_Client_ID=?

9169005 [http-8080-3] DEBUG org.hibernate.SQL - select ... from AD_Language adlanguage0_ where adlanguage0_.AD_Language=?

9169005 [http-8080-3] DEBUG org.hibernate.SQL - select ... from AD_Org organizati0_ where organizati0_.AD_Org_ID=?

9169006 [http-8080-3] DEBUG org.hibernate.SQL - select ... from AD_User aduser0_ where aduser0_.AD_User_ID 
in (?, ?)

9172172 [http-8080-3] DEBUG org.hibernate.SQL - insert into AD_AlertRule ...
9172173 [http-8080-3] DEBUG org.hibernate.SQL - insert into AD_AlertRule ...
9172173 [http-8080-3] DEBUG org.hibernate.SQL - insert into AD_AlertRule ...
9172173 [http-8080-3] DEBUG org.hibernate.SQL - insert into AD_AlertRule ...
9172173 [http-8080-3] DEBUG org.hibernate.SQL - insert into AD_AlertRule ...
9172173 [http-8080-3] DEBUG org.hibernate.SQL - insert into AD_AlertRule ...
9172173 [http-8080-3] DEBUG org.hibernate.SQL - insert into AD_AlertRule ...
9172173 [http-8080-3] DEBUG org.hibernate.SQL - insert into AD_AlertRule ...
9172173 [http-8080-3] DEBUG org.hibernate.SQL - insert into AD_AlertRule ...
9172173 [http-8080-3] DEBUG org.hibernate.SQL - insert into AD_AlertRule ...

First 4 queries are unnecessary, they are executed to instantiate client, org and user DAL objects.

Proposed Solution

Use Hibernate proxies for these objects so they don't need to be initialized.

Additional Information