Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0033125 | Openbravo ERP | 09. Financial management | public | 2016-06-02 18:52 | 2016-06-02 18:52 |
|
| Reporter | shuehner | |
| Assigned To | Triage Omni OMS | |
| Priority | normal | Severity | trivial | Reproducibility | have not tried |
| Status | new | Resolution | open | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | No |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0033125: Minor cleanup in AdvPaymentMngtDao.getFinancialAccountPaymentMethod to simplify code |
| Description | Small clean up + maybe style improvement
That function add an extra isActive filter even is same is auto-added by dal filtering (at sql level) twice of isActive true.
Also i has a slightly strange way to get for 'rows found' via capturing IndexOutOfBoundsException instead of a simple != null
(end of ) SQL run for the function:
ticurrency as Payin29_266_0_, this_.Payout_IsMulticurrency as Payout30_266_0_, this_.Isdefault as Isdefault266_0_, this_.Payin_Invoicepaidstatus as Payin32_266_0_, this_.Payout_Invoicepaidstatus as Payout33_266_0_ from FIN_FinAcc_PaymentMethod this_ where this_.FIN_Financial_Account_ID=$1 and this_.FIN_Paymentmethod_ID=$2 and this_.Isactive=$3 and this_.Isactive=$4
parameters: $1 = 'DC15B7D80B3A4C6D80D0558A2EC5922D', $2 = '29F862983F3B45739C1507E416123129', $3 = 'Y', $4 = 'Y'
notice the double isactive filter mentioned above |
| Steps To Reproduce | - |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  33125.diff (1,421) 2016-06-02 18:52
https://issues.openbravo.com/file_download.php?file_id=9477&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2016-06-02 18:52 | shuehner | New Issue | |
| 2016-06-02 18:52 | shuehner | Assigned To | => Triage Finance |
| 2016-06-02 18:52 | shuehner | OBNetwork customer | => No |
| 2016-06-02 18:52 | shuehner | Modules | => Core |
| 2016-06-02 18:52 | shuehner | Triggers an Emergency Pack | => No |
| 2016-06-02 18:52 | shuehner | File Added: 33125.diff | |
| 2016-06-02 18:52 | shuehner | Note Added: 0086957 | |