Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0033082Openbravo ERPZ. Otherspublic2016-05-31 11:272016-06-17 19:38
maite 
AtulOpenbravo 
urgentmajoralways
closedfixed 
5
 
3.0PR16Q33.0PR16Q3 
aferraz
Advanced Payables and Receivables Mngmt
No
0033082: Payment Schedule Detail duplicated when using "Modify Payment Plan" process under certain circumstances
Payment schedule detail is duplicated when "Modify Payment Plan" process is run from a partial payment plan record which has payment in Void status
0. As system administrator, access to "Windows, tabs and fields" and go to Sales Invoice window | Payment Plan tab to set "Modify payment plan" field as DISPLAYED. Logout/login
1. Access Payment Terms window and configure new record as "Overdue Payment Days Rule"=30 in Header. Add Line with "Percentage due"=30 and "Overdue Payment Days Rule"=15
2. Register Sales invoice for España org using this payment terms. Add any line and process invoice
3. Access Financial Account "Cuenta de banco", go to Payment Method tab and set "Transferencia" payment method as "Automatic", "Simple exec process" and "Deferred=YES"
4. From invoice header, run "Add Payment" process. Select only first payment plan record and process
5. Navigate to created Payment In document, which should be in "Awaiting Exec" status. Click on "Reactivate" button and select VOID action. Realize that payment is correct and it only has one detail related
6. Access Sales Invoice and go to Payment Plan tab. Run "Modify Payment Plan" process from previous record and change Payment Method info to "Cheque". Process
7. Access again to previous Payment In record, refresh document and realize that it has 2 details, which is not correct
8. Access Sales Invoice and go to Payment Plan tab, select second line, the one that still has Transferencia as Payment Method. Check that it has a payment detail and that is not correct. (Received Amount = 30 and Amount = 70, related to payment in (1000513).
9. Run Modify Payment Plan for this second payment plan line, change it to Cheque. Press Submit. Refresh. Check that now this payment plan has two payment details lines which is not correct.
No tags attached.
related to defect 0033260 closed Triage Omni OMS Error message shown in Modify Payment Plan after changing Payment Method field 
Issue History
2016-05-31 11:27maiteNew Issue
2016-05-31 11:27maiteAssigned To => Triage Finance
2016-05-31 11:27maiteModules => Advanced Payables and Receivables Mngmt
2016-05-31 11:27maiteResolution time => 1465855200
2016-05-31 11:27maiteTriggers an Emergency Pack => No
2016-05-31 11:27maiteIssue Monitored: networkb
2016-05-31 11:27maiteTarget Version => 3.0PR16Q3
2016-05-31 11:37heccamIssue Monitored: heccam
2016-05-31 13:13aferrazAssigned ToTriage Finance => AtulOpenbravo
2016-06-06 11:11AtulOpenbravoStatusnew => scheduled
2016-06-08 08:47AtulOpenbravoNote Added: 0087081
2016-06-14 13:08psanjuanNote Edited: 0087081bug_revision_view_page.php?bugnote_id=0087081#r12372
2016-06-14 13:13psanjuanNote Added: 0087251
2016-06-14 13:25psanjuanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=12374#r12374
2016-06-14 13:26psanjuanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=12375#r12375
2016-06-14 14:00psanjuanNote Added: 0087254
2016-06-14 14:00psanjuanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=12376#r12376
2016-06-14 14:11psanjuanNote Edited: 0087254bug_revision_view_page.php?bugnote_id=0087254#r12378
2016-06-14 14:14psanjuanNote Edited: 0087254bug_revision_view_page.php?bugnote_id=0087254#r12379
2016-06-14 15:24psanjuanNote Edited: 0087254bug_revision_view_page.php?bugnote_id=0087254#r12380
2016-06-14 15:28psanjuanRelationship addedrelated to 0033260
2016-06-14 15:28psanjuanNote Edited: 0087254bug_revision_view_page.php?bugnote_id=0087254#r12381
2016-06-15 10:08psanjuanNote Edited: 0087254bug_revision_view_page.php?bugnote_id=0087254#r12391
2016-06-15 10:08psanjuanNote Added: 0087289
2016-06-15 14:23hgbotCheckin
2016-06-15 14:23hgbotNote Added: 0087303
2016-06-15 14:23hgbotStatusscheduled => resolved
2016-06-15 14:23hgbotResolutionopen => fixed
2016-06-15 14:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/16b9d36614a8ca6269c942ab40778e89a8b5dbfd [^]
2016-06-15 14:23hgbotCheckin
2016-06-15 14:23hgbotNote Added: 0087304
2016-06-15 14:27hgbotCheckin
2016-06-15 14:27hgbotNote Added: 0087305
2016-06-15 14:28aferrazReview Assigned To => aferraz
2016-06-15 14:28aferrazNote Added: 0087306
2016-06-15 14:28aferrazStatusresolved => closed
2016-06-15 14:28aferrazFixed in Version => 3.0PR16Q3
2016-06-17 19:38hudsonbotCheckin
2016-06-17 19:38hudsonbotNote Added: 0087620
2016-06-17 19:38hudsonbotCheckin
2016-06-17 19:38hudsonbotNote Added: 0087621
2016-06-17 19:38hudsonbotCheckin
2016-06-17 19:38hudsonbotNote Added: 0087622

Notes
(0087081)
AtulOpenbravo   
2016-06-08 08:47   
(edited on: 2016-06-14 13:08)
Test Plan

- As system administrator, access to "Windows, tabs and fields" and go to Sales Invoice window | Payment Plan tab to set "Modify payment plan" field as DISPLAYED. Logout/login.
- Access Payment Terms window and configure new record as "Overdue Payment Days Rule"=30 in Header. Add Line with "Percentage due"=30 and "Overdue Payment Days Rule"=15.
- Register Sales invoice for España org using this payment terms. Add any line and process invoice.
- Go to payment plan tab and check that there are two payment plan lines, first one with an expected date 15 days after invoice date for a 30% of the total gross amount of the invoice.
- Access Financial Account "Cuenta de banco", go to Payment Method tab and set "Transferencia" payment method as "Automatic", "Simple exec process" and "Deferred=YES".
- From invoice header, run "Add Payment" process. Select only first payment plan record and process.
- Navigate to created Payment In document, which should be in "Awaiting Exec" status. Click on "Reactivate" button and select VOID action. Realize that payment is correct and it only has one detail related
- Access Sales Invoice and go to Payment Plan tab. Run "Modify Payment Plan" process from previous record and change Payment Method info to "Cheque". Process.
- Access again to previous Payment In record, refresh document and check that it has only 1 detail, which is correct.

(0087251)
psanjuan   
2016-06-14 13:13   
Issue verified.
(0087254)
psanjuan   
2016-06-14 14:00   
(edited on: 2016-06-15 10:08)
Test Plan

- As system administrator, access to "Windows, tabs and fields" and go to Sales Invoice window | Payment Plan tab to set "Modify payment plan" field as DISPLAYED. Logout/login.
Cheque
- Access Payment Terms window and configure new record as "Overdue Payment Days Rule"=30 in Header. Add Line with "Percentage due"=30 and "Overdue Payment Days Rule"=15.

- Register Sales invoice for F&B España org using this payment terms. Add any line and process invoice.

- Go to payment plan tab and check that there are two payment plan lines, first one with an expected date 15 days after invoice date for a 30% of the total gross amount of the invoice, for instance 30.00 (total gross amount 100.00).

- Access Financial Account "Cuenta de banco", go to Payment Method tab and set "Transferencia" payment method as "Automatic", "Simple exec process" and "Deferred=YES".

- From invoice header, run "Add Payment" process. Select only first payment plan record and process.

- Navigate to created Payment In document, which should be in "Awaiting Exec" status. Click on "Reactivate" button and select VOID action. Realize that payment is correct and it only has one detail related.

- Access Sales Invoice and go to Payment Plan tab. Run "Modify Payment Plan" process from previous record and change Payment Method info to "Cheque". Process.

- Verify that there is only one line in Payment Details sub tab, still referring to Transferencia Payment Method in Status Void.

- Access again to previous Payment In record, refresh document and check that it has only 1 detail, which is correct.

- Go back to the sales invoice. Go to Payment Plan tab and select second line. Change Payment Method to Check by using "Modify Payment Plan" button.

- Check that payment method is changed to Cheque and that there is no payment details associated to this payment plan line.

Repeat same steps as above for another method of payment that is not an "Automatic" one.

- Add a payment for the payment plan line changed to Cheque (that is setup as Manual one).
- Reactivate that payment once received and delete its lines.
- Change that payment plan line to "Transferencia".
- Check it is possible to make that change while no additional payment detail line is created.

(0087289)
psanjuan   
2016-06-15 10:08   
Test plan above verified.

Issue can be code reviewed and closed.
(0087303)
hgbot   
2016-06-15 14:23   
Repository: erp/devel/pi
Changeset: 16b9d36614a8ca6269c942ab40778e89a8b5dbfd
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Wed Jun 08 11:58:42 2016 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/16b9d36614a8ca6269c942ab40778e89a8b5dbfd [^]

Fixes issue 33082: Payment Schedule Detail duplicated in "Modify Payment Plan"

Avoid creation of payment schedule detail for cancelled psd if there exists for a payment detail.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/ModifyPaymentPlanActionHandler.java
---
(0087304)
hgbot   
2016-06-15 14:23   
Repository: erp/devel/pi
Changeset: ae98f8c225239988a5a24b6696e23128214a3504
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Jun 15 14:20:57 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ae98f8c225239988a5a24b6696e23128214a3504 [^]

Related to issue 33082: Code review improvements

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/ModifyPaymentPlanActionHandler.java
---
(0087305)
hgbot   
2016-06-15 14:27   
Repository: erp/devel/pi
Changeset: be5679c6e512b2e83b181b5d43d4c884452efddc
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Jun 15 14:26:32 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/be5679c6e512b2e83b181b5d43d4c884452efddc [^]

Related to issue 33082: Improve method doc

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/ModifyPaymentPlanActionHandler.java
---
(0087306)
aferraz   
2016-06-15 14:28   
Code review OK
(0087620)
hudsonbot   
2016-06-17 19:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test
(0087621)
hudsonbot   
2016-06-17 19:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test
(0087622)
hudsonbot   
2016-06-17 19:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test