Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0033081 | Openbravo ERP | A. Platform | public | 2016-05-30 17:38 | 2022-02-01 08:05 |
|
| Reporter | NaroaIriarte | |
| Assigned To | Triage Platform Base | |
| Priority | high | Severity | minor | Reproducibility | have not tried |
| Status | acknowledged | Resolution | open | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | |
| Review Assigned To | alostale |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0033081: There are some sql queries that can be avoided. |
| Description | There are unneeded queries in done in the "HttpSecureAppServlet.hasGeneralAccess". It is needed to improve the General Access performance by removing those unneeded queries.
For example there are two queries done when the access type is "W". With a refactor it could be improved to only one query by changing this code:
"SeguridadData.selectAccess(this, vars.getRole(), "TABLE", id).equals("0") && !SeguridadData.selectAccess(this, vars.getRole(), type, id).equals("0")" |
| Steps To Reproduce | 1-As F&B Administrator go to Sales Order window.
2-Note that there are two queries, instead of one. This is (in part) because the HttpSecureAppServlet.hasGeneralAccess method, when the type is "W", does two queries. |
| Proposed Solution | Split the "seguridad_data.selectAccess" in different methods instead of having one for every type of access. In this way it is possible to do only one query for the type "W" instead of having two.
|
| Additional Information | |
| Tags | Performance |
| Relationships | | related to | defect | 0033051 | | closed | NaroaIriarte | The security check is called twice when opening a window or refreshing it |
|
| Attached Files |  patchIssue33081.diff (7,626) 2016-05-30 17:51
https://issues.openbravo.com/file_download.php?file_id=9449&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2016-05-30 17:38 | NaroaIriarte | New Issue | |
| 2016-05-30 17:38 | NaroaIriarte | Assigned To | => NaroaIriarte |
| 2016-05-30 17:38 | NaroaIriarte | Modules | => Core |
| 2016-05-30 17:38 | NaroaIriarte | Triggers an Emergency Pack | => No |
| 2016-05-30 17:51 | NaroaIriarte | File Added: patchIssue33081.diff | |
| 2016-05-30 17:51 | NaroaIriarte | Status | new => acknowledged |
| 2016-05-31 09:49 | NaroaIriarte | Review Assigned To | => alostale |
| 2016-05-31 09:50 | NaroaIriarte | Note Added: 0086851 | |
| 2016-12-14 17:20 | alostale | Tag Attached: Performance | |
| 2016-12-14 17:21 | alostale | Priority | normal => high |
| 2016-12-20 11:12 | NaroaIriarte | Description Updated | bug_revision_view_page.php?rev_id=14072#r14072 |
| 2016-12-20 11:12 | NaroaIriarte | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=14074#r14074 |
| 2016-12-20 15:16 | NaroaIriarte | Relationship added | related to 0033051 |
| 2016-12-20 17:29 | NaroaIriarte | Description Updated | bug_revision_view_page.php?rev_id=14085#r14085 |
| 2016-12-20 17:29 | NaroaIriarte | Proposed Solution updated | |
| 2016-12-21 09:04 | NaroaIriarte | Description Updated | bug_revision_view_page.php?rev_id=14095#r14095 |
| 2017-03-14 17:06 | NaroaIriarte | Assigned To | NaroaIriarte => platform |
| 2022-02-01 08:05 | alostale | Assigned To | platform => Triage Platform Base |