Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033074Retail ModulesWeb POSpublic2016-05-30 11:082016-06-22 13:32
Reportermigueldejuana 
Assigned Tomigueldejuana 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033074: Change remote model storaging logic
DescriptionNow we use saveTemporally/removeTemporally in Dal to save remote model in local database. We only save models which are in the current order.
Steps To ReproduceSee Description.
Proposed SolutionReplace this just saving these model, we do not have to delete them because we won't have a huge amount of data. We will do the remove in the Log out.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-05-30 11:08migueldejuanaNew Issue
2016-05-30 11:08migueldejuanaAssigned To => migueldejuana
2016-05-30 11:08migueldejuanaTriggers an Emergency Pack => No
2016-05-30 11:18hgbotCheckin
2016-05-30 11:18hgbotNote Added: 0086799
2016-05-30 11:18hgbotStatusnew => resolved
2016-05-30 11:18hgbotResolutionopen => fixed
2016-05-30 11:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/c176fdf9a2870854cae0c4f6ee37f95a16706dac [^]
2016-05-30 11:19hgbotCheckin
2016-05-30 11:19hgbotNote Added: 0086800
2016-05-30 11:19hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/c176fdf9a2870854cae0c4f6ee37f95a16706dac [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8031e0a5c5fa2d9bd77ee255695a8d0af9e407be [^]
2016-05-30 11:20hgbotCheckin
2016-05-30 11:20hgbotNote Added: 0086801
2016-05-30 11:20hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8031e0a5c5fa2d9bd77ee255695a8d0af9e407be [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/c248ab1d0aa657b1356d96beaa1442083a10d5cc [^]
2016-06-09 12:55marvintmNote Added: 0087115
2016-06-09 12:55marvintmStatusresolved => new
2016-06-09 12:55marvintmResolutionfixed => open
2016-06-09 12:55marvintmStatusnew => scheduled
2016-06-16 13:37hgbotCheckin
2016-06-16 13:37hgbotNote Added: 0087341
2016-06-16 13:37hgbotStatusscheduled => resolved
2016-06-16 13:37hgbotResolutionopen => fixed
2016-06-16 13:37hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/c248ab1d0aa657b1356d96beaa1442083a10d5cc [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/8f8cbebb0c39a98a81d9bfb71895238651b305a4 [^]
2016-06-16 13:37hgbotCheckin
2016-06-16 13:37hgbotNote Added: 0087342
2016-06-16 13:37hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/8f8cbebb0c39a98a81d9bfb71895238651b305a4 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4e52b6ab72b741bde890a49ceb09e9f7affbecf0 [^]
2016-06-16 13:38hgbotCheckin
2016-06-16 13:38hgbotNote Added: 0087343
2016-06-16 13:38hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4e52b6ab72b741bde890a49ceb09e9f7affbecf0 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8696948995d2bb4fa1f1c2f0de87d52691ab47c3 [^]
2016-06-22 13:32marvintmReview Assigned To => marvintm
2016-06-22 13:32marvintmStatusresolved => closed

Notes
(0086799)
hgbot   
2016-05-30 11:18   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: c176fdf9a2870854cae0c4f6ee37f95a16706dac
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon May 30 11:15:06 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/c176fdf9a2870854cae0c4f6ee37f95a16706dac [^]

Fixed issue 0033074: Change remote model storaging logic

- Remove temporally methods
- Create getsave function: Check if the model is in the database and if not, save it.
- Remove all remote models from local database when logging out.

---
M web/org.openbravo.mobile.core/source/data/ob-dal.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0086800)
hgbot   
2016-05-30 11:19   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 8031e0a5c5fa2d9bd77ee255695a8d0af9e407be
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon May 30 11:17:39 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8031e0a5c5fa2d9bd77ee255695a8d0af9e407be [^]

Fixed issue 0033074: Change remote model storaging logic

- Remove removeTemporally function calls
- Replace saveTemporally with getsave function

---
M web/org.openbravo.retail.posterminal/js/closecash/view/tabpendingreceipts.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0086801)
hgbot   
2016-05-30 11:20   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: c248ab1d0aa657b1356d96beaa1442083a10d5cc
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon May 30 11:19:33 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/c248ab1d0aa657b1356d96beaa1442083a10d5cc [^]

Fixed issue 0033074: Change remote model storaging logic

- Remove removeTemporally function calls
- Replace saveTemporally with getsave function

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---
(0087115)
marvintm   
2016-06-09 12:55   
Some changes are needed:
- getsave method should be renamed to saveIfNew
- A comment should be added explaining what it does
- The forceInsert parameter should be removed from the method declaration, and the internal call to obdal.save should be done with forceInsert=true
(0087341)
hgbot   
2016-06-16 13:37   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: 8f8cbebb0c39a98a81d9bfb71895238651b305a4
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Jun 10 09:02:43 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/8f8cbebb0c39a98a81d9bfb71895238651b305a4 [^]

Fixed issue 0033074: Change remote model storaging logic

- Use new method name and remove unneeded parameter

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---
(0087342)
hgbot   
2016-06-16 13:37   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 4e52b6ab72b741bde890a49ceb09e9f7affbecf0
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Jun 10 08:53:59 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/4e52b6ab72b741bde890a49ceb09e9f7affbecf0 [^]

Fixed issue 0033074: Change remote model storaging logic

- Rename getsave method and write a description
- Remove forceInsert parameter because it will be always true

---
M web/org.openbravo.mobile.core/source/data/ob-dal.js
---
(0087343)
hgbot   
2016-06-16 13:38   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 8696948995d2bb4fa1f1c2f0de87d52691ab47c3
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Jun 10 09:00:54 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8696948995d2bb4fa1f1c2f0de87d52691ab47c3 [^]

Fixed issue 0033074: Change remote model storaging logic

- Use new method name and remove unneeded parameter

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---