Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033068Retail ModulesWeb POSpublic2016-05-27 11:082016-06-27 15:23
Reporterpaul_guiot 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q3 
Merge Request Status
Review Assigned ToOrekaria
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033068: [SERQA 1182] Layaway: The system changes the customer name without reasons
DescriptionCustomer name changes following the attempt to create a return ticket with a Lawyaway open.
Steps To ReproduceSteps to reproduce:
(https://livebuilds.openbravo.com/retail_pi_pgsql/web/org.openbravo.retail.posterminal/?terminal=VBS-1#retail.pointofsale [^] [^] [^] - User Villablanca)
   
- In the menu, Click on "Layaway this receipt"
- Assign Carl Studsen as the customer
- Add article: Search - Click on a product (eg: Adhesive body warmers)
- In the menu, click on verified return
- Select an order with the business name "VBS Customer"
- Confirm the return ticket (selecting the articles - Apply)
- An error is shown "You cannot layaway a sale with returns"
- INCORRECT: the layaway has changed the business partner to VBS Customer (instead of Carl Studsen)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0033083 closed ranjith_qualiantech_com [SERQA 1197] Wrong label "To be return" appears in the Layaway and it should not 
Attached Filespatch issue 33068 source returns 257.patch (1,154) 2016-06-07 15:19
https://issues.openbravo.com/file_download.php?file_id=9500&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-05-27 11:08paul_guiotNew Issue
2016-05-27 11:08paul_guiotAssigned To => Retail
2016-05-27 11:08paul_guiotResolution time => 1465941600
2016-05-27 11:08paul_guiotTriggers an Emergency Pack => No
2016-05-30 10:35OrekariaNote Added: 0086793
2016-05-30 10:35OrekariaStatusnew => feedback
2016-05-30 10:58paul_guiotNote Added: 0086795
2016-05-30 11:02VictorVillarNote Added: 0086796
2016-05-30 11:02VictorVillarStatusfeedback => new
2016-05-30 11:45OrekariaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=12256#r12256
2016-05-30 11:45OrekariaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=12257#r12257
2016-05-30 11:58OrekariaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=12258#r12258
2016-05-30 11:59OrekariaStatusnew => acknowledged
2016-05-30 13:38ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2016-05-30 13:39ranjith_qualiantech_comStatusacknowledged => scheduled
2016-05-31 06:20hgbotCheckin
2016-05-31 06:20hgbotNote Added: 0086840
2016-05-31 06:20hgbotStatusscheduled => resolved
2016-05-31 06:20hgbotResolutionopen => fixed
2016-05-31 06:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/229d0dc490024cbbae7027615f126c5194aa2487 [^]
2016-05-31 06:20hgbotCheckin
2016-05-31 06:20hgbotNote Added: 0086841
2016-06-02 12:29OrekariaNote Added: 0086909
2016-06-02 12:29OrekariaStatusresolved => new
2016-06-02 12:29OrekariaResolutionfixed => open
2016-06-02 12:29OrekariaStatusnew => scheduled
2016-06-03 11:27ranjith_qualiantech_comRelationship addedrelated to 0033083
2016-06-06 07:44hgbotCheckin
2016-06-06 07:44hgbotNote Added: 0087006
2016-06-06 07:44hgbotStatusscheduled => resolved
2016-06-06 07:44hgbotResolutionopen => fixed
2016-06-06 07:44hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/229d0dc490024cbbae7027615f126c5194aa2487 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/c9b5a4ff8a4ff76ae411df1bd75787ba15cadf27 [^]
2016-06-06 07:44hgbotCheckin
2016-06-06 07:44hgbotNote Added: 0087007
2016-06-06 16:56OrekariaStatusresolved => new
2016-06-06 16:56OrekariaResolutionfixed => open
2016-06-06 16:56OrekariaStatusnew => scheduled
2016-06-07 15:19ranjith_qualiantech_comFile Added: issue 33068 source returns 257.patch
2016-06-08 07:02hgbotCheckin
2016-06-08 07:02hgbotNote Added: 0087078
2016-06-13 07:40ranjith_qualiantech_comStatusscheduled => resolved
2016-06-13 07:40ranjith_qualiantech_comResolutionopen => fixed
2016-06-22 09:09marvintmReview Assigned To => mtaal
2016-06-27 10:09OrekariaReview Assigned Tomtaal => Orekaria
2016-06-27 15:23OrekariaStatusresolved => closed
2016-06-27 15:23OrekariaFixed in Version => RR16Q3

Notes
(0086793)
Orekaria   
2016-05-30 10:35   
I cannot reproduce the issue
Please update the steps to reproduce with EXACTLY the menu options and products you are using
(0086795)
paul_guiot   
2016-05-30 10:58   
Steps to reproduce:
(https://livebuilds.openbravo.com/retail_pi_pgsql/web/org.openbravo.retail.posterminal/?terminal=VBS-1#retail.pointofsale [^] [^] - User Villablanca)
   
- In the menu, Click on "Layaway this receipt"
- Assign Carl Studsen as the customer
- Add article: Search - Click on a product (eg: Adhesive body warmers)
- In the menu, click on verified return
- Select an order with a different customer name (eg: VBS Customer)
- Confirm the return ticket (selecting the articles - Apply)

Result (error): The customer of the original SO has been modified (VBS instead of Carl Studsen)
(0086796)
VictorVillar   
2016-05-30 11:02   
steps to reproduce updated
(0086840)
hgbot   
2016-05-31 06:20   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: 229d0dc490024cbbae7027615f126c5194aa2487
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue May 31 09:49:51 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/229d0dc490024cbbae7027615f126c5194aa2487 [^]

Fixes issue 33068 : Updating Order Type to Verified returns

- Updating Order type while adding lines from verified returns

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---
(0086841)
hgbot   
2016-05-31 06:20   
Repository: tools/automation/pi-mobile
Changeset: d7a52f456914e90efb6e4ceb994245213050ed7f
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue May 31 09:48:28 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/d7a52f456914e90efb6e4ceb994245213050ed7f [^]

Verifies issue 33068 : Added automated test 'I33068_CheckVerifiedReturnOrderType.java'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/I33068_CheckVerifiedReturnOrderType.java
---
(0086909)
Orekaria   
2016-06-02 12:29   
The fix is doing far more actions than expected

The fix should only ensure that nothing happens in this situation, i.e. the error message must be shown but nothing else should happen
(0087006)
hgbot   
2016-06-06 07:44   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: c9b5a4ff8a4ff76ae411df1bd75787ba15cadf27
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jun 06 11:13:14 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/c9b5a4ff8a4ff76ae411df1bd75787ba15cadf27 [^]

Fixes issue 33068 : Disabled "Verified Return" from menu if current receipt is layaway

---
M web/org.openbravo.retail.returns/js/returnReceiptButton.js
---
(0087007)
hgbot   
2016-06-06 07:44   
Repository: tools/automation/pi-mobile
Changeset: 60d3e635837faf0403b94e306a08c909375159c8
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jun 06 11:13:20 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/60d3e635837faf0403b94e306a08c909375159c8 [^]

Verifies issue 33068 : Added automated test 'I33068_CheckVerifiedReturnOnLayaway'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/I33068_CheckVerifiedReturnOnLayaway.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/I33068_CheckVerifiedReturnOrderType.java
---
(0087078)
hgbot   
2016-06-08 07:02   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: 98066f4569dda15402888e394a914d72155e0b36
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Jun 07 18:48:15 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/98066f4569dda15402888e394a914d72155e0b36 [^]

Related to issue 33068 : Removed orderType while creating line from verified returns

- backout changeset : 229d0dc49002
- No need to set 'orderType' in verified returns

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---