Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033063Openbravo ERP09. Financial managementpublic2016-05-26 17:052016-06-29 17:39
Reportermaite 
Assigned Tomarkmm82 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q3Fixed in Version3.0PR16Q3 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket42162
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033063: It should be possible to run "Reset Accounting" process for several organization at once
DescriptionAt the moment, user needs to execute process for each Legal With Accounting organization. Depending on organization's structure this is a hard task and would be useful to be able to run it for several organizations (multiple selector) and also for several (but not all) tables (multiple selector)
Steps To Reproduce1. Access to Reset Accounting menu entry and realize that only "España" and "US" organizations are available and also that you can not select a list of tables but a single one or all of them
Proposed Solution- Add * to Organization selector in order to reset accounting for all the child organizations in cascade.
- Change Table selector to a multi-selector to allow run reset accounting for multiple tables in the same batch.
Additional Information
TagsNo tags attached.
Relationships
depends on defect 00331943.0PR16Q3 closed alostale Access not granted to Multi Selector Entity 
related to feature request 0024321 closed nonofrancisco It would be nice to be able to schedule Reset Accounting process 
related to defect 0033205 acknowledged Triage Platform Base Start in new line is not working fine in Process Definition 
related to defect 0037422 closed markmm82 Reset Accounting finishes with error if it is launched for an org with "Organization" type and the type name has been changed 
related to defect 0038218 closed markmm82 'Delete failed' error in Reset Accounting process if it is launched for 'Organization' type org without legal children 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-05-26 17:05maiteNew Issue
2016-05-26 17:05maiteAssigned To => Triage Finance
2016-05-26 17:05maiteOBNetwork customer => Yes
2016-05-26 17:05maiteModules => Core
2016-05-26 17:05maiteSupport ticket => 42162
2016-05-26 17:05maiteTriggers an Emergency Pack => No
2016-05-26 17:05maiteAssigned ToTriage Finance => dmitry_mezentsev
2016-05-26 17:05maiteIssue Monitored: networkb
2016-05-26 17:06maiteRelationship addedrelated to 0024321
2016-05-27 12:50maiteSummaryIt should be possible to run "Reset Accounting" process for * organization => It should be possible to run "Reset Accounting" process for several organization at once
2016-05-27 12:50maiteDescription Updatedbug_revision_view_page.php?rev_id=12247#r12247
2016-05-27 12:50maiteSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=12249#r12249
2016-05-27 12:50maiteProposed Solution updated
2016-06-01 12:35maiteResolution time => 1465509600
2016-06-01 12:35maiteTypedesign defect => defect
2016-06-01 12:35maiteTarget Version => 3.0PR16Q3
2016-06-01 12:36maiteAssigned Todmitry_mezentsev => Triage Finance
2016-06-01 12:50aferrazProposed Solution updated
2016-06-01 12:51aferrazAssigned ToTriage Finance => markmm82
2016-06-01 14:40markmm82Statusnew => scheduled
2016-06-08 14:44aferrazRelationship addeddepends on 0033194
2016-06-09 11:27aferrazRelationship addedrelated to 0033205
2016-06-14 09:04hgbotCheckin
2016-06-14 09:04hgbotNote Added: 0087222
2016-06-14 09:04hgbotStatusscheduled => resolved
2016-06-14 09:04hgbotResolutionopen => fixed
2016-06-14 09:04hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/86811a139d3ee99634aeae39604931a5d393f613 [^]
2016-06-14 09:04hgbotCheckin
2016-06-14 09:04hgbotNote Added: 0087223
2016-06-14 09:04hgbotCheckin
2016-06-14 09:04hgbotNote Added: 0087224
2016-06-14 09:06aferrazReview Assigned To => aferraz
2016-06-14 09:06aferrazNote Added: 0087225
2016-06-14 09:06aferrazStatusresolved => closed
2016-06-14 09:06aferrazFixed in Version => 3.0PR16Q3
2016-06-16 17:38hgbotCheckin
2016-06-16 17:38hgbotNote Added: 0087361
2016-06-17 19:38hudsonbotCheckin
2016-06-17 19:38hudsonbotNote Added: 0087611
2016-06-17 19:38hudsonbotCheckin
2016-06-17 19:38hudsonbotNote Added: 0087612
2016-06-17 19:38hudsonbotCheckin
2016-06-17 19:38hudsonbotNote Added: 0087613
2016-06-29 12:54hgbotCheckin
2016-06-29 12:54hgbotNote Added: 0088076
2016-06-29 17:39hudsonbotCheckin
2016-06-29 17:39hudsonbotNote Added: 0088087
2017-11-30 11:20ngarciaRelationship addedrelated to 0037422
2018-03-26 13:26ngarciaRelationship addedrelated to 0038218

Notes
(0087222)
hgbot   
2016-06-14 09:04   
Repository: erp/devel/pi
Changeset: 86811a139d3ee99634aeae39604931a5d393f613
Author: Mark <markmm82 <at> gmail.com>
Date: Mon Jun 06 11:21:31 2016 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/86811a139d3ee99634aeae39604931a5d393f613 [^]

Fixes issue 33063: "Reset Accounting" for several organization & tables at once

A new "Reset Accounting" Process Definiton is created to replace the functionality of the "Reset Accounting" process, but allowing to select multiple tables at once and also to select the "*" organization to process all the organizations when the reset accountings process is executed.

---
M src-db/database/sourcedata/AD_MENU.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_REF_TABLE.xml
M src-db/database/sourcedata/AD_TREENODE.xml
M src-db/database/sourcedata/AD_VAL_RULE.xml
M src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
M src-db/database/sourcedata/OBUIAPP_PROCESS.xml
M src-db/database/sourcedata/OBUISEL_SELECTOR.xml
M src-db/database/sourcedata/OBUISEL_SELECTOR_FIELD.xml
M src/org/openbravo/financial/ResetAccounting.java
A src/org/openbravo/common/actionhandler/ResetAccountingHandler.java
---
(0087223)
hgbot   
2016-06-14 09:04   
Repository: erp/devel/pi
Changeset: 65ca52c8587f6987f60450fa49d77a530582e92f
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Mon Jun 13 10:23:13 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/65ca52c8587f6987f60450fa49d77a530582e92f [^]

Related to issue 33063: Code review improvements

- Client parameter: change selector, add default value and remove selector fields.
- Organization parameter: change selector and where clause, add default value and remove selector fields.
- Table parameter: change selector and where clause, change table from ADTable to ADTablePostV and remove selector fields.
- Remove unnecessary created ad_ref_table and ad_val_rule records.
- Deactivate and deprecate old Reset Accounting process.
- Remove recordId parameter and get correctly datefrom and dateto fields in ResetAccountingHandler.java class.
- Add getLegalOrBusinessOrgsChilds method in ResetAccounting.java class to retrieve every legal and business unit together with their child organizations from selected client in case * organization has been selected.
- Call getCalendarId for each organization in the loop to avoid errors when adOrgId is '0'.

---
M src-db/database/sourcedata/AD_MENU.xml
M src-db/database/sourcedata/AD_PROCESS.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_REF_TABLE.xml
M src-db/database/sourcedata/AD_VAL_RULE.xml
M src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
M src-db/database/sourcedata/OBUISEL_SELECTOR.xml
M src-db/database/sourcedata/OBUISEL_SELECTOR_FIELD.xml
M src/org/openbravo/common/actionhandler/ResetAccountingHandler.java
M src/org/openbravo/erpCommon/ad_process/ResetAccountingProcess.java
M src/org/openbravo/financial/ResetAccounting.java
---
(0087224)
hgbot   
2016-06-14 09:04   
Repository: erp/devel/pi
Changeset: 72f63dfd90cd17422c44e033cb61a727d4b4e8a0
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Mon Jun 13 14:14:17 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/72f63dfd90cd17422c44e033cb61a727d4b4e8a0 [^]

Related to issue 33063: Add modulescript to add process definition access

Create a modulescript to add process definition access to any role which had access to old Reset Accounting process.
It will be run only once when doing update.database.

---
A src-util/modulescript/build/classes/org/openbravo/modulescript/ResetAccountingAccess.class
A src-util/modulescript/build/classes/org/openbravo/modulescript/ResetAccountingAccessData.class
A src-util/modulescript/src/org/openbravo/modulescript/ResetAccountingAccess.java
A src-util/modulescript/src/org/openbravo/modulescript/ResetAccountingAccess_data.xsql
---
(0087225)
aferraz   
2016-06-14 09:06   
Code review + Testing OK
(0087361)
hgbot   
2016-06-16 17:38   
Repository: tools/automation/int
Changeset: 47b6da866e65475c535a82319d227da1847dd6ab
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Jun 15 11:04:10 2016 +0200
URL: http://code.openbravo.com/tools/automation/int/rev/47b6da866e65475c535a82319d227da1847dd6ab [^]

Related to issue 33063: Change ResetAccountingPopUP with ResetAccountingProcess

---
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/accounting/testsuites/ResetAllAccountingEntries.java
M src-test/com/openbravo/test/integration/erp/testscripts/financial/accounting/transactions/ResetAccounting.java
A src-test/com/openbravo/test/integration/erp/gui/financial/accounting/transactions/ResetAccountingProcess.java
---
(0087611)
hudsonbot   
2016-06-17 19:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test
(0087612)
hudsonbot   
2016-06-17 19:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test
(0087613)
hudsonbot   
2016-06-17 19:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test
(0088076)
hgbot   
2016-06-29 12:54   
Repository: erp/devel/pi
Changeset: 2711fe8a20bc9c3c1e5bccb6bdfe5c74a685aa7e
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Jun 29 12:40:27 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2711fe8a20bc9c3c1e5bccb6bdfe5c74a685aa7e [^]

Related to issue 33063: Enable Organization type orgs in Reset Accounting

---
M src-db/database/sourcedata/OBUISEL_SELECTOR.xml
M src-db/database/sourcedata/OBUISEL_SELECTOR_FIELD.xml
M src/org/openbravo/financial/ResetAccounting.java
---
(0088087)
hudsonbot   
2016-06-29 17:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/01b523ba4ddf [^]
Maturity status: Test