Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033054Openbravo ERPZ. Otherspublic2016-05-25 11:042016-05-30 21:24
Reportermaite 
Assigned Tomarkmm82 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q1.3Fixed in Version3.0PR16Q1.3 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033054: Permissions problem after process payment: role defined for an specific org (norte) is able to see data from sister orgs (sur)
DescriptionProblem is caused by resolution of issue: https://issues.openbravo.com/view.php?id=28931, [^] which also needs to be reviewed as error "Organization B843C30461EA4501935CB1D125C9C25A of object (ADSequence(0BC1D46D77844119AAAC72636119BF43) (name: AR Receipt)) is not present in OrganizationList " is obtained when trying to create payment fro "Add payment from invoice" process
Steps To Reproduce1. Access Role window, search "F&B España, S.A - Finance" role and DELETE permissions to "F&B España, S.A" and "F&B España - Región Sur" in Org Access. So role only has access to "F&B España - Región Norte" organization
2. Logout and login again using "F&B España, S.A - Finance" role
3. Access Payment IN window and realize that only records from "F&B España - Región Norte" organization and "F&B España, S.A" (read only) are shown
4. Create new Payment In record, run "Add Payment" process, select any invoice and process
5. Realize that also records from "F&B España - Región Sur" are shown in grid, which is wrong

Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0033043 closed markmm82 Permissions problem after process payment: role defined for an specific org (norte) is able to see data from sister orgs (sur) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-05-25 19:44markmm82Typedefect => backport
2016-05-25 19:44markmm82Target Version => 3.0PR16Q1.3
2016-05-30 21:22hgbotCheckin
2016-05-30 21:22hgbotNote Added: 0086832
2016-05-30 21:22hgbotStatusscheduled => resolved
2016-05-30 21:22hgbotResolutionopen => fixed
2016-05-30 21:22hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR16Q1.3/rev/56ff23f68667342d6dbc66eec2911979ba26cdb6 [^]
2016-05-30 21:22hgbotCheckin
2016-05-30 21:22hgbotNote Added: 0086833
2016-05-30 21:24aferrazReview Assigned To => aferraz
2016-05-30 21:24aferrazNote Added: 0086838
2016-05-30 21:24aferrazStatusresolved => closed
2016-05-30 21:24aferrazFixed in Version => 3.0PR16Q1.3

Notes
(0086832)
hgbot   
2016-05-30 21:22   
Repository: erp/backports/3.0PR16Q1.3
Changeset: 56ff23f68667342d6dbc66eec2911979ba26cdb6
Author: Mark <markmm82 <at> gmail.com>
Date: Fri May 27 13:12:14 2016 -0400
URL: http://code.openbravo.com/erp/backports/3.0PR16Q1.3/rev/56ff23f68667342d6dbc66eec2911979ba26cdb6 [^]

Fixed issue 33054: Permissions problems after process payment solved.

Role defined for an specific org is not able to see data from sister orgs.

Regression was introduced by the commit associated to issue 28931:
http://code.openbravo.com/erp/devel/pi/rev/78fd9bade67beea0399977fcdc05fd267c4af8c4 [^]

Changes were rolled back.
Also this patch includes fix for the issue 28931, avoiding to remove from the Writable Organizations List of the OBContext object, the Organization of the sequence of the payment's document type, if this organization is already in the list of accesible organizations of the current logged role.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddPaymentActionHandler.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/AdvPaymentMngtDao.java
---
(0086833)
hgbot   
2016-05-30 21:22   
Repository: erp/backports/3.0PR16Q1.3
Changeset: 51fd2cad5b6838def0914fb2189606239d8cce51
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Mon May 30 18:33:13 2016 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR16Q1.3/rev/51fd2cad5b6838def0914fb2189606239d8cce51 [^]

Related to issue 33054: Code review improvements

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddPaymentActionHandler.java
---
(0086838)
aferraz   
2016-05-30 21:24   
Code review + Testing OK