Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033053Openbravo ERPZ. Otherspublic2016-05-25 11:042016-05-30 21:23
Reportermaite 
Assigned Tomarkmm82 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q2Fixed in Version3.0PR16Q2 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket41926
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033053: Permissions problem after process payment: role defined for an specific org (norte) is able to see data from sister orgs (sur)
DescriptionProblem is caused by resolution of issue: https://issues.openbravo.com/view.php?id=28931, [^] which also needs to be reviewed as error "Organization B843C30461EA4501935CB1D125C9C25A of object (ADSequence(0BC1D46D77844119AAAC72636119BF43) (name: AR Receipt)) is not present in OrganizationList " is obtained when trying to create payment fro "Add payment from invoice" process
Steps To Reproduce1. Access Role window, search "F&B España, S.A - Finance" role and DELETE permissions to "F&B España, S.A" and "F&B España - Región Sur" in Org Access. So role only has access to "F&B España - Región Norte" organization
2. Logout and login again using "F&B España, S.A - Finance" role
3. Access Payment IN window and realize that only records from "F&B España - Región Norte" organization and "F&B España, S.A" (read only) are shown
4. Create new Payment In record, run "Add Payment" process, select any invoice and process
5. Realize that also records from "F&B España - Región Sur" are shown in grid, which is wrong

Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0033043 closed markmm82 Permissions problem after process payment: role defined for an specific org (norte) is able to see data from sister orgs (sur) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-05-25 19:44markmm82Typedefect => backport
2016-05-25 19:44markmm82Target Version => 3.0PR16Q2
2016-05-30 21:21hgbotCheckin
2016-05-30 21:21hgbotNote Added: 0086829
2016-05-30 21:21hgbotStatusscheduled => resolved
2016-05-30 21:21hgbotResolutionopen => fixed
2016-05-30 21:21hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR16Q2/rev/2c5ee42cc25845403e5df69e8ac274799d923d71 [^]
2016-05-30 21:21hgbotCheckin
2016-05-30 21:21hgbotNote Added: 0086830
2016-05-30 21:23aferrazAssigned Tomarkmm82 => aferraz
2016-05-30 21:23aferrazAssigned Toaferraz => markmm82
2016-05-30 21:23aferrazReview Assigned To => aferraz
2016-05-30 21:23aferrazNote Added: 0086837
2016-05-30 21:23aferrazStatusresolved => closed
2016-05-30 21:23aferrazFixed in Version => 3.0PR16Q2

Notes
(0086829)
hgbot   
2016-05-30 21:21   
Repository: erp/backports/3.0PR16Q2
Changeset: 2c5ee42cc25845403e5df69e8ac274799d923d71
Author: Mark <markmm82 <at> gmail.com>
Date: Fri May 27 12:53:49 2016 -0400
URL: http://code.openbravo.com/erp/backports/3.0PR16Q2/rev/2c5ee42cc25845403e5df69e8ac274799d923d71 [^]

Fixed issue 33053: Permissions problems after process payment solved.

Role defined for an specific org is not able to see data from sister orgs.

Regression was introduced by the commit associated to issue 28931:
http://code.openbravo.com/erp/devel/pi/rev/78fd9bade67beea0399977fcdc05fd267c4af8c4 [^]

Changes were rolled back.
Also this patch includes fix for the issue 28931, avoiding to remove from the Writable Organizations List of the OBContext object, the Organization of the sequence of the payment's document type, if this organization is already in the list of accesible organizations of the current logged role.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddPaymentActionHandler.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/AdvPaymentMngtDao.java
---
(0086830)
hgbot   
2016-05-30 21:21   
Repository: erp/backports/3.0PR16Q2
Changeset: 4f8e8fd51a6892566ebfbcb32ca60b74f23a2909
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Mon May 30 18:33:13 2016 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR16Q2/rev/4f8e8fd51a6892566ebfbcb32ca60b74f23a2909 [^]

Related to issue 33053: Code review improvements

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddPaymentActionHandler.java
---
(0086837)
aferraz   
2016-05-30 21:23   
Code review + Testing OK