Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033052Openbravo ERPA. Platformpublic2016-05-25 16:372016-06-20 13:08
ReporterJONHM 
Assigned ToNaroaIriarte 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0PR16Q1.1 
Target VersionFixed in Version3.0PR16Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033052: Product Characteristics field doesn't work in Return from Customer / Return to Vendor
DescriptionAfter adding a Product Characteristics field as a property on a Pick/Edit window shows no data associated with product and doesn't filter anything.
The thing is that it is not supported to have a property field in the return from customers because it is an hql window.
Steps To Reproduce1) As system administrator, go to "Windows, tabs and fields" and pick "RFC/RTV HQL Pick / Edit Lines" window
2) Then add a new field named "Product Characteristics" and give it a Property "product.characteristicDescription". Also show it in grid view.
3) Change role to "F&B International Group Admin" and go to "Product Characteristic" window, add a new record and give it some values. Then press button "Add Products" and assign some products to those values
4) Go to "Return from Customer" window, add a new return related to a product assigned before and then press button "Pick/Edit lines"
5) Clear filters and see that new field "Product Characteristics" doesn't show any value nor filtering any product.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0033143 closed alostale Property field not visible in tree grid view 
Attached Filespng ProductCharacteristic.png (117,744) 2016-05-25 16:37
https://issues.openbravo.com/file_download.php?file_id=9440&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2016-05-25 16:37JONHMNew Issue
2016-05-25 16:37JONHMAssigned To => platform
2016-05-25 16:37JONHMFile Added: ProductCharacteristic.png
2016-05-25 16:37JONHMModules => Core
2016-05-25 16:37JONHMResolution time => 1466546400
2016-05-25 16:37JONHMTriggers an Emergency Pack => No
2016-05-25 17:15heccamIssue Monitored: heccam
2016-05-26 11:48alostaleStatusnew => acknowledged
2016-05-31 10:41NaroaIriarteAssigned Toplatform => NaroaIriarte
2016-05-31 12:09NaroaIriarteReview Assigned To => alostale
2016-05-31 13:35NaroaIriarteDescription Updatedbug_revision_view_page.php?rev_id=12264#r12264
2016-06-14 09:00alostaleRelationship addedrelated to 0033143
2016-06-16 10:55alostaleSummaryProduct Characteristics field doesn't work on Pick/Edit Window => Product Characteristics field doesn't work in Return from Customer / Return to Vendor
2016-06-16 16:55hgbotCheckin
2016-06-16 16:55hgbotNote Added: 0087358
2016-06-16 16:55hgbotStatusacknowledged => resolved
2016-06-16 16:55hgbotResolutionopen => fixed
2016-06-16 16:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0c9e018ec68b2c97009012f75838e5ebf9e50cd3 [^]
2016-06-17 19:38hudsonbotCheckin
2016-06-17 19:38hudsonbotNote Added: 0087632
2016-06-20 13:08alostaleNote Added: 0087669
2016-06-20 13:08alostaleStatusresolved => closed
2016-06-20 13:08alostaleFixed in Version => 3.0PR16Q3

Notes
(0087358)
hgbot   
2016-06-16 16:55   
Repository: erp/devel/pi
Changeset: 0c9e018ec68b2c97009012f75838e5ebf9e50cd3
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Wed Jun 15 17:06:10 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/0c9e018ec68b2c97009012f75838e5ebf9e50cd3 [^]

Fixed issue 33052: can't add prod characteristics to Return P&E

  Two problems have been solved:
    * By default, datasources based on HQL Query Tables do not accept property
      fields. This needs to be implemented case by case. Now Return to Customer
      and Return to Vendor P&E support it as far as the path to that property is
      composed by not nullable properties.
    * Product Characteristics filter assumed the alias for the main table in the
      datasource it was working on was always "e". This is might not be true for
      datasources based on HQL Query Tables.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/templates/ob-pick-and-execute-grid.js.ftl
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewGridComponent.java
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-characteristics.js
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/HQLDataSourceService.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/DataToJsonConverter.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/JsonConstants.java
A src/org/openbravo/common/datasource/ReturnFromCustomerVendorPropertyFieldsTransformer.java
---
(0087632)
hudsonbot   
2016-06-17 19:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test
(0087669)
alostale   
2016-06-20 13:08   
code reviewed

tested:
* Return from Customer / to Vendor P&E grids support product characteristics as a property field being possible to see it in grid as well as filtering