Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033047Retail ModulesWeb POSpublic2016-05-25 12:192016-06-22 13:36
Reporterguilleaer 
Assigned Tomario_castello 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033047: async problem in cash management - Affecting (at least) to test I30160_UseTheSameGLItem
DescriptionThis issue happens because when a deposit or withdrawal is created (after click in the list of deposits/withdrawals popup line) the code has an asynchrony which is not properly managed.

This asynchrony, used to retrieve current cashup information, causes that if done button is pressed very fast (Only reproducible by test), the deposit or withdrawal is not already added to the list.

Above fact happens here ->
file: cashmgmt-model.js
Line: 29
Code: this.depsdropstosave.on('paymentDone', function (model, p) {
Steps To ReproduceJust reproducible through test I30160_UseTheSameGLItem.

now fixed adding sleep.
Proposed Solution1. Async should be properly managed or romeved (cashupid can be get from terminal without asynchrony)
2. Done button should be disabled while find is executed
3. Remove pause in test once issue is fixed
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-05-25 12:19guilleaerNew Issue
2016-05-25 12:19guilleaerAssigned To => Retail
2016-05-25 12:19guilleaerOBNetwork customer => No
2016-05-25 12:19guilleaerTriggers an Emergency Pack => No
2016-05-25 12:29OrekariaStatusnew => acknowledged
2016-06-14 00:14mario_castelloAssigned ToRetail => mario_castello
2016-06-14 16:28mario_castelloStatusacknowledged => scheduled
2016-06-16 15:49hgbotCheckin
2016-06-16 15:49hgbotNote Added: 0087355
2016-06-16 15:49hgbotStatusscheduled => resolved
2016-06-16 15:49hgbotResolutionopen => fixed
2016-06-16 15:49hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3489886f9f874501b775ed88506beea1a42281d4 [^]
2016-06-17 20:06hgbotCheckin
2016-06-17 20:06hgbotNote Added: 0087636
2016-06-22 13:36marvintmReview Assigned To => marvintm
2016-06-22 13:36marvintmStatusresolved => closed

Notes
(0087355)
hgbot   
2016-06-16 15:49   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3489886f9f874501b775ed88506beea1a42281d4
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Wed Jun 15 13:00:33 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3489886f9f874501b775ed88506beea1a42281d4 [^]

Fixed issue 33047: Added synchronization to paymenDone event in cash management

---
M web/org.openbravo.retail.posterminal/js/cashmgmt/model/cashmgmt-model.js
---
(0087636)
hgbot   
2016-06-17 20:06   
Repository: tools/automation/pi-mobile
Changeset: e33acf340126fbb9dfe9cc1dbbff7e3d09f5b3a5
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Thu Jun 16 14:22:35 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/e33acf340126fbb9dfe9cc1dbbff7e3d09f5b3a5 [^]

Related to issue 33047: Delete OBUtils.pause in test I30160_UseTheSameGLItem

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashmanagement/I30160_UseTheSameGLItem.java
---