Openbravo Issue Tracking System - Modules
View Issue Details
0033039ModulesRemittancepublic2016-05-24 16:322016-06-02 17:02
ngarcia 
markmm82 
urgentmajoralways
closedfixed 
5
 
 
aferraz
0033039: Bank Instruction Lines' expected date previous to remittance's transaction date when singlepayment is selected
Bank Instruction Lines' expected date previous to remittance's transaction date when singlepayment is selected
As group admin role:
   Create two purchase invoices from the same business partner with Remittance Payment Method, Immediate Payment Terms and different dates
   Create a Remittance with a more recent Transaction Date
   Select SinglePayment
   Process it by selecting any option different from No Grouping
   Check the payment is created with remittance's expected transaction date but the bank instruction dates have a date previous to the transaction date of the remittance.

(In case Single payment is selected and "No groping" option is selected, payment is created with remittance expected date and bank instructions are created with the remittance transaction date).
If you have "SinglePayment" option selected and choose while processing the remittance any of the grouping options available but "No grouping", the expected date shown in "Bank Instructions" tab is/are NOT correct. The correct date should be remittance transaction date.


So, in those cases where invoice due date = expected date is in the past, no matter if the end user select Single Payment option or not, the expected date shown in bank instructions tab / lines needs to be the "Transaction Date" entered for the Remittance.
No tags attached.
related to defect 0025060 closed jonalegriaesarte Bank instruction expected date does not match the payment date when you process the remittance without grouping 
Issue History
2016-05-24 16:32ngarciaNew Issue
2016-05-24 16:32ngarciaAssigned To => Triage Finance
2016-05-24 16:33ngarciaResolution time => 1465855200
2016-05-24 16:33ngarciaIssue Monitored: networkb
2016-05-24 16:37ngarciaRelationship addedrelated to 0025060
2016-05-24 17:07aferrazAssigned ToTriage Finance => markmm82
2016-05-24 17:17markmm82Statusnew => scheduled
2016-05-31 15:34psanjuanProposed Solution updated
2016-06-01 14:38markmm82Note Added: 0086896
2016-06-02 12:29psanjuanNote Edited: 0086896bug_revision_view_page.php?bugnote_id=0086896#r12284
2016-06-02 12:36psanjuanNote Edited: 0086896bug_revision_view_page.php?bugnote_id=0086896#r12285
2016-06-02 12:52psanjuanNote Edited: 0086896bug_revision_view_page.php?bugnote_id=0086896#r12288
2016-06-02 14:16psanjuanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=12298#r12298
2016-06-02 14:16psanjuanProposed Solution updated
2016-06-02 14:19psanjuanProposed Solution updated
2016-06-02 14:24psanjuanNote Edited: 0086896bug_revision_view_page.php?bugnote_id=0086896#r12300
2016-06-02 14:39psanjuanNote Edited: 0086896bug_revision_view_page.php?bugnote_id=0086896#r12303
2016-06-02 14:40psanjuanNote Added: 0086927
2016-06-02 16:59hgbotCheckin
2016-06-02 16:59hgbotNote Added: 0086948
2016-06-02 16:59hgbotStatusscheduled => resolved
2016-06-02 16:59hgbotResolutionopen => fixed
2016-06-02 16:59hgbotFixed in SCM revision => http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/e877de9642c45012609f660017dbb74aa03e10c5 [^]
2016-06-02 17:00hgbotCheckin
2016-06-02 17:00hgbotNote Added: 0086949
2016-06-02 17:00hgbotCheckin
2016-06-02 17:00hgbotNote Added: 0086950
2016-06-02 17:02aferrazReview Assigned To => aferraz
2016-06-02 17:02aferrazNote Added: 0086951
2016-06-02 17:02aferrazStatusresolved => closed

Notes
(0086896)
markmm82   
2016-06-01 14:38   
(edited on: 2016-06-02 14:39)
Test plan:
   1-Create two purchase invoices from the same business partner with Remittance Payment Method, Immediate Payment Terms and different dates.
    PO1-Invoice date: 20-05-2016 (10000866)
    PO2-Invoice date: 10-05-2016 (10000867)
   2-Add lines and complete them.
    Go to PO1 (10000866) -> Payment Plan Tab, and notice that Due date is 20-05-2016 and Expected Date is 20-05-2016
    Go to PO2 (10000867) -> Payment Plan Tab, and notice that Due date is 10-05-2016 and Expected Date is 10-05-2016
   3-Create a Remittance with a more recent Transaction Date:
    Transaction Date: 02-06-2016
    Expected Date: 30-06-2016
       Select SinglePayment
   4-Save it
   5-Click to "Select Orders or Invoices" button
   6-Select "Payment Out" option in Transaction Type.
   7-Select both Purchase invoices created in step 1 (for example: 10000866 and 10000867)
    Press "Process" button.
    You can see two new lines added to the Remittance:
       Line 10-> Invoice: 10000866 - 20-05-2016 - 10.77, Invoice Payment Plan: 20-05-2016
       Line 20-> Invoice: 10000867 - 10-05-2016 - 9.08, Invoice Payment Plan: 10-05-2016
   8-Press the "Process" button.
    Process it by selecting "No Grouping" option.
   9-Check that a new Payment Out is created with remittance's expected date 30-06-2016.
   10-Check that 2 new bank instructions has been created with the following information:
    Line 10-> Description-> Invoice No.: 10000866, Expected Date: 02-06-2016
    Line 20-> Description-> Invoice No.: 10000867, Expected Date: 02-06-2016

Repeat remittance processing by selecting any "grouping" option available together "Single Payment" check do NOT selected.
Verify that both payments date = bank instructions lines expected date = 02-06-2016 (remittance transaction date).

Repeat remittance processing by selecting any "grouping" option available together "Single Payment" check do selected.
Verify that payment date (single payment) = expected remittance date
and bank instructions lines expected date = 02-06-2016 (remittance transaction date).

Repeat same steps for sales invoice remittance and payment remittance, just in case Single Payment check is not selected as that is the only behavior allowed.

Repeat same steps as above for a remittance not including invoices with a due date in the past but in the future so those dates are taken into account in bank instructions lines when Single Payment option is selected (single payment date will be the expected date of the remittance).

(0086927)
psanjuan   
2016-06-02 14:40   
Test plan above verified.

Issue can be code reviewed and closed.
(0086948)
hgbot   
2016-06-02 16:59   
Repository: erp/mods/org.openbravo.module.remittance
Changeset: e877de9642c45012609f660017dbb74aa03e10c5
Author: Mark <markmm82 <at> gmail.com>
Date: Tue May 31 20:03:27 2016 -0400
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/e877de9642c45012609f660017dbb74aa03e10c5 [^]

Fixes issue 33039: Bank instructions dates takes remittance's transaction date

In those cases where invoice's due date = expected date is in the past, no matter if a use Single Payment option or not the expected date shown in bank instructions tab / lines is the "Transaction Date" entered for the Remittance.

---
M src/org/openbravo/module/remittance/process/REM_RemittanceProcess.java
---
(0086949)
hgbot   
2016-06-02 17:00   
Repository: erp/mods/org.openbravo.module.remittance
Changeset: f3e66f6e6d7707391326699ddc6eb184ea3be84b
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Jun 02 16:22:34 2016 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/f3e66f6e6d7707391326699ddc6eb184ea3be84b [^]

Related to issue 33039: Code review improvements

---
M src/org/openbravo/module/remittance/process/REM_RemittanceProcess.java
---
(0086950)
hgbot   
2016-06-02 17:00   
Repository: erp/mods/org.openbravo.module.remittance
Changeset: 2445f133831e66476936703a2ec82ce6603fa5e6
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Jun 02 16:25:33 2016 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/2445f133831e66476936703a2ec82ce6603fa5e6 [^]

Related to issue 33039: Update module version

---
M src-db/database/sourcedata/AD_MODULE.xml
---
(0086951)
aferraz   
2016-06-02 17:02   
Code review OK