Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0033032Openbravo ERPA. Platformpublic2016-05-24 11:252016-06-17 19:38
alostale 
alostale 
normaltrivialhave not tried
closedfixed 
5
 
3.0PR16Q3 
caristu
Core
No
0033032: SystemValidatorTest is executed only for modules in developement
SystemValidatorTest execution results depend on which are the modules that were in development when the test was executed.

In order to be consistent it should validate all modules regardless they are currently in development or not.
1. Break some module rule (ie. remove license from a module) and set that module as not in dvelopment
2. Run SystemValidatorTest
  -> It should fail but it does not as the module is not in development
No tags attached.
related to defect 00306803.0PR16Q3 closed alostale Weld module does not pass 'ant validate.modules' 
Issue History
2016-05-24 11:25alostaleNew Issue
2016-05-24 11:25alostaleAssigned To => platform
2016-05-24 11:25alostaleModules => Core
2016-05-24 11:25alostaleTriggers an Emergency Pack => No
2016-05-24 11:26alostaleRelationship addedrelated to 0030680
2016-05-24 11:26alostaleAssigned Toplatform => alostale
2016-05-24 11:51hgbotCheckin
2016-05-24 11:51hgbotNote Added: 0086698
2016-05-24 11:51hgbotStatusnew => resolved
2016-05-24 11:51hgbotResolutionopen => fixed
2016-05-24 11:51hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/47c8c0113b41d86644016ba3f532bcd78e8f65fb [^]
2016-05-31 08:14alostaleReview Assigned To => caristu
2016-06-02 10:01hgbotCheckin
2016-06-02 10:01hgbotNote Added: 0086904
2016-06-02 16:33caristuNote Added: 0086946
2016-06-02 16:33caristuStatusresolved => closed
2016-06-02 16:33caristuFixed in Version => 3.0PR16Q3
2016-06-17 19:37hudsonbotCheckin
2016-06-17 19:37hudsonbotNote Added: 0087562
2016-06-17 19:38hudsonbotCheckin
2016-06-17 19:38hudsonbotNote Added: 0087584

Notes
(0086698)
hgbot   
2016-05-24 11:51   
Repository: erp/devel/pi
Changeset: 47c8c0113b41d86644016ba3f532bcd78e8f65fb
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue May 24 11:51:11 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/47c8c0113b41d86644016ba3f532bcd78e8f65fb [^]

fixed issue 33032: SystemValidatorTest is executed only for modules in dev

  Now all modules are set in development before executing the test and reset
  on finalization

---
M src-test/src/org/openbravo/test/system/SystemValidatorTest.java
---
(0086904)
hgbot   
2016-06-02 10:01   
Repository: erp/devel/pi
Changeset: 7566dceb3847e88f30d60e667bd3164c6d980758
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Jun 02 10:00:49 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/7566dceb3847e88f30d60e667bd3164c6d980758 [^]

related to bug 33032: fixed module reset

---
M src-test/src/org/openbravo/test/system/SystemValidatorTest.java
---
(0086946)
caristu   
2016-06-02 16:33   
Code reviewed + tested OK: SystemValidatorTest executes the test also for modules not in development status. They are also restored properly on finalization.

Verified in pi@7566dceb3847
(0087562)
hudsonbot   
2016-06-17 19:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test
(0087584)
hudsonbot   
2016-06-17 19:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test