Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033014Openbravo ERPA. Platformpublic2016-05-20 10:502016-05-20 15:13
Reporteralostale 
Assigned Toalostale 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q1.2Fixed in Version3.0PR16Q1.2 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - QA Approved
Regression date2015-11-23
Regression introduced in release3.0PR16Q1
Regression introduced by commithttp://code.openbravo.com/erp/devel/pi/rev/0533c8d6569d7ca75ba77ecb7bcb224b1ff681a1 [^]
Triggers an Emergency PackNo
Summary0033014: error in Instance Activation window when using an expired license
DescriptionWhen an instance is activated with an expired license, Instance Activation window displays an internal error in UI instead of the correct one notifying the license has expired.
Steps To ReproduceTry to activate an instance with an expired license.
  1. In UI you get the error attached as screenshot
  2. The following trace appears in log:
  java.lang.IllegalArgumentException: No enum constant org.openbravo.erpCommon.obps.ModuleLicenseRestrictions.MsgSeverity.Error
        at java.lang.Enum.valueOf(Enum.java:236)
        at org.openbravo.erpCommon.obps.ModuleLicenseRestrictions$MsgSeverity.valueOf(ModuleLicenseRestrictions.java:52)
        at org.openbravo.erpCommon.obps.ActivationKey.getActivationMessage(ActivationKey.java:842)
        at org.openbravo.erpCommon.ad_forms.InstanceManagement.printPageActive(InstanceManagement.java:326)
        at org.openbravo.erpCommon.ad_forms.InstanceManagement.doPost(InstanceManagement.java:67)
Proposed SolutionIf suffering this situation, please contact Openbravo support.
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0033012 closed alostale error in Instance Activation window when using an expired license 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-05-20 10:52alostaleTypedefect => backport
2016-05-20 10:52alostaleTarget Version => 3.0PR16Q1.2
2016-05-20 11:35hgbotCheckin
2016-05-20 11:35hgbotNote Added: 0086598
2016-05-20 11:35hgbotStatusscheduled => resolved
2016-05-20 11:35hgbotResolutionopen => fixed
2016-05-20 11:35hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR16Q1.2/rev/caf1d686ebe1aaabe4cfc5ea567b6f9425944593 [^]
2016-05-20 11:35alostaleReview Assigned To => AugustoMauch
2016-05-20 15:13AugustoMauchNote Added: 0086623
2016-05-20 15:13AugustoMauchStatusresolved => closed
2016-05-20 15:13AugustoMauchFixed in Version => 3.0PR16Q1.2

Notes
(0086598)
hgbot   
2016-05-20 11:35   
Repository: erp/backports/3.0PR16Q1.2
Changeset: caf1d686ebe1aaabe4cfc5ea567b6f9425944593
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri May 20 11:08:28 2016 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR16Q1.2/rev/caf1d686ebe1aaabe4cfc5ea567b6f9425944593 [^]

fixed bug 33014: error in Instance Activation when using an expired license

  When using a license within an erroneous state (such as expired), message severity
  was incorrectly obtained from the enum, causing an exception to be thrown.

  Fixed by using MsgSeverity.forType method instead of valueOf. forType method
  was designed with this purpose.

  In addition, some other changes have been done on MsgSeverity enum:
   * valueOf method is static so no need to invoke it on an instance (to may be
     another one, which is weird).
   * checking with actual type rather than with toString (which might change)
   * reversed comparision order to prevent NPE in case param in null

---
M src/org/openbravo/erpCommon/obps/ActivationKey.java
M src/org/openbravo/erpCommon/obps/ModuleLicenseRestrictions.java
---
(0086623)
AugustoMauch   
2016-05-20 15:13   
Code reviewed and verified in [1]@caf1d686ebe1

[1] https://code.openbravo.com/erp/backports/3.0PR16Q1.2 [^]