Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033012Openbravo ERPA. Platformpublic2016-05-20 10:502016-06-17 19:37
Reporteralostale 
Assigned Toalostale 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q3 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - QA Approved
Regression date2015-11-23
Regression introduced in release3.0PR16Q1
Regression introduced by commithttp://code.openbravo.com/erp/devel/pi/rev/0533c8d6569d7ca75ba77ecb7bcb224b1ff681a1 [^]
Triggers an Emergency PackNo
Summary0033012: error in Instance Activation window when using an expired license
DescriptionWhen an instance is activated with an expired license, Instance Activation window displays an internal error in UI instead of the correct one notifying the license has expired.
Steps To ReproduceTry to activate an instance with an expired license.
  1. In UI you get the error attached as screenshot
  2. The following trace appears in log:
  java.lang.IllegalArgumentException: No enum constant org.openbravo.erpCommon.obps.ModuleLicenseRestrictions.MsgSeverity.Error
        at java.lang.Enum.valueOf(Enum.java:236)
        at org.openbravo.erpCommon.obps.ModuleLicenseRestrictions$MsgSeverity.valueOf(ModuleLicenseRestrictions.java:52)
        at org.openbravo.erpCommon.obps.ActivationKey.getActivationMessage(ActivationKey.java:842)
        at org.openbravo.erpCommon.ad_forms.InstanceManagement.printPageActive(InstanceManagement.java:326)
        at org.openbravo.erpCommon.ad_forms.InstanceManagement.doPost(InstanceManagement.java:67)
Proposed SolutionIf suffering this situation, please contact Openbravo support.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00330133.0PR16Q2 closed alostale error in Instance Activation window when using an expired license 
depends on backport 00330143.0PR16Q1.2 closed alostale error in Instance Activation window when using an expired license 
caused by feature request 00310903.0PR16Q1 closed alostale Implement Retail licensing model 
Attached Filespng 16Q1.2.png (73,266) 2016-05-20 10:56
https://issues.openbravo.com/file_download.php?file_id=9429&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2016-05-20 10:50alostaleNew Issue
2016-05-20 10:50alostaleAssigned To => alostale
2016-05-20 10:50alostaleModules => Core
2016-05-20 10:50alostaleRegression level => Production - QA Approved
2016-05-20 10:50alostaleRegression date => 2015-11-23
2016-05-20 10:50alostaleRegression introduced in release => 3.0PR16Q1
2016-05-20 10:50alostaleRegression introduced by commit => http://code.openbravo.com/erp/devel/pi/rev/0533c8d6569d7ca75ba77ecb7bcb224b1ff681a1 [^]
2016-05-20 10:50alostaleTriggers an Emergency Pack => No
2016-05-20 10:51alostaleSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=12185#r12185
2016-05-20 10:51alostaleProposed Solution updated
2016-05-20 10:51alostaleRelationship addedcaused by 0031090
2016-05-20 10:52alostaleStatusnew => scheduled
2016-05-20 10:56alostaleFile Added: 16Q1.2.png
2016-05-20 10:56alostaleReview Assigned To => caristu
2016-05-20 11:12hgbotCheckin
2016-05-20 11:12hgbotNote Added: 0086597
2016-05-20 11:12hgbotStatusscheduled => resolved
2016-05-20 11:12hgbotResolutionopen => fixed
2016-05-20 11:12hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4a39b44ed6d01b477cadc514d77d8672531b752a [^]
2016-05-20 11:24alostaleReview Assigned Tocaristu => AugustoMauch
2016-05-20 12:20alostaleNote Added: 0086602
2016-05-20 15:12AugustoMauchNote Added: 0086621
2016-05-20 15:12AugustoMauchStatusresolved => closed
2016-05-20 15:12AugustoMauchFixed in Version => 3.0PR16Q3
2016-06-17 19:37hudsonbotCheckin
2016-06-17 19:37hudsonbotNote Added: 0087546

Notes
(0086597)
hgbot   
2016-05-20 11:12   
Repository: erp/devel/pi
Changeset: 4a39b44ed6d01b477cadc514d77d8672531b752a
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri May 20 11:08:28 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4a39b44ed6d01b477cadc514d77d8672531b752a [^]

fixed bug 33012: error in Instance Activation when using an expired license

  When using a license within an erroneous state (such as expired), message severity
  was incorrectly obtained from the enum, causing an exception to be thrown.

  Fixed by using MsgSeverity.forType method instead of valueOf. forType method
  was designed with this purpose.

  In addition, some other changes have been done on MsgSeverity enum:
   * valueOf method is static so no need to invoke it on an instance (to may be
     another one, which is weird).
   * checking with actual type rather than with toString (which might change)
   * reversed comparision order to prevent NPE in case param in null

---
M src/org/openbravo/erpCommon/obps/ActivationKey.java
M src/org/openbravo/erpCommon/obps/ModuleLicenseRestrictions.java
---
(0086602)
alostale   
2016-05-20 12:20   
Added test case to TestLink: https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-10026 [^]
(0086621)
AugustoMauch   
2016-05-20 15:12   
Code reviewed and verified in pi@4a39b44ed6d0
(0087546)
hudsonbot   
2016-06-17 19:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test