Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032998Retail ModulesSampledatapublic2016-05-19 11:422016-05-23 17:55
Reporterplujan 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product VersionRR16Q1.1 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerNo
Support ticket
Regression levelProduction - QA Approved
Regression date2015-10-08
Regression introduced in releaseRR16Q1
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/0a0131cc2224 [^]
Triggers an Emergency PackNo
Summary0032998: New user "NoLayawayUser" with role "NoLayawayRole" added to sampledata
DescriptionSample Data shipped with the product should be treated carefully. It was created with a simple link to a real world scenario (a store for mountain products), so it is not a good practice to include users and roles that are for development purposes only.
Steps To ReproduceThe new user can be seen in the main login screen
Proposed SolutionEasiest (assuming the user is not required, which it is the most probable case): Remove the user and the role from sample data.

Better (assuming the role is required but not the user): Assign the role to an existing user

Even better: Use a proper name for the role
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0033022RR16Q2 closed ranjith_qualiantech_com New user "NoLayawayUser" with role "NoLayawayRole" added to sampledata 
depends on backport 0033023RR16Q1.2 closed ranjith_qualiantech_com New user "NoLayawayUser" with role "NoLayawayRole" added to sampledata 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-05-19 11:42plujanNew Issue
2016-05-19 11:42plujanAssigned To => Retail
2016-05-19 11:42plujanOBNetwork customer => No
2016-05-19 11:42plujanRegression level => Production - QA Approved
2016-05-19 11:42plujanRegression date => 2015-10-08
2016-05-19 11:42plujanRegression introduced in release => RR16Q1
2016-05-19 11:42plujanRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/0a0131cc2224 [^]
2016-05-19 11:42plujanTriggers an Emergency Pack => No
2016-05-20 10:58OrekariaStatusnew => acknowledged
2016-05-20 12:05ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2016-05-20 12:05ranjith_qualiantech_comStatusacknowledged => scheduled
2016-05-20 12:08ranjith_qualiantech_comNote Added: 0086601
2016-05-23 08:37hgbotCheckin
2016-05-23 08:37hgbotNote Added: 0086637
2016-05-23 08:37hgbotStatusscheduled => resolved
2016-05-23 08:37hgbotResolutionopen => fixed
2016-05-23 08:37hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/a7fde4dbf013a3297c83966b135b450736816208 [^]
2016-05-23 08:38hgbotCheckin
2016-05-23 08:38hgbotNote Added: 0086638
2016-05-23 12:03marvintmStatusresolved => new
2016-05-23 12:03marvintmResolutionfixed => open
2016-05-23 12:03marvintmStatusnew => scheduled
2016-05-23 12:34marvintmStatusscheduled => resolved
2016-05-23 12:34marvintmResolutionopen => fixed
2016-05-23 17:55migueldejuanaReview Assigned To => migueldejuana
2016-05-23 17:55migueldejuanaNote Added: 0086682
2016-05-23 17:55migueldejuanaStatusresolved => closed

Notes
(0086601)
ranjith_qualiantech_com   
2016-05-20 12:08   
Layaway user and role has been used in the test to validate to access the layaway terminal or not.
Antonio requested to disable the Layaway user and role by default(in sample data) and activate it whenever it is needed
(0086637)
hgbot   
2016-05-23 08:37   
Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: a7fde4dbf013a3297c83966b135b450736816208
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon May 23 12:07:21 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/a7fde4dbf013a3297c83966b135b450736816208 [^]

Fixes issue 32998 : Deactivating "NoLayaway" User & Role

---
M referencedata/sampledata/The_White_Valley_Group/AD_ROLE.xml
M referencedata/sampledata/The_White_Valley_Group/AD_USER.xml
---
(0086638)
hgbot   
2016-05-23 08:38   
Repository: tools/automation/pi-mobile
Changeset: 4acc4acd63b26a2692dcd44c1d12118f22ef9bbb
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon May 23 12:07:10 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/4acc4acd63b26a2692dcd44c1d12118f22ef9bbb [^]

Verifies issue 32998 : Modified automated test 'I31062_CheckValidationForNonLayawayAllowedUsers'

I31062_CheckValidationForNonLayawayAllowedUsers - Activated user "NoLayawayUser" for test

---
M src-test/org/openbravo/test/mobile/common/selenium/javascript/TestId.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I31062_CheckValidationForNonLayawayAllowedUsers.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/loginout/I32347_VerifyLogInUserStatusImage.java
---
(0086682)
migueldejuana   
2016-05-23 17:55   
Reviewed