Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032996Retail ModulesWeb POSpublic2016-02-17 17:322016-06-03 14:53
Reporteradrianromero 
Assigned Toadrianromero 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q2Fixed in VersionRR16Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032996: Taxes at document level are not properly calculated in some cases
DescriptionIn the case of price including taxes and taxes at document level there are cases where taxes are not properly calculated:

For example:
1 x 6.50
1 x 6.50
1 x 5.90
1 x 5.90
Total 24.80

If all products have a tax of 20%, POS calculates taxable amount 20.68 and tax amount 4.12

This is wrong, the expected values are: taxable amount 20.67 and tax amount 4.13
Steps To ReproduceIn Description
Proposed SolutionAttached export file fixes the calculation at document level but only for orders. It does not fix cashup taxes calculation.
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0032264 closed adrianromero Taxes at document level are not properly calculated in some cases 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-05-19 10:45OrekariaTypedefect => backport
2016-05-19 10:45OrekariaTarget Version => RR16Q2
2016-05-23 14:21hgbotCheckin
2016-05-23 14:21hgbotNote Added: 0086663
2016-05-23 14:21hgbotStatusscheduled => resolved
2016-05-23 14:21hgbotResolutionopen => fixed
2016-05-23 14:21hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/98fe075ba7222439c42f598ae14cc06df258ebd3 [^] => http://code.openbravo.com/retail/backports/3.0RR16Q2/org.openbravo.retail.posterminal/rev/481b85386b3f9aee1751091a018a26f3382bf57c [^]
2016-05-23 14:21hgbotCheckin
2016-05-23 14:21hgbotNote Added: 0086664
2016-05-23 14:21hgbotFixed in SCM revisionhttp://code.openbravo.com/retail/backports/3.0RR16Q2/org.openbravo.retail.posterminal/rev/481b85386b3f9aee1751091a018a26f3382bf57c [^] => http://code.openbravo.com/retail/backports/3.0RR16Q2/org.openbravo.retail.posterminal/rev/7beecef0e1a6a2ab96407b44bca243bfcdad2c6d [^]
2016-05-23 14:21hgbotCheckin
2016-05-23 14:21hgbotNote Added: 0086665
2016-05-23 14:21hgbotFixed in SCM revisionhttp://code.openbravo.com/retail/backports/3.0RR16Q2/org.openbravo.retail.posterminal/rev/7beecef0e1a6a2ab96407b44bca243bfcdad2c6d [^] => http://code.openbravo.com/retail/backports/3.0RR16Q2/org.openbravo.retail.posterminal/rev/de41e608f93405f5ef812aeb09811e89bd70554c [^]
2016-05-23 14:22hgbotCheckin
2016-05-23 14:22hgbotNote Added: 0086666
2016-05-23 14:22hgbotFixed in SCM revisionhttp://code.openbravo.com/retail/backports/3.0RR16Q2/org.openbravo.retail.posterminal/rev/de41e608f93405f5ef812aeb09811e89bd70554c [^] => http://code.openbravo.com/retail/backports/3.0RR16Q2/org.openbravo.retail.posterminal/rev/77015a2b51f953705f6cb91a29aa9f044df9a05d [^]
2016-05-23 16:22hgbotCheckin
2016-05-23 16:22hgbotNote Added: 0086669
2016-05-23 16:23hgbotCheckin
2016-05-23 16:23hgbotNote Added: 0086670
2016-05-23 16:23hgbotCheckin
2016-05-23 16:23hgbotNote Added: 0086671
2016-05-23 16:23hgbotCheckin
2016-05-23 16:23hgbotNote Added: 0086672
2016-05-23 16:23hgbotCheckin
2016-05-23 16:23hgbotNote Added: 0086673
2016-05-23 16:23hgbotCheckin
2016-05-23 16:23hgbotNote Added: 0086674
2016-06-03 14:53marvintmStatusresolved => closed
2016-06-03 14:53marvintmFixed in Version => RR16Q2

Notes
(0086663)
hgbot   
2016-05-23 14:21   
Repository: retail/backports/3.0RR16Q2/org.openbravo.retail.posterminal
Changeset: 481b85386b3f9aee1751091a018a26f3382bf57c
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Feb 18 18:50:06 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q2/org.openbravo.retail.posterminal/rev/481b85386b3f9aee1751091a018a26f3382bf57c [^]

Fixes issue 0032996: Taxes at document level are not properly calculated in some cases

---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0086664)
hgbot   
2016-05-23 14:21   
Repository: retail/backports/3.0RR16Q2/org.openbravo.retail.posterminal
Changeset: 7beecef0e1a6a2ab96407b44bca243bfcdad2c6d
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Feb 25 09:48:37 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q2/org.openbravo.retail.posterminal/rev/7beecef0e1a6a2ab96407b44bca243bfcdad2c6d [^]

Fixes issue 0032996: Taxes at document level are not properly calculated in some cases32996
Implementing taxes at document adjustments in price not including taxes

---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
---
(0086665)
hgbot   
2016-05-23 14:21   
Repository: retail/backports/3.0RR16Q2/org.openbravo.retail.posterminal
Changeset: de41e608f93405f5ef812aeb09811e89bd70554c
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Feb 25 13:01:07 2016 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR16Q2/org.openbravo.retail.posterminal/rev/de41e608f93405f5ef812aeb09811e89bd70554c [^]

Fixes issue 0032996: Taxes at document level are not properly calculated in some cases
* Complete implementation of adjustments in taxes not including taxes

---
M web/org.openbravo.retail.posterminal/js/data/dataordertaxes.js
---
(0086666)
hgbot   
2016-05-23 14:22   
Repository: retail/backports/3.0RR16Q2/org.openbravo.retail.posterminal
Changeset: 77015a2b51f953705f6cb91a29aa9f044df9a05d
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu May 12 13:31:50 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q2/org.openbravo.retail.posterminal/rev/77015a2b51f953705f6cb91a29aa9f044df9a05d [^]

Fixes issue 0032996: Taxes at document level are not properly calculated in some cases
* Adjust cashup taxes to match that net + taxes = gross for returns and for sales

---
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
---
(0086669)
hgbot   
2016-05-23 16:22   
Repository: tools/automation/pi-mobile
Changeset: 7f80d4df5755e0ab8c5d717e27aab19d5ec4e57c
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Fri Feb 19 15:45:34 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/7f80d4df5755e0ab8c5d717e27aab19d5ec4e57c [^]

Related to issue 0032996: Taxes at document level are not properly calculated in some cases
* Adjustment of previous taxes amounts
* New tests

---
M src-test/org/openbravo/test/mobile/common/selenium/javascript/APIs/MobileCoreAPI.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/CashupRecoverLastCashup.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/CashupWithInitialAmount.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/CashupWithSaleAndReturn.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/I29153_CashupWithSaleAndReturnRetrieveFromServer.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I28100_DiscountsNotAppliedToReturnLinesII.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I28164_DiscountsRemovedWhenReturnPresentI.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I28164_DiscountsRemovedWhenReturnPresentII.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/initialchecks/VerifySimpleReturn.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/VerifiedReturnProductsNotInAssortment.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/CreateSaleAndCheckTaxes.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/CreateSaleWithBOMTaxes.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/CreateSaleAndCheckTaxes20.java
---
(0086670)
hgbot   
2016-05-23 16:23   
Repository: tools/automation/pi-mobile
Changeset: ac3d6d0363c15b59f05fdc0c481389f7ec95cd48
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Feb 25 10:03:48 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/ac3d6d0363c15b59f05fdc0c481389f7ec95cd48 [^]

Related to issue 0032996: Taxes at document level are not properly calculated in some cases

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/CreateSaleAndCheckTaxes20.java
---
(0086671)
hgbot   
2016-05-23 16:23   
Repository: tools/automation/pi-mobile
Changeset: d891f0987854afe588f20f60f048ce398989e1d1
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Wed May 11 16:56:15 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/d891f0987854afe588f20f60f048ce398989e1d1 [^]

Related to issue 0032996: Taxes at document level are not properly calculated in some cases
* Fixes taxes verifications to the appropiate values

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/multipricelists/I32217_MPLDiscountOnlyForOneCustomerAndDifferentTaxes.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/multipricelists/MPLDiscountsWithPriceIncludeTaxes.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/CreateSaleAndCheckTaxes.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/CreateSaleWithBOMTaxes.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sharedpaymentmethods/SPMDiscountsWithPriceIncludeTaxes.java
---
(0086672)
hgbot   
2016-05-23 16:23   
Repository: tools/automation/pi-mobile
Changeset: 8e0d6d35d9c98656e9b0ff2b443dc5e1007db78d
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu May 12 13:33:31 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/8e0d6d35d9c98656e9b0ff2b443dc5e1007db78d [^]

Related to issue 0032996: Taxes at document level are not properly calculated in some cases
* Adjust cashup values for taxes

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashup/CashupWithOverpayment.java
---
(0086673)
hgbot   
2016-05-23 16:23   
Repository: tools/automation/pi-mobile
Changeset: 35cbdec5967148e96104ea636bf310e4c2397fd7
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Fri May 13 09:20:35 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/35cbdec5967148e96104ea636bf310e4c2397fd7 [^]

Related to issue 0032996: Taxes at document level are not properly calculated in some cases
* A new rounding adjustment in test

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sharedpaymentmethods/SPMDiscountsWithPriceIncludeTaxes.java
---
(0086674)
hgbot   
2016-05-23 16:23   
Repository: tools/automation/pi-mobile
Changeset: f0e740f7a3521388bb20f19922406ccdd388ec56
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Tue May 17 14:07:56 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/f0e740f7a3521388bb20f19922406ccdd388ec56 [^]

Related to issue 0032996: Taxes at document level are not properly calculated in some cases
* Adjusting test for taxes at document level that has differences if calculated at line level

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/CreateSaleAndCheckTaxesAtDocLevel.java
R src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/CreateSaleAndCheckTaxes20.java
---