Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032991Openbravo ERPA. Platformpublic2016-05-18 17:022016-08-11 18:40
Reporteralostale 
Assigned ToNaroaIriarte 
PrioritynormalSeveritytrivialReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q4 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032991: remove unused class org.openbravo.erpCommon.ad_process.Register
DescriptionNot useful as all its code is commented out.

Note it might have mappings that should also be removed.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0032688 acknowledged Triage Platform Base remove unused resources 
related to feature request 00068782.50 closed anthony_wolski Modify Registration process to link to an external registration site 
related to defect 0033430 closed NaroaIriarte API change because the Register.java has been deleted and AD_MODEL_OBJECT_MAPPING.xml and AD_MODEL_OBJECT.xml have been modifi 
Attached Files? issue32991.export (11,499) 2016-06-29 15:35
https://issues.openbravo.com/file_download.php?file_id=9598&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-05-18 17:02alostaleNew Issue
2016-05-18 17:02alostaleAssigned To => NaroaIriarte
2016-05-18 17:02alostaleModules => Core
2016-05-18 17:02alostaleTriggers an Emergency Pack => No
2016-05-18 17:02alostaleRelationship addedrelated to 0032688
2016-05-18 17:03alostaleRelationship addedrelated to 0006878
2016-05-18 17:53NaroaIriarteStatusnew => acknowledged
2016-05-31 12:10NaroaIriarteReview Assigned To => alostale
2016-06-29 10:06NaroaIriarteStatusacknowledged => scheduled
2016-06-29 15:35NaroaIriarteFile Added: issue32991.export
2016-06-29 15:38NaroaIriarteNote Added: 0088084
2016-07-05 16:00hgbotCheckin
2016-07-05 16:00hgbotNote Added: 0088215
2016-07-05 16:04hgbotCheckin
2016-07-05 16:04hgbotNote Added: 0088217
2016-07-05 16:04hgbotStatusscheduled => resolved
2016-07-05 16:04hgbotResolutionopen => fixed
2016-07-05 16:04hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b54f7cedf5a530c83f336aef0afc515444421f52 [^]
2016-07-08 08:28alostaleRelationship addedrelated to 0033430
2016-07-08 08:29alostaleNote Added: 0088314
2016-07-08 08:29alostaleStatusresolved => closed
2016-07-08 08:29alostaleFixed in Version => 3.0PR16Q4
2016-08-11 18:40hudsonbotCheckin
2016-08-11 18:40hudsonbotNote Added: 0088989

Notes
(0088084)
NaroaIriarte   
2016-06-29 15:38   
The patch with the fix has been attached.
Note that the issue deletes a Java class and it is an API change, so when going to push it, it is necessary to follow all the api changes process before. (Pushing the japi to API-CHECKS, writing the api change in the wiki and sending the email.)
(0088215)
hgbot   
2016-07-05 16:00   
Repository: erp/devel/api-checks
Changeset: ca90780da6fdbccb0270def0ac2e07e21cc15b06
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Tue Jul 05 15:34:58 2016 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/ca90780da6fdbccb0270def0ac2e07e21cc15b06 [^]

Fixed issue 33430: API change for issue 32991.

The issue 32991 removes the unused Register.java and modifies
some records of the AD_MODEL_OBJECT.xml and AD_MODEL_OBJECT_MAPPING.xml.
These changes are an API change.

---
M java/reference/java.japi.gz
M model/src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M model/src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
---
(0088217)
hgbot   
2016-07-05 16:04   
Repository: erp/devel/pi
Changeset: b54f7cedf5a530c83f336aef0afc515444421f52
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Wed Jun 29 11:00:58 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b54f7cedf5a530c83f336aef0afc515444421f52 [^]

Fixed issue 32991: The unused class Register has been deleted

The unused class Registe has been deleted and all the mappings
which referenced it too.

---
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
R src/org/openbravo/erpCommon/ad_process/Register.java
---
(0088314)
alostale   
2016-07-08 08:29   
code reviewed
(0088989)
hudsonbot   
2016-08-11 18:40   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/edaa05b1fb18 [^]
Maturity status: Test