Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032976Retail ModulesGift cards and gift voucherspublic2016-05-17 18:252017-11-02 12:01
Reportermarvintm 
Assigned Tomario_castello 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q3 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032976: Gift cards module defines wrong entry in web.xml, which makes it incompatible with JBoss
DescriptionCurrently, the gift cards module defines an entry in the "Ad implementation mapping" window, for a class which doesn't exist. This creates a wrong entry in the web.xml file when the application is compiled.

This doesn't have any apparent consequence on Tomcat unless the user makes an explicit request to the wrong path, but in JBoss application server, this causes the starting process of the server to fail.
Steps To Reproduce- Install the gift cards module.
- Go to AD Implementation mapping window, and search for the class: org.openbravo.retail.giftcards.info.SalesOrderforGiftCards. Notice that there is an entry for it.
- Go to sources, and look for that class. Notice that it doesn't exist.
Proposed SolutionThe AD Implementation mapping entry should be deleted, as it seems to serve no useful purpose, and it causes problems as the class it refers to doesn't exist. It's related mapping, and parameters (if they exist) should also be deleted.
Additional Information
TagsNo tags attached.
Relationships
related to feature request 00325123.0PR17Q1 closed alostale Openbravo ERP support WildFly 10 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-05-17 18:25marvintmNew Issue
2016-05-17 18:25marvintmAssigned To => Retail
2016-05-17 18:25marvintmTriggers an Emergency Pack => No
2016-05-17 20:39shuehnerNote Added: 0086510
2016-05-23 10:54OrekariaStatusnew => acknowledged
2016-05-25 16:15mario_castelloAssigned ToRetail => mario_castello
2016-05-25 16:15mario_castelloStatusacknowledged => scheduled
2016-05-25 21:50hgbotCheckin
2016-05-25 21:50hgbotNote Added: 0086760
2016-05-25 21:50hgbotStatusscheduled => resolved
2016-05-25 21:50hgbotResolutionopen => fixed
2016-05-25 21:50hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/39a2ad5af38d1a382f52cb683b3c71cd49307da0 [^]
2016-06-02 19:34marvintmNote Added: 0086958
2016-06-02 19:34marvintmStatusresolved => new
2016-06-02 19:34marvintmResolutionfixed => open
2016-06-02 19:34marvintmStatusnew => scheduled
2016-06-03 22:03hgbotCheckin
2016-06-03 22:03hgbotNote Added: 0086998
2016-06-03 22:03hgbotStatusscheduled => resolved
2016-06-03 22:03hgbotResolutionopen => fixed
2016-06-03 22:03hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/39a2ad5af38d1a382f52cb683b3c71cd49307da0 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.warehouse/rev/e9fc2019f7dbf004ee767bbba75c2eaca35a38f9 [^]
2016-06-03 22:06hgbotCheckin
2016-06-03 22:06hgbotNote Added: 0086999
2016-06-08 11:31guilleaerReview Assigned To => guilleaer
2016-06-08 11:31guilleaerStatusresolved => closed
2016-06-08 11:31guilleaerFixed in Version => RR16Q3
2017-11-02 12:01alostaleRelationship addedrelated to 0032512

Notes
(0086510)
shuehner   
2016-05-17 20:39   
Note: there seem to be more issues like this.

https://ci.openbravo.com/job/mod-simple/2124/testReport/junit/org.openbravo.test.model/ClassLoaderTest/testModelObject/ [^]

New retail-modules job. That specific testCase looks afaik exactly for this case.

And it showing <4> means there are 4 files which can't be loaded.
(0086760)
hgbot   
2016-05-25 21:50   
Repository: erp/pmods/org.openbravo.retail.giftcards
Changeset: 39a2ad5af38d1a382f52cb683b3c71cd49307da0
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Wed May 25 13:03:27 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/39a2ad5af38d1a382f52cb683b3c71cd49307da0 [^]

Fixed issue 32976: Delete Mapping definition for SalesOrderforGiftCards class that not exist in module

---
R src-db/database/sourcedata/AD_MODEL_OBJECT.xml
R src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
---
(0086958)
marvintm   
2016-06-02 19:34   
Unfortunately, there are still two incorrect entries, which need to be fixed:

ERROR org.openbravo.test.model.ClassLoaderTest - 55ED7732356D4039ADB30FAA90937B21 : org.openbravo.pricing.levelpricing.info.ProductPrice
ERROR org.openbravo.test.model.ClassLoaderTest - 8830DF6E02344796826095237152BFEC : org.openbravo.mobile.warehouse.Operations
(0086998)
hgbot   
2016-06-03 22:03   
Repository: erp/pmods/org.openbravo.mobile.warehouse
Changeset: e9fc2019f7dbf004ee767bbba75c2eaca35a38f9
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Fri Jun 03 14:02:42 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.warehouse/rev/e9fc2019f7dbf004ee767bbba75c2eaca35a38f9 [^]

Fixed issue 32976: Delete Mapping definition for WarehouseMobileOperations class that not exist in module

---
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
---
(0086999)
hgbot   
2016-06-03 22:06   
Repository: erp/pmods/org.openbravo.pricing.levelpricing
Changeset: 4a582c9d9d1e43331b5ea6625c92aab9681751df
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Fri Jun 03 14:06:22 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.pricing.levelpricing/rev/4a582c9d9d1e43331b5ea6625c92aab9681751df [^]

Related to issue 32976: Delete Mapping definition for ProductPrice class that not exist in module org.openbravo.pricing.levelpricing

---
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
---