Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032972Retail ModulesDiscounts and Promotionspublic2016-05-17 12:452016-06-14 09:23
Reporterjorge-garcia 
Assigned Tojorge-garcia 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032972: [Consistency] Promotions shouldn't split lines if not necessary.
DescriptionEven if the user add a pack from the browse tab or add the products manually, the information of the ticket must be the same.
Steps To ReproduceGo to WebPOS
 Add a pack of type "Camping Pack"
 Add a pack of type "Camping Pack Plus"
 Check that the packs are split in different lines.
 Delete the receipt and create new one.
 Go to tab search and add:
  Four units of "Down sleeping bag 500"
  Two units of "Expedition tent 4 season 2 person"
  One unit of "Camel bak 3 L"
 Check, when the discounts are applied, that the lines are not split but both promotions have been applied and share the same lines. (This is the right scenario).
Proposed SolutionThe new pattern that Retail team propose is to merge the lines in all cases and also merge the promotions, except in those cases that don't make sense (i.e. Non grouped products or lines split by the user manually).
Additional Information
TagsNo tags attached.
Relationships
related to defect 0033253 acknowledged Retail Wrong promotion applied with priority packs 
related to defect 0033941 closed adrianromero [SER-QA 1727] Error when selling a pack that contains a product with Item declaration 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-05-17 12:45jorge-garciaNew Issue
2016-05-17 12:45jorge-garciaAssigned To => jorge-garcia
2016-05-17 12:45jorge-garciaTriggers an Emergency Pack => No
2016-05-25 10:06hgbotCheckin
2016-05-25 10:06hgbotNote Added: 0086722
2016-05-25 11:41hgbotCheckin
2016-05-25 11:41hgbotNote Added: 0086739
2016-05-25 11:41hgbotStatusnew => resolved
2016-05-25 11:41hgbotResolutionopen => fixed
2016-05-25 11:41hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/06fce121bb480bc74b0410e5f36d30e7ce74ee92 [^]
2016-06-13 11:11marvintmNote Added: 0087193
2016-06-13 11:11marvintmStatusresolved => new
2016-06-13 11:11marvintmResolutionfixed => open
2016-06-13 11:11marvintmStatusnew => scheduled
2016-06-14 09:11jorge-garciaRelationship addedrelated to 0033253
2016-06-14 09:11jorge-garciaStatusscheduled => resolved
2016-06-14 09:11jorge-garciaFixed in Version => RR16Q3
2016-06-14 09:11jorge-garciaResolutionopen => fixed
2016-06-14 09:23jorge-garciaReview Assigned To => marvintm
2016-06-14 09:23jorge-garciaNote Added: 0087226
2016-06-14 09:23jorge-garciaStatusresolved => closed
2016-09-27 07:59ranjith_qualiantech_comRelationship addedrelated to 0034076
2016-09-27 07:59ranjith_qualiantech_comRelationship deletedrelated to 0034076
2016-09-27 07:59ranjith_qualiantech_comRelationship addedrelated to 0033941

Notes
(0086722)
hgbot   
2016-05-25 10:06   
Repository: erp/pmods/org.openbravo.retail.discounts.combo
Changeset: b6163ac953d0875a4bef1aef42b890039268eaee
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue May 17 13:52:18 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.combo/rev/b6163ac953d0875a4bef1aef42b890039268eaee [^]

Related to issue 32972: [Consistency] Promotions shouldn't split lines if not
necessary.

Combos is another promotion that implements the split line functionality inside
the rule implementation.
Now, the products are merge instead of being separated by the rule itself.

---
M web/org.openbravo.retail.discounts.combo/source/combo-rule-impl.js
---
(0086739)
hgbot   
2016-05-25 11:41   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 06fce121bb480bc74b0410e5f36d30e7ce74ee92
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue May 17 13:49:44 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/06fce121bb480bc74b0410e5f36d30e7ce74ee92 [^]

Fixed issue 32972: [Consistency] Promotions shouldn't split lines if not
necessary.

The pack is one of the promotions that works different if it's added by the
Pack button or adding the products manually.

The problem was that, in some ocassion, a pack id is set in the line avoiding
the merge of the lines.

Now is consistent and merge the lines of the products.

---
M web/org.openbravo.retail.discounts/js/promotion-pack.js
---
(0087193)
marvintm   
2016-06-13 11:11   
There is currently a problem with packs: when you have more than one pack for the same product, and they have priorities, if using the UI to add a pack with lesser priority (using the "Pack" section of the BROWSE, so not adding the individual products directly), the ticket should still get this pack, and not the pack with greater priority.

Currently, you always get the pack with greater priority, which is not correct.
(0087226)
jorge-garcia   
2016-06-14 09:23   
The fix of this issue doesn't broke the case of the previous note. A new issue related has been created and this issue will be closed.