Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032971Retail ModulesDiscounts and Promotionspublic2016-05-17 12:352016-06-15 19:13
Reporterjorge-garcia 
Assigned Tojorge-garcia 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032971: It could be nice to show to the user the number of times that a promotions has been applied
DescriptionWhen we generate more than one discount instance
Steps To ReproduceGo to WebPOS
 Go to tab search and add 6 Bottle 1L
 Check a promotion of "3x2 - Bottles" has been applied.
 Check the amount discounted is "19.00" (9.50 x 2).
 
*It could be better if the number of discount instances is shown.
 
Proposed SolutionShow the number of discount instances (also know as chunks) are applied.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-05-17 12:35jorge-garciaNew Issue
2016-05-17 12:35jorge-garciaAssigned To => jorge-garcia
2016-05-17 12:35jorge-garciaOBNetwork customer => No
2016-05-17 12:35jorge-garciaTriggers an Emergency Pack => No
2016-05-17 13:46jorge-garciaStatusnew => scheduled
2016-05-25 10:06hgbotCheckin
2016-05-25 10:06hgbotNote Added: 0086721
2016-05-25 10:06hgbotCheckin
2016-05-25 10:06hgbotNote Added: 0086723
2016-05-25 11:38hgbotCheckin
2016-05-25 11:38hgbotNote Added: 0086733
2016-05-25 11:38hgbotCheckin
2016-05-25 11:38hgbotNote Added: 0086734
2016-05-25 11:40hgbotCheckin
2016-05-25 11:40hgbotNote Added: 0086736
2016-05-25 11:40hgbotStatusscheduled => resolved
2016-05-25 11:40hgbotResolutionopen => fixed
2016-05-25 11:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/119f8383bf62ba8e97ffaf198d7a7fa0970f3b82 [^]
2016-05-25 11:41hgbotCheckin
2016-05-25 11:41hgbotNote Added: 0086738
2016-06-14 11:54dmitry_mezentsevNote Added: 0087244
2016-06-15 19:13marvintmReview Assigned To => marvintm
2016-06-15 19:13marvintmStatusresolved => closed

Notes
(0086721)
hgbot   
2016-05-25 10:06   
Repository: erp/pmods/org.openbravo.retail.discounts.combo
Changeset: 7ff127b75035f12728f26cdaa42fb740ea5b8615
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue May 17 13:34:49 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.combo/rev/7ff127b75035f12728f26cdaa42fb740ea5b8615 [^]

Related to issue 32971: It could be nice to show to the user the number of times
that a promotions has been applied

For combos, we have added the number of instances applied to the ticket.

---
M web/org.openbravo.retail.discounts.combo/source/combo-rule-impl.js
---
(0086723)
hgbot   
2016-05-25 10:06   
Repository: erp/pmods/org.openbravo.retail.discount.twofamiliescombo
Changeset: 45bc1cb97bb9a041aa1109b7adceea0f19e77d0a
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue May 17 13:35:47 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discount.twofamiliescombo/rev/45bc1cb97bb9a041aa1109b7adceea0f19e77d0a [^]

Related to issue 32971: It could be nice to show to the user the number of times
that a promotions has been applied

For two families combo, we have added the number of instances applied to the
ticket.

---
M web/org.openbravo.retail.discount.twofamiliescombo/source/twofamilies-rule-impl.js
---
(0086733)
hgbot   
2016-05-25 11:38   
Repository: tools/automation/pi-mobile
Changeset: 9fc36e95cb95985313119b47365d15680d37fd74
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue May 17 17:00:04 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/9fc36e95cb95985313119b47365d15680d37fd74 [^]

Related to issue 32971: It could be nice to show to the user the number of times
that a promotions has been applied

Some changes are necessary in the test:
I32526_TwoFamiliesWithSameTwoProducts
I32421_TwoFamiliesWithSameProduct

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_twofamilies/I32421_TwoFamiliesWithSameProduct.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_twofamilies/I32526_TwoFamiliesWithSameTwoProducts.java
---
(0086734)
hgbot   
2016-05-25 11:38   
Repository: tools/automation/pi-mobile
Changeset: a7b02eea5b718cb842dd8a9a5d4447fac2ac576c
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon May 23 10:56:03 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/a7b02eea5b718cb842dd8a9a5d4447fac2ac576c [^]

Related to issue 32971: It could be nice to show to the user the number of times
that a promotions has been applied

Some change requires to be changed:
 *Communit6781_BuyXPayYSameProduct
 *Communit6782_BuyXPayYDifferentProductCheapest_I
 *Communit6785_BuyXGetYGiftNotDistributed
 *I28120_SameProductInTwoPacks
 *I30542_BuyXPayYDiffProd_Average
 *I30542_BuyXPayYDiffProd_Lowest
 *I30542_BuyXPayYDiffProd_LowestDistrib
 *I30542_BuyXPayYDiffProd_MostExpensive
 *MultiPromotions_BuyXPayYDiffProducts_AverageI
 *MultiPromotions_BuyXPayYDiffProducts_AverageII
 *MultiPromotions_BuyXPayYDiffProducts_LowestDistributedI
 *MultiPromotions_BuyXPayYDiffProducts_LowestDistributedII
 *MultiPromotions_BuyXPayYDiffProducts_LowestI
 *MultiPromotions_BuyXPayYDiffProducts_LowestII
 *MultiPromotions_BuyXPayYDiffProducts_MostExpensiveI
 *MultiPromotions_BuyXPayYDiffProducts_MostExpensiveII

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/Communit6781_BuyXPayYSameProduct.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/Communit6782_BuyXPayYDifferentProductCheapest_I.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/Communit6785_BuyXGetYGiftNotDistributed.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I28120_SameProductInTwoPacks.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I30542_BuyXPayYDiffProd_Average.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I30542_BuyXPayYDiffProd_Lowest.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I30542_BuyXPayYDiffProd_LowestDistrib.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I30542_BuyXPayYDiffProd_MostExpensive.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/MultiPromotions_BuyXPayYDiffProducts_AverageI.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/MultiPromotions_BuyXPayYDiffProducts_AverageII.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/MultiPromotions_BuyXPayYDiffProducts_LowestDistributedI.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/MultiPromotions_BuyXPayYDiffProducts_LowestDistributedII.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/MultiPromotions_BuyXPayYDiffProducts_LowestI.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/MultiPromotions_BuyXPayYDiffProducts_LowestII.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/MultiPromotions_BuyXPayYDiffProducts_MostExpensiveI.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/MultiPromotions_BuyXPayYDiffProducts_MostExpensiveII.java
---
(0086736)
hgbot   
2016-05-25 11:40   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 119f8383bf62ba8e97ffaf198d7a7fa0970f3b82
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue May 17 13:29:48 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/119f8383bf62ba8e97ffaf198d7a7fa0970f3b82 [^]

Fixed issue 32971: It could be nice to show to the user the number of times
that a promotions has been applied

In posterminal two changes are necessary:
* Allow to define the number of chunks (instance of a promotion) applied.
* Show the number of instances in the ticket.

---
M web/org.openbravo.retail.posterminal/js/components/renderorderline.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0086738)
hgbot   
2016-05-25 11:41   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: ef4af813b2f6e2340b860e847fcd75e1b28558e3
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue May 17 13:32:57 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/ef4af813b2f6e2340b860e847fcd75e1b28558e3 [^]

Related to issue 32971: It could be nice to show to the user the number of times
that a promotions has been applied

In discounts module, it has change these rules implementations:
* Buy X Pay Y different products
* Buy X Pay Y same products
* Buy X Gift Y
* Packs

The only change necessary here is to define in the promotions the number of
instances of that promotion applied.

---
M web/org.openbravo.retail.discounts/js/promotion-XYdifferentProduts.js
M web/org.openbravo.retail.discounts/js/promotion-XYsameProduct.js
M web/org.openbravo.retail.discounts/js/promotion-buyXgiftY.js
M web/org.openbravo.retail.discounts/js/promotion-pack.js
---
(0087244)
dmitry_mezentsev   
2016-06-14 11:54   
Not closed for 20 days!