Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032962Retail ModulesWeb POSpublic2016-05-16 12:382016-06-27 08:59
Reporteramayavicente 
Assigned Tomario_castello 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032962: [SERQA 1095] Promotions are shown although their products are not included in the assorment
DescriptionSome promotions are shown in WebPOS although their products are not included in the assorment, as packs and combos. It is not possible to sell them, but they shouldn't appear.
Steps To Reproduce1. Create a new assorment, only including the product Adhesive body warmers.
2. For the store Vall Blanca Store, change the assorment to the new one.
3. Login in the terminal VBS-1
4. In the search panel, search all.
ERROR: Some promotions are displayed although theirs products are not included in the assorment. At least, It happends for packs and combos.
Proposed SolutionPromotions should not be shown if their products are not included in the assorment.
Additional Information
TagsSER-QA
Relationships
related to design defect 0052716 scheduled Retail Performance issue with masterdata query: DiscountFilterProduct 
causes defect 0035254 closed ranjith_qualiantech_com discount is not applied when some product is not included in assortment 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-05-16 12:38amayavicenteNew Issue
2016-05-16 12:38amayavicenteAssigned To => Retail
2016-05-16 12:38amayavicenteResolution time => 1464559200
2016-05-16 12:38amayavicenteTriggers an Emergency Pack => No
2016-05-16 12:39amayavicenteTag Attached: SER-QA
2016-05-16 14:30OrekariaStatusnew => acknowledged
2016-05-17 16:45mario_castelloAssigned ToRetail => mario_castello
2016-05-18 21:50mario_castelloStatusacknowledged => scheduled
2016-06-08 17:52hgbotCheckin
2016-06-08 17:52hgbotNote Added: 0087096
2016-06-08 17:56hgbotCheckin
2016-06-08 17:56hgbotNote Added: 0087098
2016-06-08 17:56hgbotStatusscheduled => resolved
2016-06-08 17:56hgbotResolutionopen => fixed
2016-06-08 17:56hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/dd218e7a783ba5afafd379c786db2f6fd410304c [^]
2016-06-08 17:58mario_castelloNote Edited: 0087098bug_revision_view_page.php?bugnote_id=0087098#r12337
2016-06-10 14:43marvintmReview Assigned To => marvintm
2016-06-10 14:43marvintmStatusresolved => closed
2016-06-15 15:55hgbotCheckin
2016-06-15 15:55hgbotNote Added: 0087310
2016-06-22 13:52marvintmNote Added: 0087792
2016-06-22 13:52marvintmStatusclosed => new
2016-06-22 13:52marvintmResolutionfixed => open
2016-06-22 13:52marvintmStatusnew => scheduled
2016-06-27 08:17hgbotCheckin
2016-06-27 08:17hgbotNote Added: 0087935
2016-06-27 08:17hgbotCheckin
2016-06-27 08:17hgbotNote Added: 0087936
2016-06-27 08:17hgbotStatusscheduled => resolved
2016-06-27 08:17hgbotResolutionopen => fixed
2016-06-27 08:17hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/dd218e7a783ba5afafd379c786db2f6fd410304c [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2d78f3791e47c42fd0f37933685a9726f7244fbd [^]
2016-06-27 08:59marvintmStatusresolved => closed
2017-02-14 10:53ranjith_qualiantech_comRelationship addedcauses 0035254
2023-06-21 14:13ranjith_qualiantech_comRelationship addedrelated to 0052716

Notes
(0087096)
hgbot   
2016-06-08 17:52   
Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: d5cec71e98d194ada2631b55f40822486cd5301f
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Fri Jun 03 10:22:58 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/d5cec71e98d194ada2631b55f40822486cd5301f [^]

Related to issue 32962: Added promotion pack to Category Tree Store

---
M referencedata/sampledata/The_White_Valley_Group/M_OFFER.xml
M referencedata/sampledata/The_White_Valley_Group/M_OFFER_PRODUCT.xml
---
(0087098)
hgbot   
2016-06-08 17:56   
(edited on: 2016-06-08 17:58)
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: dd218e7a783ba5afafd379c786db2f6fd410304c
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Wed May 18 11:02:10 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/dd218e7a783ba5afafd379c786db2f6fd410304c [^]

Fixed issue 32962: Added changes to hql in product master data to load only pack that related to active product in assortment list

Added changes to hql in Category master data
Added changes to hql in Discount master data

---
M src/org/openbravo/retail/posterminal/master/Category.java
M src/org/openbravo/retail/posterminal/master/Discount.java
M src/org/openbravo/retail/posterminal/master/Product.java
---
(0087310)
hgbot   
2016-06-15 15:55   
Repository: tools/automation/pi-mobile
Changeset: 56808dd36e92a606f325a62d03b90b59ca090e1f
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Wed Jun 15 07:55:00 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/56808dd36e92a606f325a62d03b90b59ca090e1f [^]

Verifies issue 32962: Added automated test

---
A src-test/org/openbravo/test/mobile/quarantine/pack/MCA/receipts/I32962_ReceiptCreateAssortmentAndLoaded.java
---
(0087792)
marvintm   
2016-06-22 13:52   
It seems there is a problem with the current solution. I've done the following:
- Removed the product "Expedition tent 4 season 2 person"
- Clear browser cache, and log in the Web POS.
- Try to add pack "Camping pack". Notice that only one of the product so the pack is added, and the discount is not applied because the other one is missing.

According to the solution, the pack should not be available in the first place, because one of the products is missing from the assortment.
(0087935)
hgbot   
2016-06-27 08:17   
Repository: tools/automation/pi-mobile
Changeset: 0f78ae4f84377b4f5d95ed0794c43a97ed54ff0e
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jun 27 11:47:21 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/0f78ae4f84377b4f5d95ed0794c43a97ed54ff0e [^]

Verifies issue 32962 : Added automated test 'I32962_VerifyAssortmentDiscountProduct'

---
A src-test/org/openbravo/test/mobile/quarantine/pack/RAN/receipts/I32962_VerifyAssortmentDiscountProductII.java
---
(0087936)
hgbot   
2016-06-27 08:17   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2d78f3791e47c42fd0f37933685a9726f7244fbd
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jun 27 11:47:14 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2d78f3791e47c42fd0f37933685a9726f7244fbd [^]

Fixes issue 32962 : Added assortment products condition to hql in Master Product, Discount & Category

---
M src/org/openbravo/retail/posterminal/master/Category.java
M src/org/openbravo/retail/posterminal/master/Discount.java
M src/org/openbravo/retail/posterminal/master/Product.java
---