Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032954Openbravo ERPZ. Otherspublic2016-05-13 13:022016-06-17 19:37
Reportermaite 
Assigned ToAtulOpenbravo 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q3 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesPayment Report
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032954: Payment Report in Excel format is not setting "," (comma) as decimal separator, although it is defined in Format.xml file
DescriptionPayment Report in Excel format is not setting "," (comma) as decimal separator, although it is defined in Format.xml file
Steps To Reproduce1. Edit Format.xml file to set "<Number name="euroExcel"
       decimal="," grouping="." formatOutput="#,##0.##" formatInternal="#0.00" />"
2. Compile environment (ant smartbuild) and restart tomcat
3. Run Payment Report in Excel format and realize that comma is not used as decimal separator
Proposed SolutionProblem seems to be that "PaymentReportExcel.jrxml" file has not NUMBERFORMAT parameter defined
Additional Information
TagsNo tags attached.
Relationships
related to defect 00298473.0PR15Q3 closed jorge-garcia Decimal and Grouping separators defined in Format.xml are not applied when running Payment Report in PDF 
related to defect 0031710 closed collazoandy4 Review XLS reports to apply cell type when required 
Attached Filespng Image1_Issue32954.png (15,875) 2016-05-18 09:31
https://issues.openbravo.com/file_download.php?file_id=9421&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2016-05-13 13:02maiteNew Issue
2016-05-13 13:02maiteAssigned To => Triage Finance
2016-05-13 13:02maiteModules => Payment Report
2016-05-13 13:02maiteResolution time => 1464213600
2016-05-13 13:02maiteTriggers an Emergency Pack => No
2016-05-13 13:02maiteIssue Monitored: networkb
2016-05-13 13:10maiteRelationship addedrelated to 0029847
2016-05-13 13:37jfrancesIssue Monitored: jfrances
2016-05-16 13:23aferrazAssigned ToTriage Finance => AtulOpenbravo
2016-05-17 10:10AtulOpenbravoStatusnew => scheduled
2016-05-17 10:10AtulOpenbravoNote Added: 0086490
2016-05-17 19:06psanjuanNote Added: 0086506
2016-05-18 09:31psanjuanNote Added: 0086524
2016-05-18 09:31psanjuanFile Added: Image1_Issue32954.png
2016-05-25 10:27hgbotCheckin
2016-05-25 10:27hgbotNote Added: 0086726
2016-05-25 10:27hgbotStatusscheduled => resolved
2016-05-25 10:27hgbotResolutionopen => fixed
2016-05-25 10:27hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6d6e0cbcdbd39d0ea06a7d55aeb23e283d95b7d2 [^]
2016-05-25 10:27hgbotCheckin
2016-05-25 10:27hgbotNote Added: 0086727
2016-05-25 10:28aferrazRelationship addedrelated to 0031710
2016-05-25 10:29aferrazReview Assigned To => aferraz
2016-05-25 10:29aferrazNote Added: 0086728
2016-05-25 10:29aferrazStatusresolved => closed
2016-05-25 10:29aferrazFixed in Version => 3.0PR16Q3
2016-05-25 10:32aferrazNote Added: 0086729
2016-06-17 19:37hudsonbotCheckin
2016-06-17 19:37hudsonbotNote Added: 0087566
2016-06-17 19:37hudsonbotCheckin
2016-06-17 19:37hudsonbotNote Added: 0087567

Notes
(0086490)
AtulOpenbravo   
2016-05-17 10:10   
Test Plan

1. Edit Format.xml file to set
"<Number name="euroExcel" decimal="," grouping="." formatOutput="#,##0.##" formatInternal="#0.00" />"
2. Compile environment (ant smartbuild) and restart tomcat.
3. Run Payment Report in Excel format and check that comma is used as decimal separator for transaction amount and base amount values.
(0086506)
psanjuan   
2016-05-17 19:06   
Issue verified
(0086524)
psanjuan   
2016-05-18 09:31   
Test Plan 1

1. Edit Format.xml file to set
"<Number name="euroExcel" decimal="." grouping="," formatOutput="#,##0.##" formatInternal="#0.00" />"

2. Compile environment (ant smartbuild) and restart tomcat.

3. Run Payment Report in Excel format and check that "point" is used as decimal separator while "comma" is used for grouping in both transaction amount and base amount values. See image 1 attached.


Test Plan 2

1. Edit Format.xml file to set
"<Number name="euroExcel" decimal="," grouping="." formatOutput="#,##0.##" formatInternal="#0.00" />"

2. Compile environment (ant smartbuild) and restart tomcat.

3. Run Payment Report in Excel format and check that "comma" is used as decimal separator while "point" is used for grouping in both transaction amount and base amount values. See image 2 attached.
(0086726)
hgbot   
2016-05-25 10:27   
Repository: erp/devel/pi
Changeset: 6d6e0cbcdbd39d0ea06a7d55aeb23e283d95b7d2
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Tue May 17 13:37:09 2016 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/6d6e0cbcdbd39d0ea06a7d55aeb23e283d95b7d2 [^]

Fixes issue 32954: Payment Report in Excel format is not setting ","
(comma) as decimal separator, although it is defined in Format.xml file

Numberformat parameter added inorder to apply formats on transactional and base amount values

---
M modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReportExcel.jrxml
---
(0086727)
hgbot   
2016-05-25 10:27   
Repository: erp/devel/pi
Changeset: 82ad8711564296dc7a1eb581a0e14de1c0eac258
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue May 24 12:05:23 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/82ad8711564296dc7a1eb581a0e14de1c0eac258 [^]

Related to issue 32954: Code review improvements

---
M modules/org.openbravo.financial.paymentreport/src/org/openbravo/financial/paymentreport/erpCommon/ad_reports/PaymentReportExcel.jrxml
---
(0086728)
aferraz   
2016-05-25 10:29   
Code review + Testing OK
(0086729)
aferraz   
2016-05-25 10:32   
Number format in reports exported to excel depend on the client configuration.
If you want to change the decimal or grouping separator you should change it in your spreadsheet program.
(0087566)
hudsonbot   
2016-06-17 19:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test
(0087567)
hudsonbot   
2016-06-17 19:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test