Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032937Openbravo ERP04. Warehouse managementpublic2016-05-11 19:052016-06-17 19:37
Reporterngarcia 
Assigned Tomarkmm82 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q3 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032937: Wrong parameter is passed to the c_uom_convert function
DescriptionWrong parameter is passed to the c_uom_convert function: it should be the c_uom_id associated to the m_product_uom_id but not the m_product_uom_id:

C_ORDERLINE2_TRG.xml:
         v_QtyOrderReserved:=C_Uom_Convert(v_QtyReserved, :new.C_UOM_ID, :new.m_product_uom_id, 'Y') ;

C_ORDER_POST1.xml:
 
v_QtyOrderPO := -C_Uom_Convert(v_QtyPO, Cur_ResLine.C_UOM_ID, Cur_ResLine.M_Product_UOM_ID, 'Y');

v_QtyOrderSO := -C_Uom_Convert(v_QtySO, Cur_ResLine.C_UOM_ID, Cur_ResLine.M_Product_UOM_ID, 'Y');

v_QtyOrderSO := C_Uom_Convert(v_QtySO, Cur_ResLine.C_UOM_ID, Cur_ResLine.M_Product_UOM_ID, 'Y');

v_QtyOrderPO := C_Uom_Convert(v_QtyPO, Cur_ResLine.C_UOM_ID, Cur_ResLine.M_Product_UOM_ID, 'Y');
Steps To Reproduce*
Proposed SolutionAttached a patch to be analyzed
Additional Information
TagsNo tags attached.
Relationships
related to defect 00229133.0MP21 closed jecharri Second UOM not shown when creating a receipt from an order that has been partially received 
related to defect 00304813.0PR15Q4 closed AtulOpenbravo Wrong quantity conversion in goods receipts under some circumstancies 
Attached Filesdiff FixUOMConvert.diff (3,496) 2016-05-16 13:10
https://issues.openbravo.com/file_download.php?file_id=9417&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-05-11 19:05ngarciaNew Issue
2016-05-11 19:05ngarciaAssigned To => Triage Finance
2016-05-11 19:05ngarciaModules => Core
2016-05-11 19:05ngarciaResolution time => 1466200800
2016-05-11 19:05ngarciaTriggers an Emergency Pack => No
2016-05-11 19:06ngarciaIssue Monitored: networkb
2016-05-11 19:06ngarciaRelationship addedrelated to 0022913
2016-05-12 09:26aferrazAssigned ToTriage Finance => markmm82
2016-05-16 11:40ngarciaRelationship addedrelated to 0030481
2016-05-16 13:10ngarciaFile Added: FixUOMConvert.diff
2016-05-16 13:10ngarciaProposed Solution updated
2016-05-17 17:17markmm82Statusnew => scheduled
2016-05-25 10:27hgbotCheckin
2016-05-25 10:27hgbotNote Added: 0086724
2016-05-25 10:27hgbotStatusscheduled => resolved
2016-05-25 10:27hgbotResolutionopen => fixed
2016-05-25 10:27hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/121bcf7ae05b5e9cd1331b0c180570ea5f5d141b [^]
2016-05-25 10:27hgbotCheckin
2016-05-25 10:27hgbotNote Added: 0086725
2016-05-25 10:35aferrazReview Assigned To => aferraz
2016-05-25 10:35aferrazNote Added: 0086730
2016-05-25 10:35aferrazStatusresolved => closed
2016-05-25 10:35aferrazFixed in Version => 3.0PR16Q3
2016-06-17 19:37hudsonbotCheckin
2016-06-17 19:37hudsonbotNote Added: 0087564
2016-06-17 19:37hudsonbotCheckin
2016-06-17 19:37hudsonbotNote Added: 0087565

Notes
(0086724)
hgbot   
2016-05-25 10:27   
Repository: erp/devel/pi
Changeset: 121bcf7ae05b5e9cd1331b0c180570ea5f5d141b
Author: Mark <markmm82 <at> gmail.com>
Date: Tue May 17 11:39:36 2016 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/121bcf7ae05b5e9cd1331b0c180570ea5f5d141b [^]

Fixes issue 32937: Correct parameter is passed to the c_uom_convert function

The correct parameter is passed to the c_uom_convert function: it is the c_uom_id associated to the m_product_uom_id instead the m_product_uom_id.

---
M src-db/database/model/functions/C_ORDER_POST1.xml
M src-db/database/model/triggers/C_ORDERLINE2_TRG.xml
---
(0086725)
hgbot   
2016-05-25 10:27   
Repository: erp/devel/pi
Changeset: 8d4bd74e71c7260c42df2e1a25ee93e52cfb11a0
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue May 24 18:11:55 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8d4bd74e71c7260c42df2e1a25ee93e52cfb11a0 [^]

Related to issue 32937: Code review improvements

---
M src-db/database/model/functions/C_ORDER_POST1.xml
M src-db/database/model/functions/M_INOUT_CREATE.xml
M src-db/database/model/triggers/C_ORDERLINE2_TRG.xml
---
(0086730)
aferraz   
2016-05-25 10:35   
Code review + Testing OK
(0087564)
hudsonbot   
2016-06-17 19:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test
(0087565)
hudsonbot   
2016-06-17 19:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test